Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 917479 - =x11-misc/xkeyboard-config-2.40 requires x11-apps/xkbcomp for tests
Summary: =x11-misc/xkeyboard-config-2.40 requires x11-apps/xkbcomp for tests
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal minor (vote)
Assignee: Gentoo X packagers
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2023-11-17 08:29 UTC by Fabio Scaccabarozzi
Modified: 2023-11-17 13:04 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Fabio Scaccabarozzi 2023-11-17 08:29:30 UTC
In a wayland-first environment, not all X11 stack is installed.

Emerging xkeyboard-config without xkbcomp installed fails because xkbcomp is missing.

The ebuild is missing a "test? ( x11-apps/xkbcomp )" stanza.

Reproducible: Always

Steps to Reproduce:
1. emerge -C xkbcomp
2. FEATURES=test emerge -1 xkeyboard-config
3.
Actual Results:  
Tests fail

Expected Results:  
Tests should pass

Installing xkbcomp is enough to make tests work again.

I have not seen this failure with xkeyboard-config-2.39.
Comment 1 Alfred Wingate 2023-11-17 09:08:12 UTC
Requirement has been here for a while, most likely didn't cause an issue in 2.39 due to the nonfatal pytest requirement masking it.

https://gitlab.freedesktop.org/xkeyboard-config/xkeyboard-config/-/commit/118178208e6aebea5b9c85edb752a50e82bb3144

Verifying here for more missed dependencies
https://gitlab.freedesktop.org/xkeyboard-config/xkeyboard-config/-/blob/master/.gitlab-ci.yml?ref_type=heads#L59

Going through these Ill note what appear to be legitimate and missing.

Optional test dependency dev-python/pycountry
https://gitlab.freedesktop.org/xkeyboard-config/xkeyboard-config/-/blob/master/tests/test_rules_xml.py?ref_type=heads#L231 

Mandatory dev-python/xkbcommon
https://gitlab.freedesktop.org/xkeyboard-config/xkeyboard-config/-/blob/master/tests/test_regressions.py?ref_type=heads#L13

Mandatory dev-python/pyyaml
https://gitlab.freedesktop.org/xkeyboard-config/xkeyboard-config/-/blob/master/.gitlab-ci/yaml-to-junit-xml.py#L8
Comment 2 Alfred Wingate 2023-11-17 09:10:39 UTC
Correction, dev-python/pyyaml is not valid. Should have been more awake in what files I was looking at. It's used by the gitlab CI not the tests.
Comment 3 Alfred Wingate 2023-11-17 09:29:55 UTC
And correction 2 dev-python/xkbcommon isn't required as the tests bundle their own "xkbcommon" which is similar in function but different in implementation (ctypes vs cffi).

This does mean that x11-libs/libxkbcommon is a direct requirement then.
Comment 4 Larry the Git Cow gentoo-dev 2023-11-17 13:04:03 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b05e64d1c324a4a4763196c29fef2a7a214fdb73

commit b05e64d1c324a4a4763196c29fef2a7a214fdb73
Author:     Alfred Wingate <parona@protonmail.com>
AuthorDate: 2023-11-17 09:33:39 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-11-17 13:03:30 +0000

    x11-misc/xkeyboard-config: add missing test dependencies
    
    * New revision due to plenty dropped keywords
    * pytest-xdist is used if available, make it requirement so that
      everybody benefits.
    * Disabled timeout for pytest tests. Observed it already take 40s with
      xdist and a 12 thread cpu, so you can't trust it to not fail due to high
      load congestion.
    
    Closes: https://bugs.gentoo.org/917479
    Signed-off-by: Alfred Wingate <parona@protonmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/33864
    Signed-off-by: Sam James <sam@gentoo.org>

 .../xkeyboard-config-2.40-r1.ebuild                | 65 ++++++++++++++++++++++
 .../xkeyboard-config/xkeyboard-config-9999.ebuild  | 22 +++++++-
 2 files changed, 85 insertions(+), 2 deletions(-)