Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 917393 - sci-libs/proj not install the *.tif files from proj-data
Summary: sci-libs/proj not install the *.tif files from proj-data
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Sci-geo Project
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2023-11-15 20:09 UTC by Marco Genasci
Modified: 2024-01-10 13:25 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Marco Genasci 2023-11-15 20:09:48 UTC
The ebuild downalods the proj-data archive, a collection of geotiff files, and unpack it on "${S}"/data, but during the installation phase are not installed.
I think this happens because the CMakeList.txt file in the data directory is missing the entry to copy *.tif files.
The following patch fixes this problem:

diff -Naru a/data/CMakeLists.txt b/data/CMakeLists.txt
--- a/data/CMakeLists.txt       2023-11-15 21:03:02.168022189 +0100
+++ b/data/CMakeLists.txt       2023-11-15 21:04:50.704179622 +0100
@@ -28,6 +28,7 @@
 set(GRIDSHIFT_FILES ${GSB_FILES} ${GTX_FILES})
 
 file(GLOB SCHEMA_FILES *.json)
+file(GLOB GEOTIFF_FILES *.tif)
 
 set(ALL_SQL_IN "${CMAKE_CURRENT_BINARY_DIR}/all.sql.in")
 set(PROJ_DB "${CMAKE_CURRENT_BINARY_DIR}/proj.db")
@@ -98,6 +99,7 @@
   ${GRIDSHIFT_FILES}
   ${PROJ_DB}
   ${SCHEMA_FILES}
+  ${GEOTIFF_FILES}
 )
 install(
   FILES ${ALL_DATA_FILE}

Reproducible: Always
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-11-26 00:21:20 UTC
Could you send the patch upstream?
Comment 2 Marco Genasci 2023-11-26 07:47:58 UTC
Done.
Comment 3 Marco Genasci 2023-11-26 17:35:37 UTC
The patch was merged upstream. 
Should I create a PR to back port the patch to earlier versions?
Comment 4 Larry the Git Cow gentoo-dev 2024-01-10 13:25:17 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=92c42a318e0f956e3cf42c8d1b6e4e24eeab3d5f

commit 92c42a318e0f956e3cf42c8d1b6e4e24eeab3d5f
Author:     Marco Genasci <fedeliallalinea@gmail.com>
AuthorDate: 2023-12-11 19:14:51 +0000
Commit:     Andrew Ammerlaan <andrewammerlaan@gentoo.org>
CommitDate: 2024-01-10 13:24:59 +0000

    sci-libs/proj: add patch to install geotiff files
    
    This patch is a backport of an upstream patch that will be
    applied in version 9.4.0 scheduled for March 01, 2024.
    
    Upstream: https://github.com/OSGeo/PROJ/pull/3970
    Closes: https://bugs.gentoo.org/917393
    Signed-off-by: Marco Genasci <fedeliallalinea@gmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/34242
    Signed-off-by: Andrew Ammerlaan <andrewammerlaan@gentoo.org>

 sci-libs/proj/files/proj-geotiff.patch             | 33 ++++++++++++++++++++++
 .../{proj-9.2.1.ebuild => proj-9.2.1-r1.ebuild}    |  6 +++-
 .../{proj-9.3.0.ebuild => proj-9.3.0-r1.ebuild}    |  6 +++-
 3 files changed, 43 insertions(+), 2 deletions(-)