Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 917264 - sci-physics/root: Unused use flag jupyter
Summary: sci-physics/root: Unused use flag jupyter
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Guilherme Amadio
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-11-12 23:00 UTC by APN-Pucky
Modified: 2023-11-15 07:58 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description APN-Pucky 2023-11-12 23:00:13 UTC
Currently this use flag does nothing. I would liked to get rid of the jupyter->nodejs+qt dependency.
Comment 1 Guilherme Amadio gentoo-dev 2023-11-14 08:38:40 UTC
Indeed, when I added the flag, in the commit linked below, I by mistake unconditionally depended on jupyter et al:

https://gitweb.gentoo.org/repo/gentoo.git/commit/sci-physics/root?id=4cf3d9955693efdf7c3f4f4fcff869886fbae6d8

I don't know what is better, but probably just removing the USE flag is not a bad idea (and always depending on jupyter when PyROOT is enabled). Otherwise, the dependencies need to be updated to only trigger when the USE flag is enabled, because these dependencies are not really necessary to just use ROOT, even when PyROOT is enabled.

However, I don't understand the jupyter -> nodejs+qt issue you mention.
Comment 2 APN-Pucky 2023-11-14 08:58:00 UTC
> I don't understand the jupyter -> nodejs+qt issue you mention.

Jupyter pulls in dev-python/notebook which in term depends on nodejs.

Jupyter also needs qtconsole, even if I want root w/o qt5 (USE="-qt5").

If I just want c++-root (+python) I don't want to depend on nodejs and qt5 (i.e. some container image with root,etc.).
Comment 3 Guilherme Amadio gentoo-dev 2023-11-14 12:30:05 UTC
Ah, then what I should do is fix the dependencies, the intention was to only bring in jupyter and notebook with USE=jupyter. I will fix it now while I'm bumping ROOT to 6.30.00.
Comment 4 Larry the Git Cow gentoo-dev 2023-11-14 15:13:50 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e6da30824d2c3738ed215a22ee3f1619474bd6d1

commit e6da30824d2c3738ed215a22ee3f1619474bd6d1
Author:     Guilherme Amadio <amadio@gentoo.org>
AuthorDate: 2023-11-14 12:33:09 +0000
Commit:     Guilherme Amadio <amadio@gentoo.org>
CommitDate: 2023-11-14 15:13:36 +0000

    sci-physics/root: fix dependencies for USE=jupyter
    
    Closes: https://bugs.gentoo.org/917264
    Fixes: 4cf3d9955693efdf7c3f4f4fcff869886fbae6d8
    
    Signed-off-by: Guilherme Amadio <amadio@gentoo.org>

 sci-physics/root/root-6.28.08.ebuild   | 13 ++++++++-----
 sci-physics/root/root-6.28.9999.ebuild | 13 ++++++++-----
 sci-physics/root/root-9999.ebuild      | 13 ++++++++-----
 3 files changed, 24 insertions(+), 15 deletions(-)
Comment 5 APN-Pucky 2023-11-15 07:58:23 UTC
Thanks. In my case that reduced its dependencies from ~250 packages to only 17.