Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 917101 - [kde overlay] kde-apps/kio-extras-9999 upstream f220e0ebf requires (USE=)activities now
Summary: [kde overlay] kde-apps/kio-extras-9999 upstream f220e0ebf requires (USE=)acti...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Overlays (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo KDE team
URL: https://invent.kde.org/network/kio-ex...
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2023-11-10 04:13 UTC by Duncan
Modified: 2023-12-23 18:30 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Duncan 2023-11-10 04:13:42 UTC
(Note that at least as of upstream b9ae1ab48, head when I pulled, kio-extras-9999 is still KF5 compatible.)

kio-extras upstream (emails despammed):

commit f220e0ebf
Author:     Nicolas Fella <nicolas.fella@gmx>
AuthorDate: Wed Nov 1 17:15:22 2023 +0100
Commit:     Nicolas Fella <nicolas.fella@gmx>
CommitDate: Tue Nov 7 00:22:59 2023 +0100

Make KActivities dependencies required

Unless on Windows


Unsurprisingly, with that commit attempting to build with USE=-activities results in cmake errors, the first of which is:

CMake Error at CMakeLists.txt:69 (find_package):
find_package for module KF5Activities called with REQUIRED, but
CMAKE_DISABLE_FIND_PACKAGE_KF5Activities is enabled.  A REQUIRED package
cannot be disabled.


USE=activities allows it to build.

So I guess USE=activities disappears for kio-extras and the deps become mandatory, now.


Reproducible: Always
Comment 1 Duncan 2023-12-03 23:40:30 UTC
kio-extras-9999 went kf6 now.

But FWIW I discovered kio-extras is RDEP-only for the two packages I have requiring it (dolphin and plasma-workspace), and so far testing indicates both degrade gracefully without the functionality I don't need anyway, so I'm null-packaging it in my overlay and calling it good.  One previously live-git package not to have to worry about updating, at least for my limited remaining slot 5 time.

Assuming that graceful-failure RDEP-only status doesn't change for slot 6, please consider putting the dep behind a USE-flag or even making it an optfeature.  (I'd do a new bug for that but not sure 6 dep-status remains the same and it's not worth it for 5-only at this point.)
Comment 2 Andreas Sturmlechner gentoo-dev 2023-12-07 11:30:46 UTC
We need to consider typical usage oft these applications where kio-extras is integral. So optfeature is completely out of the question here.
Comment 3 Duncan 2023-12-08 09:46:17 UTC
(In reply to Duncan from comment #1)
> But FWIW I discovered kio-extras is RDEP-only for the two packages I have
> requiring it (dolphin and plasma-workspace), and so far testing indicates
> both degrade gracefully without the functionality I don't need anyway

Turns out gwenview uses it too -- without (r-)depending on it. Without kio-extras in-directory thumbnails show up when actually in the dir, but gwenview no longer generates the directory composite-thumbnails that display four of the thumbs on folder icon when browsing the parent dir.  That's critical to the way I use gwenview (displays what's in a subdir without actually entering it), so while I could arguably do without kio-extras for dolphin and plasma-workspace, I need it for gwenview.

So I guess gwenview should at least optfeature kio-extras too, tho from comment #2, USE or even straight RDEP.
Comment 4 Larry the Git Cow gentoo-dev 2023-12-22 18:17:55 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/proj/kde.git/commit/?id=c4ec76c51c11dafd4aed63731ec9249fcbdbd6be

commit c4ec76c51c11dafd4aed63731ec9249fcbdbd6be
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2023-12-16 20:47:12 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2023-12-22 18:09:10 +0000

    kde-apps/kio-extras: Use BUILD_ACTIVITIES option
    
    Upstream commit d74e09cace0cd533648b37e81c9d07f9a7c82043
    
    Drop unused cmake option -DBUILD_KDSoapWSDiscoveryClient
    
    Closes: https://bugs.gentoo.org/917101
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 kde-apps/kio-extras/kio-extras-9999.ebuild | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)
Comment 5 Larry the Git Cow gentoo-dev 2023-12-23 16:08:37 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/kde.git/commit/?id=bd0117b0fb0ffa61adb0ddf319a7b47a4e138a75

commit bd0117b0fb0ffa61adb0ddf319a7b47a4e138a75
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2023-12-22 17:59:28 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2023-12-23 16:08:28 +0000

    kde-apps/kio-extras-kf5: Re-add IUSE activities
    
    Upstream commit d6db8756c906db73b22faf83a3bb5d2884342ba8
    
    Bug: https://bugs.gentoo.org/917101
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 kde-apps/kio-extras-kf5/kio-extras-kf5-9999.ebuild | 11 +++++++----
 kde-apps/kio-extras-kf5/metadata.xml               |  1 +
 2 files changed, 8 insertions(+), 4 deletions(-)
Comment 6 Larry the Git Cow gentoo-dev 2023-12-23 18:30:42 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=866153ea43d28f1d8f7338f79add74a35a5ad586

commit 866153ea43d28f1d8f7338f79add74a35a5ad586
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2023-12-22 17:59:28 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2023-12-23 18:29:30 +0000

    kde-apps/kio-extras-kf5: Re-add IUSE activities
    
    Relax kde-apps/kio-extras:5 blocker to <23.08.5-r100:5
    
    Bug: https://bugs.gentoo.org/917101
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 ...o-extras-kf5-24.01.85-activities-optional.patch | 48 ++++++++++++++++++++++
 .../kio-extras-kf5/kio-extras-kf5-24.01.85.ebuild  | 15 ++++---
 kde-apps/kio-extras-kf5/metadata.xml               |  1 +
 3 files changed, 59 insertions(+), 5 deletions(-)