It would allow me to delete 1.3.3 and 1.3.4 with warnings and EAPI 7: # eshowkw Keywords for media-gfx/imageworsener: | | u | | a a p s l r a | n | | m r h p p i o i s l m m | e u s | r | d a m p p c a x a o s 3 p 6 i | a s l | e | 6 r 6 p p 6 r 8 6 n c 9 h 8 p | p e o | p | 4 m 4 a c 4 c 6 4 g v 0 a k s | i d t | o ------+-------------------------------+---------+------- 1.3.3 | + o o o o o o + o o o o o o o | 7 o 0 | gentoo ------+-------------------------------+---------+------- 1.3.4 | ~ o o o o o o ~ o o o o o o o | 7 # 0/3 | gentoo 1.3.5 | ~ o o o o o o ~ o o o o o o o | 8 o | gentoo # pkgcheck scan "$(basename $(dirname $(pwd)))/$(basename $(pwd))" gentoo -- updating git cache: commit date: 2023-11-05 media-gfx/imageworsener DeprecatedDep: version 1.3.3: DEPEND: deprecated dependency: virtual/jpeg:0 DeprecatedDep: version 1.3.3: RDEPEND: deprecated dependency: virtual/jpeg:0 DeprecatedDep: version 1.3.4: DEPEND: deprecated dependency: virtual/jpeg:0 DeprecatedDep: version 1.3.4: RDEPEND: deprecated dependency: virtual/jpeg:0 RedundantVersion: version 1.3.4: slot(0) keywords are overshadowed by version: 1.3.5 StableRequest: version 1.3.5: slot(0) no change in 343 days for unstable keywords: [ ~amd64, ~x86 ] Thanks in advance!
This is actually failing tests, but they are silently suppressed right now. I've opened an upstream PR to change that: https://github.com/jsummers/imageworsener/pull/46
(In reply to matoro from comment #1) > This is actually failing tests, but they are silently suppressed right now. > I've opened an upstream PR to change that: > https://github.com/jsummers/imageworsener/pull/46 Thanks for the pull request! I opened a related issue upstream just now also: https://github.com/jsummers/imageworsener/issues/47 I'm not sure these differences should block stabilization or not, both 1.3.3 and 1.3.5 have some images where actual and expected differ visually.
To summarize my current impression: - Both 1.3.3 and 1.3.5 have failing tests cases, 5 to 7 of them - 1.3.5 has two failures more, cases: - expected/jpegoc.jpg - expected/jpegrst.jpg - Both of these cases were added with new features in 1.3.5 so it's not something that broke after 1.3.3 (but that's only a superficial analysis so far): - https://github.com/jsummers/imageworsener/commit/9515775c2d2fe1bfe4445e5dca7f0dc4e5266dbc - https://github.com/jsummers/imageworsener/commit/e735cdf1635958a1c4aea64d71d033064eb64bef - The linked pull request will the ebuild tests fail because of that, so it arguably won't help - Upstream is either busy or not interested in improving on the situation. My vote for: - Not applying the Gentoo pull request - Stabilizing 1.3.5. What do you think?
I don't think not-applying the PR is really a good move in any case. If the tests are broken and we can justify them being broken (and you have), you should restrict them, not leave the exit code broken.
(In reply to Sam James from comment #4) > If the tests are broken and we can justify them being broken (and you have), > you should restrict them, not leave the exit code broken. Hi Sam, that's a fair point, good idea. (In reply to Sam James from comment #4) > I don't think not-applying the PR is really a good move in any case. To restrict the tests we need a different patch though. I would want to restrict tests and add a comment to the ebuild that the exit code is misleading and link to upstream pull request https://github.com/jsummers/imageworsener/pull/46 for proof. What do you think?
(In reply to Sebastian Pipping from comment #5) I don't personally see a reason to leave the exit code broken. It's a footgun and a quick fix. I'd fix that + restrict personally (for the real failures).
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=28a046309bf1a0bf83f08c6feb48a4a67dd5d93e commit 28a046309bf1a0bf83f08c6feb48a4a67dd5d93e Author: Matoro Mahri <matoro_gentoo@matoro.tk> AuthorDate: 2024-02-21 01:55:00 +0000 Commit: Sebastian Pipping <sping@gentoo.org> CommitDate: 2024-03-08 22:42:08 +0000 media-gfx/imageworsener: Respect tests exit code Also restrict tests because the tests are broken. Closes: https://bugs.gentoo.org/916906 Closes: https://github.com/gentoo/gentoo/pull/35455 Signed-off-by: Matoro Mahri <matoro_gentoo@matoro.tk> Signed-off-by: Sebastian Pipping <sping@gentoo.org> .../imageworsener-1.3.5-runtest-exit-code.patch | 24 ++++++++++++++++++++++ media-gfx/imageworsener/imageworsener-1.3.5.ebuild | 6 ++++-- 2 files changed, 28 insertions(+), 2 deletions(-)
(In reply to Sam James from comment #6) > (In reply to Sebastian Pipping from comment #5) > I don't personally see a reason to leave the exit code broken. It's a > footgun and a quick fix. I'd fix that + restrict personally (for the real > failures). I went for your suggestion now, applied the patch, restricted tests, and slightly renamed the patch file also. Thanks to Matoro!
Re-opening because the issue was about stabilization… sorry.
amd64 done
x86 done all arches done
