Bug 916735 – dev-java/openjdk-21.0.1_p12 fails to compile (lto): src/hotspot/share/jfr/jni/jfrJniMethod.hpp:128:14: error: 'jfr_abort' violates the C++ One Definition Rule [-Werror=odr]

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Kostadin Shishmanov 2023-11-03 05:58:46 UTC]

Created attachment 873940 [details]
build log compressed with xz

dev-java/openjdk-21.0.1_p12 fails to compile when using LTO and turning ODR violations into errors with -Werror=odr

/var/tmp/portage/dev-java/openjdk-21.0.1_p12/work/jdk21u-jdk-21.0.1-ga/src/hotspot/share/jfr/jni/jfrJniMethod.hpp:128:14: error: 'jfr_abort' violates the C++ One Definition Rule [-Werror=odr]
  128 | void JNICALL jfr_abort(JNIEnv* env, jclass jvm, jstring errorMsg);
      |              ^
/var/tmp/portage/dev-java/openjdk-21.0.1_p12/work/jdk21u-jdk-21.0.1-ga/src/hotspot/share/jfr/jni/jfrJniMethod.cpp:339:1: note: type mismatch in parameter 2
  339 | JVM_ENTRY_NO_ENV(void, jfr_abort(JNIEnv* env, jobject jvm, jstring errorMsg))
      | ^
/var/tmp/portage/dev-java/openjdk-21.0.1_p12/work/jdk21u-jdk-21.0.1-ga/src/hotspot/share/jfr/jni/jfrJniMethod.cpp:339:1: note: type 'struct _jobject *' should match type 'struct _jclass *'
/var/tmp/portage/dev-java/openjdk-21.0.1_p12/work/jdk21u-jdk-21.0.1-ga/src/hotspot/share/jfr/jni/jfrJniMethod.cpp:339:1: note: 'jfr_abort' was previously declared here
/var/tmp/portage/dev-java/openjdk-21.0.1_p12/work/jdk21u-jdk-21.0.1-ga/src/hotspot/share/jfr/jni/jfrJniMethod.cpp:339:1: note: code may be misoptimized unless '-fno-strict-aliasing' is used
/var/tmp/portage/dev-java/openjdk-21.0.1_p12/work/jdk21u-jdk-21.0.1-ga/src/hotspot/share/jfr/jni/jfrJniMethod.hpp:126:14: error: 'jfr_flush' violates the C++ One Definition Rule [-Werror=odr]
  126 | void JNICALL jfr_flush(JNIEnv* env, jclass jvm);
      |              ^
/var/tmp/portage/dev-java/openjdk-21.0.1_p12/work/jdk21u-jdk-21.0.1-ga/src/hotspot/share/jfr/jni/jfrJniMethod.cpp:313:1: note: type mismatch in parameter 2
  313 | JVM_ENTRY_NO_ENV(void, jfr_flush(JNIEnv* env, jobject jvm))
      | ^
/var/tmp/portage/dev-java/openjdk-21.0.1_p12/work/jdk21u-jdk-21.0.1-ga/src/hotspot/share/jfr/jni/jfrJniMethod.cpp:313:1: note: type 'struct _jobject *' should match type 'struct _jclass *'
/var/tmp/portage/dev-java/openjdk-21.0.1_p12/work/jdk21u-jdk-21.0.1-ga/src/hotspot/share/jfr/jni/jfrJniMethod.cpp:313:1: note: 'jfr_flush' was previously declared here
/var/tmp/portage/dev-java/openjdk-21.0.1_p12/work/jdk21u-jdk-21.0.1-ga/src/hotspot/share/jfr/jni/jfrJniMethod.cpp:313:1: note: code may be misoptimized unless '-fno-strict-aliasing' is used
/var/tmp/portage/dev-java/openjdk-21.0.1_p12/work/jdk21u-jdk-21.0.1-ga/src/hotspot/share/jfr/jni/jfrJniMethod.hpp:122:18: error: 'jfr_event_writer_flush' violates the C++ One Definition Rule [-Werror=odr]
  122 | jboolean JNICALL jfr_event_writer_flush(JNIEnv* env, jclass cls, jobject writer, jint used_size, jint requested_size);
      |                  ^
/var/tmp/portage/dev-java/openjdk-21.0.1_p12/work/jdk21u-jdk-21.0.1-ga/src/hotspot/share/jfr/jni/jfrJniMethod.cpp:305:1: note: return value type mismatch
  305 | NO_TRANSITION(void, jfr_event_writer_flush(JNIEnv* env, jclass jvm, jobject writer, jint used_size, jint requested_size))
      | ^
/var/tmp/portage/dev-java/openjdk-21.0.1_p12/work/jdk21u-jdk-21.0.1-ga/src/hotspot/share/jfr/jni/jfrJniMethod.cpp:305:1: note: type 'void' should match type 'jboolean'
/var/tmp/portage/dev-java/openjdk-21.0.1_p12/work/jdk21u-jdk-21.0.1-ga/src/hotspot/share/jfr/jni/jfrJniMethod.cpp:305:1: note: 'jfr_event_writer_flush' was previously declared here

[Comment 1 Jonas Stein 2023-11-05 21:49:25 UTC]

I think we can work with the information provided. 
Just in case there is something odd, please add a paste of the emerge info
as described on https://wiki.gentoo.org/wiki/Attach_the_logs_to_the_bug_ticket

[Comment 2 Kostadin Shishmanov 2023-11-06 06:02:24 UTC]

(In reply to Jonas Stein from comment #1)
> I think we can work with the information provided. 
> Just in case there is something odd, please add a paste of the emerge info
> as described on
> https://wiki.gentoo.org/wiki/Attach_the_logs_to_the_bug_ticket
No idea how i've missed it. Sorry!


Portage 3.0.54 (python 3.11.6-final-0, default/linux/amd64/17.1/desktop/plasma/systemd/merged-usr, gcc-14, glibc-2.38-r7, 6.5.10-gentoo x86_64)
=================================================================
System uname: Linux-6.5.10-gentoo-x86_64-13th_Gen_Intel-R-_Core-TM-_i5-13600KF-with-glibc2.38
KiB Mem:    16245732 total,  11493368 free
KiB Swap:   24633336 total,  23797004 free
Timestamp of repository gentoo: Mon, 06 Nov 2023 00:31:57 +0000
Head commit of repository gentoo: 329352951028011420ddcb607ea39cfdb6e9137a

Head commit of repository brave-overlay: 9e859c375d61f5eda5cf0f180d895f290625f490

Timestamp of repository guru: Sat, 04 Nov 2023 18:03:36 +0000
Head commit of repository guru: 5590472eb3a085259ed3f2a779bebcc22c9a0cb1

Timestamp of repository steam-overlay: Sat, 04 Nov 2023 18:03:01 +0000
Head commit of repository steam-overlay: 65064439da16168f9a5cc63e262421f90b999bb9

sh bash 5.2_p15-r7
ld GNU ld (Gentoo 2.41 p2) 2.41.0
ccache version 4.8.3 [disabled]
app-misc/pax-utils:        1.3.7::gentoo
app-shells/bash:           5.2_p15-r7::gentoo
dev-java/java-config:      2.3.1-r1::gentoo
dev-lang/perl:             5.38.0-r1::gentoo
dev-lang/python:           3.11.6::gentoo, 3.12.0_p1::gentoo
dev-lang/rust:             1.73.0::gentoo
dev-util/ccache:           4.8.3::gentoo
dev-util/cmake:            3.27.7::gentoo
dev-util/meson:            1.2.3::gentoo
sys-apps/baselayout:       2.14::gentoo
sys-apps/sandbox:          2.38::gentoo
sys-apps/systemd:          254.5::gentoo
sys-devel/autoconf:        2.13-r8::gentoo, 2.71-r7::gentoo
sys-devel/automake:        1.16.5-r1::gentoo
sys-devel/binutils:        2.41-r2::gentoo
sys-devel/binutils-config: 5.5::gentoo
sys-devel/clang:           16.0.6::gentoo, 17.0.3::gentoo
sys-devel/gcc:             13.2.1_p20231014::gentoo, 14.0.0_pre20231029::gentoo
sys-devel/gcc-config:      2.11::gentoo
sys-devel/libtool:         2.4.7-r1::gentoo
sys-devel/lld:             17.0.3::gentoo
sys-devel/llvm:            16.0.6::gentoo, 17.0.3::gentoo
sys-devel/make:            4.4.1-r1::gentoo
sys-kernel/linux-headers:  6.6::gentoo (virtual/os-headers)
sys-libs/glibc:            2.38-r7::gentoo
Repositories:

gentoo
    location: /var/db/repos/gentoo
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/gentoo.git
    priority: -1000
    volatile: False

brave-overlay
    location: /var/db/repos/brave-overlay
    sync-type: git
    sync-uri: https://gitlab.com/jason.oliveira/brave-overlay.git
    masters: gentoo
    volatile: False

guru
    location: /var/db/repos/guru
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/guru.git
    masters: gentoo
    volatile: False

local
    location: /var/db/repos/local
    masters: gentoo
    volatile: True

steam-overlay
    location: /var/db/repos/steam-overlay
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/steam-overlay.git
    masters: gentoo
    volatile: False

Binary Repositories:

gentoobinhost
    priority: 1
    sync-uri: https://gentoo.osuosl.org/releases/amd64/binpackages/17.1/x86-64

ACCEPT_KEYWORDS="amd64 ~amd64"
ACCEPT_LICENSE="*"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-march=raptorlake -O2 -pipe -flto=auto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/lib64/libreoffice/program/sofficerc /usr/share/config /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d"
CXXFLAGS="-march=raptorlake -O2 -pipe -flto=auto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing"
DISTDIR="/var/cache/distfiles"
ENV_UNSET="CARGO_HOME DBUS_SESSION_BUS_ADDRESS DISPLAY GDK_PIXBUF_MODULE_FILE GOBIN GOPATH PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR XDG_STATE_HOME"
FCFLAGS="-march=raptorlake -O2 -pipe -flto=auto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing"
FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs binpkg-multi-instance buildpkg-live config-protect-if-modified distlocks ebuild-locks fixlafiles ipc-sandbox merge-sync multilib-strict network-sandbox news parallel-fetch pid-sandbox pkgdir-index-trusted preserve-libs protect-owned qa-unresolved-soname-deps sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-march=raptorlake -O2 -pipe -flto=auto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing"
GENTOO_MIRRORS="http://tux.rainside.sk/gentoo/     http://gentoo.mirror.root.lu/     ftp://tux.rainside.sk/gentoo/     http://ftp.vectranet.pl/gentoo/"
LANG="en_GB.utf8"
LDFLAGS="-Wl,-O1,--as-needed -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing"
LEX="flex"
MAKEOPTS="-j20"
PKGDIR="/var/cache/binpkgs"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
RUSTFLAGS="-C target-cpu=raptorlake -C opt-level=2"
SHELL="/bin/bash"
USE="X aac acl acpi activities amd64 branding bzip2 cairo cdr cli crypt cups dbus declarative dri dvdr encode exif flac fortran gdbm gif gtk gui iconv icu jpeg kde kwallet lcms libnotify libtirpc mad mng mp3 mp4 mpeg multilib ncurses networkmanager nls nptl ogg opengl openmp pam pango pcre pdf pipewire plasma png policykit ppds pulseaudio qml qt5 readline screencast sdl seccomp sound ssl startup-notification svg systemd test-rust tiff truetype udev udisks unicode upower usb vaapi vulkan wayland widgets wxwidgets x264 xattr xcb xft xml xv zlib zstd" ABI_X86="64" ADA_TARGET="gnat_2021" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon sheets words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="mmx mmxext sse sse2 aes avx avx2 f16c fma3 pclmul popcnt rdrand sha sse3 sse4_1 sse4_2 ssse3" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock greis isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" GRUB_PLATFORMS="efi-64" INPUT_DEVICES="libinput" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LUA_SINGLE_TARGET="lua5-1" LUA_TARGETS="lua5-1" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php8-1" POSTGRES_TARGETS="postgres15" PYTHON_SINGLE_TARGET="python3_11" PYTHON_TARGETS="python3_11" RUBY_TARGETS="ruby31" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq proto steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  ADDR2LINE, AR, ARFLAGS, AS, ASFLAGS, CC, CCLD, CONFIG_SHELL, CPP, CPPFLAGS, CTARGET, CXX, CXXFILT, ELFEDIT, EMERGE_DEFAULT_OPTS, EXTRA_ECONF, F77FLAGS, FC, GCOV, GPROF, INSTALL_MASK, LC_ALL, LD, LFLAGS, LIBTOOL, LINGUAS, MAKE, MAKEFLAGS, NM, OBJCOPY, OBJDUMP, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, RANLIB, READELF, SIZE, STRINGS, STRIP, YACC, YFLAGS

[Comment 3 Eli Schwartz 2024-08-27 19:00:49 UTC]

version 17 works fine, the error is in 21 only.

Mismatch for e.g. jfr_flush / jfr_abort introduced in https://github.com/openjdk/jdk21u/commit/c199b8c761c14542953a01c1efd6ccec95179234

[Comment 4 Eli Schwartz 2024-08-27 19:14:56 UTC]

Bug Report Submission Complete

Thank You

Thank you for taking the time to provide us with your details.
What's Next

We will review your report and have assigned it an internal review ID : 9077501. Depending upon the completeness of the report and our ability to reproduce the problem, either a new bug will be posted, or we will contact you for further information.

We will try to process all newly posted bugs in a timely manner, but we make no promises about the amount of time in which a bug will be fixed. If you just reported a bug that could have a major impact on your project, consider using one of the technical support offerings available at Oracle Support.

Thank you again for using this site.



We shall see how it goes...

[Comment 5 Larry the Git Cow 2024-08-27 19:21:45 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4456f4048fd742900e7d267cfa1128dae6ff5510

commit 4456f4048fd742900e7d267cfa1128dae6ff5510
Author:     Eli Schwartz <[e-mail]>
AuthorDate: 2024-08-27 19:16:58 +0000
Commit:     Eli Schwartz <[e-mail]>
CommitDate: 2024-08-27 19:21:15 +0000

    dev-java/openjdk: mark as LTO-unsafe
    
    Temporarily disable the USE=lto support for the 21.x ebuild only, as
    that's the version it broke in.
    
    OpenJDK cannot get their act together, so their ticketing system is
    that you cannot report a bug unless you're a project member, and your
    alternative is to fill in a form on the Oracle website and they will
    analyze your submission and file a bug on your behalf at some point.
    Hopefully.
    
    This is not a ringing endorsement of OpenJDK as an *open* implementation
    of Java, but it is what it is... I can't currently provide a public
    ticket number but perhaps sometime in the future.
    
    Closes: https://bugs.gentoo.org/916735
    Signed-off-by: Eli Schwartz <[e-mail]>

 dev-java/openjdk/openjdk-21.0.4_p7.ebuild | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

[Comment 6 w.iron.zombie 2024-12-26 21:00:41 UTC]

Is it still an issue? I copied the 24.0.1_p0 ebuild locally today, re-enabled USE=lto and it built fine (with clang 19 that is; I didn't try gcc)

[Comment 7 Eli Schwartz 2024-12-27 00:28:57 UTC]

(In reply to w.iron.zombie from comment #6)
> Is it still an issue? I copied the 24.0.1_p0 ebuild locally today,
> re-enabled USE=lto and it built fine (with clang 19 that is; I didn't try
> gcc)

If you tried to build with clang then you didn't try to determine whether this bug still exists.

Clang doesn't check for ODR violations, you need GCC for that. Even though clang accepts -Werror=odr it doesn't do any cross-TU checks.

[Comment 8 Eli Schwartz 2024-12-27 00:32:06 UTC]

Did get an update from Oracle eventually. Looks like at least one error may be fixed.


https://bugs.java.com/bugdatabase/view_bug?bug_id=JDK-8340215
https://github.com/openjdk/jdk/pull/20742

[Comment 9 w.iron.zombie 2024-12-28 16:14:32 UTC]

(In reply to Eli Schwartz from comment #7)
> If you tried to build with clang then you didn't try to determine whether
> this bug still exists.
> 
> Clang doesn't check for ODR violations, you need GCC for that. Even though
> clang accepts -Werror=odr it doesn't do any cross-TU checks.

Oh, sorry! I use the gentoo llvm profile and assumed it did the same