Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 916718 - sci-mathematics/giac-1.9.0.67: build fails
Summary: sci-mathematics/giac-1.9.0.67: build fails
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Michael Orlitzky
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-11-02 13:34 UTC by Kai-Chun Ning
Modified: 2024-03-04 16:33 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,83.43 KB, text/x-log)
2023-11-02 13:34 UTC, Kai-Chun Ning
Details
emerge-info.txt (emerge-info.txt,3.84 KB, text/plain)
2023-11-06 11:18 UTC, Kai-Chun Ning
Details
Add fltk guards for USE=-gui (giac-1.9.0.93-xcas-out.patch,1.65 KB, patch)
2024-03-04 02:39 UTC, François Bissey
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kai-Chun Ning 2023-11-02 13:34:12 UTC
Created attachment 873914 [details]
build.log

build fails with sys-devel/gcc-13.2.1_p20231014::gentoo. Please find attached build.log, and please let me know if more info is needed.
Comment 1 Jonas Stein gentoo-dev 2023-11-05 21:25:08 UTC
yes, a paste of the emerge info would be great
as described on https://wiki.gentoo.org/wiki/Attach_the_logs_to_the_bug_ticket

Please reopen this ticket (Status:UNCONFIRMED) afterwards.
Comment 2 Kai-Chun Ning 2023-11-06 11:18:12 UTC
Created attachment 874150 [details]
emerge-info.txt
Comment 3 François Bissey 2023-11-09 00:33:41 UTC
Could you update the build.log when building with `MAKEOPTS=-j1`? That would clarify things. Although from what I think I can see, something that I thought was fixed in previous version seems to have made a come back.
Comment 4 François Bissey 2023-11-09 00:42:27 UTC
Yes, it is stuff for USE=-gui that is broken.
Comment 5 François Bissey 2023-11-09 00:46:13 UTC
icas.cc: In function ‘int main(int, char**)’:
icas.cc:2171:15: error: ‘fltk_view’ is not a member of ‘xcas’
 2171 |         xcas::fltk_view(0,ge,"session.xws",filename,5,contextptr);
      |               ^~~~~~~~~
icas.cc:2254:13: error: ‘icas_eval’ is not a member of ‘xcas’
 2254 |       xcas::icas_eval(gq,ge,reading_file,filename,contextptr);
      |             ^~~~~~~~~
icas.cc:2268:19: error: ‘fltk_view’ is not a member of ‘xcas’
 2268 |         if (xcas::fltk_view(gq,ge,"",filename,reading_file,contextptr))
      |                   ^~~~~~~~~
icas.cc:2165:15: warning: ignoring return value of ‘int system(const char*)’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
 2165 |         system("./xcas");
      |         ~~~~~~^~~~~~~~~~
make[2]: *** [Makefile:991: icas.o] Error 1
Comment 6 François Bissey 2023-11-09 01:18:39 UTC
And that particular code bit is not guarded so that it can be skipped with the right pre-processor flag :(
Looks like it is USE=gui until we patch it to do what we want.
Comment 7 François Bissey 2023-11-12 23:38:24 UTC
Upstream 1.9.0-69 still has the issue.
Comment 8 Larry the Git Cow gentoo-dev 2023-11-23 00:59:58 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5aab9211c41233733369fac444c9010507bbef97

commit 5aab9211c41233733369fac444c9010507bbef97
Author:     Michael Orlitzky <mjo@gentoo.org>
AuthorDate: 2023-11-23 00:54:24 +0000
Commit:     Michael Orlitzky <mjo@gentoo.org>
CommitDate: 2023-11-23 00:54:24 +0000

    profiles/base: force USE=gui for =sci-mathematics/giac-1.9.0.67
    
    Not a real fix but will avoid build failures on ~arch in the meantime.
    
    Bug: https://bugs.gentoo.org/916718
    Signed-off-by: Michael Orlitzky <mjo@gentoo.org>

 profiles/base/package.use.force | 7 +++++++
 1 file changed, 7 insertions(+)
Comment 9 Michael Orlitzky gentoo-dev 2023-11-23 01:02:59 UTC
Sorry for the delay, thinking about this package gives me heartburn.

I've forced USE=gui for now and won't add a newer release until it's fixed. Ironically, I use USE="-gui" myself, but enabled USE=gui for my pre-commit build test because I figured it was more likely to have issues.
Comment 10 François Bissey 2023-11-23 01:06:05 UTC
Well, maybe there is also the fact that like me, you have given up running the testsuite with "-gui". There is something fundamentally wrong when some command line test results (or possibly just their formatting) depends on whether or not the gui is built.
Comment 11 François Bissey 2024-03-04 02:38:30 UTC
I have a minimal patch against 1.9.0.93 (the latest version up) that seem to work. It is probably backward compatible but I just wanted to check against the latest. Attaching.
Comment 12 François Bissey 2024-03-04 02:39:19 UTC
Created attachment 886638 [details, diff]
Add fltk guards for USE=-gui
Comment 13 Larry the Git Cow gentoo-dev 2024-03-04 16:33:11 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7facf697ccbc2e3cec6664958d942ab10180d167

commit 7facf697ccbc2e3cec6664958d942ab10180d167
Author:     Michael Orlitzky <mjo@gentoo.org>
AuthorDate: 2024-03-04 16:29:15 +0000
Commit:     Michael Orlitzky <mjo@gentoo.org>
CommitDate: 2024-03-04 16:31:25 +0000

    sci-mathematics/giac: add 1.9.0.93, drop 1.9.0.67
    
    This fixes the build with USE="-gui" thanks to a patch by François
    Bissey.
    
    Closes: https://bugs.gentoo.org/916718
    Signed-off-by: Michael Orlitzky <mjo@gentoo.org>

 sci-mathematics/giac/Manifest                      |  2 +-
 .../files/giac-1.9.0.93-glibcxx-assertions.patch   | 31 +++++++++++
 .../files/giac-1.9.0.93-no-fltk-buildfix.patch     | 60 ++++++++++++++++++++++
 .../{giac-1.9.0.67.ebuild => giac-1.9.0.93.ebuild} |  7 ++-
 4 files changed, 95 insertions(+), 5 deletions(-)