Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 916556 - net-fs/samba,sys-auth/pam_smb: inline "samba" mirror
Summary: net-fs/samba,sys-auth/pam_smb: inline "samba" mirror
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo's SAMBA Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-10-31 00:19 UTC by Michael Orlitzky
Modified: 2023-11-24 21:24 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Orlitzky gentoo-dev 2023-10-31 00:19:33 UTC
The "samba" mirror list in profiles/thirdpartymirrors contains only one mirror, and it's the official upstream:

  $ grep samba profiles/thirdpartymirrors 
  samba		https://download.samba.org/pub/samba/

According to the devmanual, it would be a small improvement to inline that URL into the two packages that use it (net-fs/samba and sys-auth/pam_smb):

https://devmanual.gentoo.org/ebuild-writing/variables/index.html#third-party-mirrors

Afterwards, the "samba" mirror can be dropped from profiles/thirdpartymirrors, saving us the trouble of curating the list by hand in the future.
Comment 1 Ben Kohler gentoo-dev 2023-10-31 12:46:56 UTC
As a longtime thirtpartymirrors critic and member of samba team, I'm in favor.
Comment 2 Larry the Git Cow gentoo-dev 2023-11-24 21:24:19 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e763817993d6906568531df2b49eacc8e2aa7e7e

commit e763817993d6906568531df2b49eacc8e2aa7e7e
Author:     Michael Orlitzky <mjo@gentoo.org>
AuthorDate: 2023-11-23 00:30:53 +0000
Commit:     Michael Orlitzky <mjo@gentoo.org>
CommitDate: 2023-11-24 21:21:14 +0000

    profiles/thirdpartymirrors: drop mirror://samba/
    
    This (singleton) mirror list has been inlined into the two packages
    that were using it.
    
    Closes: https://bugs.gentoo.org/916556
    Signed-off-by: Michael Orlitzky <mjo@gentoo.org>

 profiles/thirdpartymirrors | 1 -
 1 file changed, 1 deletion(-)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d9ad839bb0438de870998ba1238226dbfcdd14da

commit d9ad839bb0438de870998ba1238226dbfcdd14da
Author:     Michael Orlitzky <mjo@gentoo.org>
AuthorDate: 2023-11-23 00:29:48 +0000
Commit:     Michael Orlitzky <mjo@gentoo.org>
CommitDate: 2023-11-24 21:21:13 +0000

    sys-auth/pam_smb: inline mirror://samba/ into SRC_URI
    
    Bug: https://bugs.gentoo.org/916556
    Signed-off-by: Michael Orlitzky <mjo@gentoo.org>

 sys-auth/pam_smb/pam_smb-2.0.0_rc6-r3.ebuild | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=02f7ac87a61d3313a768f8937a0cc609d1fb40c0

commit 02f7ac87a61d3313a768f8937a0cc609d1fb40c0
Author:     Michael Orlitzky <mjo@gentoo.org>
AuthorDate: 2023-11-23 00:28:26 +0000
Commit:     Michael Orlitzky <mjo@gentoo.org>
CommitDate: 2023-11-24 21:21:10 +0000

    net-fs/samba: inline mirror://samba/ into SRC_URI
    
    Bug: https://bugs.gentoo.org/916556
    Signed-off-by: Michael Orlitzky <mjo@gentoo.org>

 net-fs/samba/samba-4.18.4-r1.ebuild | 4 ++--
 net-fs/samba/samba-4.18.5-r1.ebuild | 4 ++--
 net-fs/samba/samba-4.18.6-r1.ebuild | 4 ++--
 net-fs/samba/samba-4.18.7.ebuild    | 4 ++--
 net-fs/samba/samba-4.18.8.ebuild    | 4 ++--
 net-fs/samba/samba-4.19.0-r1.ebuild | 4 ++--
 net-fs/samba/samba-4.19.1.ebuild    | 4 ++--
 net-fs/samba/samba-4.19.2.ebuild    | 4 ++--
 8 files changed, 16 insertions(+), 16 deletions(-)