Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 916447 - net-p2p/qbittorrent-4.6.0 doesn't have qtsql in deps for webui buld
Summary: net-p2p/qbittorrent-4.6.0 doesn't have qtsql in deps for webui buld
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: xbt573
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2023-10-28 19:02 UTC by tb3f3j+bbt5j2hcgjq7c
Modified: 2023-11-26 07:08 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Fix for incorrect changes made (diff.git,810 bytes, patch)
2023-11-12 22:40 UTC, Terry Wrist
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description tb3f3j+bbt5j2hcgjq7c 2023-10-28 19:02:39 UTC
from the src/src.pro file:
QT += network sql xml

All builds need qtnetwork qtsql and qtxml

But in the ebuild file this isn't so.
Comment 1 tb3f3j+bbt5j2hcgjq7c 2023-10-28 19:04:24 UTC
Use flags:

net-p2p/qbittorrent -gui -dbus webui

Doesn't actually link against qtsql but needed for configure so might be an upstream issue.
Comment 2 stefan11111 2023-11-06 22:19:36 UTC
(In reply to tb3f3j+bbt5j2hcgjq7c from comment #1)
> Use flags:
> 
> net-p2p/qbittorrent -gui -dbus webui
> 
> Doesn't actually link against qtsql but needed for configure so might be an
> upstream issue.

It does link against qtsql here:

stefan@GentooPC ~ $ ldd /usr/bin/qbittorrent-nox
        linux-vdso.so.1 (0x00007ffcb5bab000)
        libz.so.1 => /lib64/libz.so.1 (0x00007f45661da000)
        libtorrent-rasterbar.so.10 => /usr/lib64/libtorrent-rasterbar.so.10 (0x00007f4565dd3000)
        libcrypto.so.52 => /usr/lib64/libcrypto.so.52 (0x00007f4565b50000)
        libQt5Network.so.5 => /usr/lib64/libQt5Network.so.5 (0x00007f45659ce000)
        libQt5Sql.so.5 => /usr/lib64/libQt5Sql.so.5 (0x00007f456598d000)
        libQt5Xml.so.5 => /usr/lib64/libQt5Xml.so.5 (0x00007f4565944000)
        libQt5Core.so.5 => /usr/lib64/libQt5Core.so.5 (0x00007f4565337000)
        libstdc++.so.6 => /usr/lib/gcc/x86_64-pc-linux-gnu/13/libstdc++.so.6 (0x00007f45650a5000)
        libm.so.6 => /lib64/libm.so.6 (0x00007f4564fcb000)
        libgcc_s.so.1 => /usr/lib/gcc/x86_64-pc-linux-gnu/13/libgcc_s.so.1 (0x00007f4564fa2000)
        libc.so.6 => /lib64/libc.so.6 (0x00007f4564de4000)
        libssl.so.55 => /usr/lib64/libssl.so.55 (0x00007f4564d70000)
        /lib64/ld-linux-x86-64.so.2 (0x00007f4566b8b000)
        libdouble-conversion.so.3 => /usr/lib64/libdouble-conversion.so.3 (0x00007f4564d57000)
        libpcre2-16.so.0 => /usr/lib64/libpcre2-16.so.0 (0x00007f4564cbb000)
        libglib-2.0.so.0 => /usr/lib64/libglib-2.0.so.0 (0x00007f4564b2d000)
        libpcre2-8.so.0 => /lib64/libpcre2-8.so.0 (0x00007f4564a84000)
stefan@GentooPC ~ $ doas emerge -1av qbittorrent

These are the packages that would be merged, in order:

Calculating dependencies... done!
Dependency resolution took 1.79 s (backtrack: 0/20).

[ebuild   R    ] net-p2p/qbittorrent-4.6.0::gentoo  USE="webui -dbus -gui -qt6 -systemd -test" 0 KiB

Total: 1 package (1 reinstall), Size of downloads: 0 KiB

Would you like to merge these packages? [Yes/No] n

Quitting.

stefan@GentooPC ~ $ equery b libQt5Sql.so.5
 * Searching for libQt5Sql.so.5 ...
dev-qt/qtsql-5.15.11 (/usr/lib64/libQt5Sql.so.5 -> libQt5Sql.so.5.15.11)
Comment 3 Martin McFly 2023-11-11 19:38:19 UTC
Sorry, but I presume that the deps in the qbittorrent-4.6.0.ebuild:
 33     gui? (
 34         dev-libs/geoip
 35         !qt6? (
 36             dev-qt/qtgui:5
 37             dev-qt/qtsvg:5
 38             dev-qt/qtwidgets:5
 39             dev-qt/qtcore:5
 40             dev-qt/qtnetwork:5[ssl]
 41             dev-qt/qtsql:5[sqlite]
 42             dev-qt/qtxml:5
 43             dbus? ( dev-qt/qtdbus:5 )
 44         )
 45         qt6? (
 46             dev-qt/qtbase:6[dbus?,gui,widgets]
 47             dev-qt/qtsvg:6
 48             dev-qt/qtbase:6[network,ssl,sql,sqlite,xml(+)]
 49         )
 50     )"

mean that if you have these use flags:
       net-p2p/qbittorrent-4.6.0 -dbus -gui -qt6 systemd -test webui
then dev-qt/qtnetwork:5[ssl] dev-qt/qtsql dev-qt/qtxml won't get pulled in if you are on qt5? 

After doing a bit of a cleanup I managed to get a system where qtsql wasn't used and it isn't installed and depclean shows:

!!! existing preserved libs:
>>> package: dev-qt/qtsql-5.15.11
 *  - /usr/lib64/libQt5Sql.so.5
 *  - /usr/lib64/libQt5Sql.so.5.15.11
 *      used by /usr/bin/qbittorrent-nox (net-p2p/qbittorrent-4.6.0)
Comment 4 stefan11111 2023-11-12 13:30:51 UTC
(In reply to Martin McFly from comment #3)
USE="systemd dbus" don't seem to affect this.
After removing another qt app, I see that the same thing happens with qtnetwork too.

>>> These are the packages that would be unmerged:

 dev-qt/qtnetwork
    selected: 5.15.11
   protected: none
     omitted: none

 dev-qt/qtsql
    selected: 5.15.11
   protected: none
     omitted: none

All selected packages: =dev-qt/qtnetwork-5.15.11 =dev-qt/qtsql-5.15.11
Comment 5 Terry Wrist 2023-11-12 22:40:08 UTC
Created attachment 874615 [details, diff]
Fix for incorrect changes made

Reverting changes that did not work and are wrong given the current state of the upstream source and use flags.
Comment 6 Terry Wrist 2023-11-12 22:40:46 UTC
(In reply to stefan11111 from comment #4)

@stefan11111 is this a problem that you are having or what you expect to happen?
It is a bit unclear.

> (In reply to Martin McFly from comment #3)
> USE="systemd dbus" don't seem to affect this.
> After removing another qt app, I see that the same thing happens with
> qtnetwork too.
> 
> >>> These are the packages that would be unmerged:
> 
>  dev-qt/qtnetwork
>     selected: 5.15.11
>    protected: none
>      omitted: none
> 
>  dev-qt/qtsql
>     selected: 5.15.11
>    protected: none
>      omitted: none
> 
> All selected packages: =dev-qt/qtnetwork-5.15.11 =dev-qt/qtsql-5.15.11
Comment 7 stefan11111 2023-11-12 23:33:21 UTC
(In reply to Terry Wrist from comment #6)
> (In reply to stefan11111 from comment #4)
> 
> @stefan11111 is this a problem that you are having or what you expect to
> happen?
> It is a bit unclear.
> 

It is a problem I'm having.

Qbittorrent doesn't pull qtnetwork and qtsql as dependencies, but they are needed.
Qbittorrent doesn't build without them.
Comment 8 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-11-25 12:27:29 UTC
It would've been a lot easier if you just included the build.log of it failing.
Comment 9 Larry the Git Cow gentoo-dev 2023-11-26 07:08:15 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0abb5770f29ec29021747dbd2c161d8d50154d39

commit 0abb5770f29ec29021747dbd2c161d8d50154d39
Author:     Alexey Lunev <cheembox573@gmail.com>
AuthorDate: 2023-11-25 12:12:28 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2023-11-26 07:02:38 +0000

    net-p2p/qbittorrent: add 4.6.1
    
    Closes: https://bugs.gentoo.org/916447
    Signed-off-by: Alexey Lunev <cheembox573@gmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/33978
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 net-p2p/qbittorrent/Manifest                 |   1 +
 net-p2p/qbittorrent/qbittorrent-4.6.1.ebuild | 132 +++++++++++++++++++++++++++
 2 files changed, 133 insertions(+)