Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 916289 - media-gfx/gmic: last rites
Summary: media-gfx/gmic: last rites
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Deadline: 2023-11-26
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-10-26 00:54 UTC by Marek Szuba (RETIRED)
Modified: 2023-12-15 20:55 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Marek Szuba (RETIRED) archtester gentoo-dev 2023-10-26 00:54:23 UTC
Upstream uses a massive home-made Makefile which has since the beginning required massive amounts of patching to make it behave reasonably (as well as to fix the problems which ostensibly led upstream to abandoning CMake, only to re-introduce them in their NIH solution) and which if anything have only got worse
since then. One, optional, reverse dependency in the tree.
Removal on 2023-11-26.
Comment 1 Thomas Bettler 2023-10-27 06:47:38 UTC
Hi Marek

I just noticed you recently had some nasty experience with packaging and thus are considering dropping gmic entirely.

I understand it must have been a completely bad experience and baldly positive outlook.

Therefore I encouraged upstream to improve downstream packagers experience (CI tests, build system, etc.) 
see https://github.com/GreycLab/gmic/issues/17

A very first action from upstream might be to include your elaborated patches...

Let's see what happens... maybe life improves - but if not I also completely understand your decision drop maintaining gmic (y)
Comment 2 Marek Szuba (RETIRED) archtester gentoo-dev 2023-10-27 11:55:04 UTC
(In reply to Thomas Bettler from comment #1)

> Let's see what happens... maybe life improves - but if not I also completely
> understand your decision drop maintaining gmic (y)

Fingers crossed. Perhaps some might disagree but personally, I think media-gfx/gmic MUST have upstream's co-operation if it is to be kept.
Comment 3 N. Andrew Walsh 2023-10-30 14:27:58 UTC
I'd like to point out that flowblade (from what I can tell the only decent video editor for Linux) has gmic as a dependency. Flowblade isn't in the tree officially, but can be installed from github with some modifications to MLT's dependencies (see https://bugs.gentoo.org/592380).
Comment 4 Elliott Lester 2023-11-16 09:56:15 UTC
It looks like the upstream maintainer has moved the CMakelist.txt back to the root directory as of 
https://github.com/GreycLab/gmic/commit/ce6e427d93bb19beee8d6e3d5446ed04b48a103a
and released as 3.3.2

Does this resolve the Gentoo packaging issue?
Or is this still set to be masked?
Comment 5 Maciej S. Szmigiero 2023-11-26 11:05:36 UTC
It's a very useful package, it would be a shame if it wasn't in Gentoo anymore.
Comment 6 Larry the Git Cow gentoo-dev 2023-12-15 20:55:53 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2370ccc23b716093107815bd8fe67472a79e2210

commit 2370ccc23b716093107815bd8fe67472a79e2210
Author:     Arthur Zamarin <arthurzam@gentoo.org>
AuthorDate: 2023-12-15 20:51:43 +0000
Commit:     Arthur Zamarin <arthurzam@gentoo.org>
CommitDate: 2023-12-15 20:55:32 +0000

    media-gfx/gmic: treeclean
    
    Closes: https://bugs.gentoo.org/916289
    Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>

 media-gfx/gmic/Manifest                            |   2 -
 media-gfx/gmic/files/gmic-3.1.6-ar_so.patch        |  26 ----
 media-gfx/gmic/files/gmic-3.2.0-grep38.patch       |  27 ----
 .../gmic/files/gmic-3.2.4-makefile_automagic.patch | 131 -------------------
 .../gmic/files/gmic-3.2.5-relative_rpath.patch     |  22 ----
 .../files/gmic-3.2.6-makefile_target_deps.patch    |  11 --
 media-gfx/gmic/gmic-3.2.6.ebuild                   | 140 ---------------------
 media-gfx/gmic/gmic-3.3.1.ebuild                   | 140 ---------------------
 media-gfx/gmic/metadata.xml                        |  12 --
 profiles/package.mask                              |  10 --
 profiles/targets/desktop/package.use               |   4 -
 11 files changed, 525 deletions(-)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0daaeca9fb2d1450d6ad3ae593ea4365a18abefe

commit 0daaeca9fb2d1450d6ad3ae593ea4365a18abefe
Author:     Arthur Zamarin <arthurzam@gentoo.org>
AuthorDate: 2023-12-15 20:53:39 +0000
Commit:     Arthur Zamarin <arthurzam@gentoo.org>
CommitDate: 2023-12-15 20:55:32 +0000

    media-gfx/darktable: remove IUSE=gmic
    
    The package behind it, media-gfx/gmic, was masked and just
    tree-cleaned. The use flag was already masked before, so this is
    just a nop removal.
    
    Bug: https://bugs.gentoo.org/916289
    Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>

 media-gfx/darktable/darktable-4.2.1.ebuild | 5 ++---
 media-gfx/darktable/darktable-4.4.2.ebuild | 5 ++---
 media-gfx/darktable/metadata.xml           | 1 -
 profiles/base/package.use.mask             | 4 ----
 4 files changed, 4 insertions(+), 11 deletions(-)