Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 916122 - app-office/gnucash-5.4: please bump
Summary: app-office/gnucash-5.4: please bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Aaron W. Swenson
URL: https://github.com/Gnucash/gnucash/re...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-10-22 14:52 UTC by Karl-Johan Karlsson
Modified: 2023-12-13 13:43 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Karl-Johan Karlsson 2023-10-22 14:52:48 UTC
app-office/gnucash-5.4 was released on 24 September. 5.4 includes a fix ( https://github.com/Gnucash/gnucash/pull/1736 ) for a very annoying bug ( https://bugs.gnucash.org/show_bug.cgi?id=798990 ) in 5.3 (and apparently also 5.2, but that one was never added to Portage) that affects my workflow.

Please consider bumping to 5.4.

I am currently running 5.4 through a local ebuild which is a copy of the one for 5.3 but with a "-1" added to SRC_URI:

--- /var/db/repos/gentoo/app-office/gnucash/gnucash-5.3.ebuild  2023-09-23 23:40:53.000000000 +0200
+++ gnucash-5.4.ebuild  2023-10-22 16:28:04.431151543 +0200
@@ -11,7 +11,7 @@
 
 DESCRIPTION="A personal finance manager"
 HOMEPAGE="https://www.gnucash.org/"
-SRC_URI="https://github.com/Gnucash/gnucash/releases/download/${PV}/${P}.tar.bz2"
+SRC_URI="https://github.com/Gnucash/gnucash/releases/download/${PV}/${P}-1.tar.bz2"
 
 LICENSE="GPL-2+"
 SLOT="0"

This works for me, but I am only using a fraction of the available functionality, and none of the external integrations. I have also not looked at the gnucash-docs package.

Reproducible: Always
Comment 1 sphakka 2023-11-04 11:20:28 UTC
@Karl-Johan Karlsson, could you please check two important things that got screwed in v5.0-5.3?

1. Bug <https://bugs.gnucash.org/show_bug.cgi?id=798844> -- now solved (?)
2. Custom report menu empty in 5.3 -- no official bug report.

I'll do the same on my side.
Comment 2 Karl-Johan Karlsson 2023-11-04 13:13:48 UTC
(In reply to sphakka from comment #1)
> @Karl-Johan Karlsson, could you please check two important things that got
> screwed in v5.0-5.3?

I cannot. Neither is in functionality that I use, and neither contains sufficient information for me to generate test cases.
Comment 3 sphakka 2023-11-15 11:19:44 UTC
(In reply to sphakka from comment #1)

Did some tests.

> 1. Bug <https://bugs.gnucash.org/show_bug.cgi?id=798844> -- now solved (?)

I confirm that "assign as payment" (upstream #798844) works fine. 

> 2. Custom report menu empty in 5.3 -- no official bug report.

This is still broken in GC-5.4. Details: I have a bunch of custom reports installed and made available via a new menu item "Reports > Custom", which is correctly created but is empty. As a workaround, custom reports can be added to an already existing menu item, like "Reports > Examples". I'll file a bug upstream.

Otherwise, the new build GC-5.4 looks OK :-)
Comment 4 Aaron W. Swenson gentoo-dev 2023-11-26 15:52:32 UTC
I haven't bumped because upstream has shipped yet another broken test. Are there any opinions on restricting tests for this ebuild?

Fixing the tests require extra effort, and upstream is generally not receptive to bugs originating from Gentoo. So, no one but us benefits from tests that work properly.
Comment 5 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-11-26 16:10:44 UTC
(In reply to Aaron W. Swenson from comment #4)
> I haven't bumped because upstream has shipped yet another broken test. Are
> there any opinions on restricting tests for this ebuild?
> 
> Fixing the tests require extra effort, and upstream is generally not
> receptive to bugs originating from Gentoo. So, no one but us benefits from
> tests that work properly.

You should look into the cause and see if you can reproduce the test failure manually:
* If not, why not? Find out what's specific about the ebuild environment.
* If you can, report it upstream, as it's clearly not Gentoo specific.

You can also skip individual tests if you've analysed what it does and determined it's not a (serious) regression.

You should not restrict tests simply because there's a failure.
Comment 6 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-11-26 16:12:02 UTC
(In reply to Aaron W. Swenson from comment #4)
> [...]
> Fixing the tests require extra effort, and upstream is generally not
> receptive to bugs originating from Gentoo. 

also...

FWIW, this isn't my (limited) experience. They've taken patches and such for new compilers like GCC 14 and they also took patches in the past for test failures from contributors.
Comment 7 Larry the Git Cow gentoo-dev 2023-12-13 13:43:16 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=28489b1a00ab51a5162fdbfe736050fd0a31517b

commit 28489b1a00ab51a5162fdbfe736050fd0a31517b
Author:     Aaron W. Swenson <titanofold@gentoo.org>
AuthorDate: 2023-12-13 13:40:07 +0000
Commit:     Aaron W. Swenson <titanofold@gentoo.org>
CommitDate: 2023-12-13 13:42:21 +0000

    app-office/gnucash: Add 5.4
    
    Temporarily restrict tests until we can get it working reliably with an
    installation in place.
    
    Closes: https://bugs.gentoo.org/916122
    Signed-off-by: Aaron W. Swenson <titanofold@gentoo.org>

 app-office/gnucash/Manifest           |   1 +
 app-office/gnucash/gnucash-5.4.ebuild | 226 ++++++++++++++++++++++++++++++++++
 2 files changed, 227 insertions(+)