Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 916025 - net-libs/libnet-1.3 unconditionally depends on app-doc/doxygen, etc.
Summary: net-libs/libnet-1.3 unconditionally depends on app-doc/doxygen, etc.
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Netmon project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-10-19 21:36 UTC by Thomas Arnett
Modified: 2023-11-25 13:02 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch to make doxygen optional (libnet-doxygen.patch,867 bytes, patch)
2023-10-19 21:36 UTC, Thomas Arnett
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Arnett 2023-10-19 21:36:15 UTC
Created attachment 873166 [details, diff]
Patch to make doxygen optional

The recently added net-libs/libnet-1.3 ebuild unconditionally pulls in app-doc/doxygen, which in turn pulls in app-text/ghostscript-gpl and several image libraries. The attached patch makes it conditional on USE="doc".
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-10-19 21:38:34 UTC
We have a policy of unconditionally installing man pages, per https://projects.gentoo.org/qa/policy-guide/installed-files.html#pg0305.

You'll need upstream to either provide the man pages in a dist tarball (they already create a dist tarball, just don't seem to include the man pages) or to convince the maintainer of the package in Gentoo to pre-generate them on every bump.
Comment 2 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-10-19 21:40:18 UTC
It might actually be enough to just add --enable-doxygen-man to https://github.com/libnet/libnet/blob/master/.github/workflows/release.yml#L22. Not tried.
Comment 3 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-10-19 21:50:27 UTC
Filed https://github.com/libnet/libnet/issues/169.
Comment 4 Thomas Arnett 2023-11-01 21:23:24 UTC
Did you have somebody else in mind as the maintainer? The netmon project page lists you as one of the members, and Git says you authored and signed off on the 1.3 ebuild. Does it need to be discussed among the project members?
Comment 5 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-11-02 14:38:51 UTC
(In reply to Thomas Arnett from comment #4)
> Did you have somebody else in mind as the maintainer? The netmon project
> page lists you as one of the members, and Git says you authored and signed
> off on the 1.3 ebuild. Does it need to be discussed among the project
> members?

I'm not sure what you mean. "Upstream" which I referred to in Comment 2 refers to the creators of libnet who create the software.

You can see the discussion in the bug I linked.
Comment 6 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-11-02 14:39:14 UTC
(In reply to Thomas Arnett from comment #4)
> Did you have somebody else in mind as the maintainer? The netmon project
> page lists you as one of the members, and Git says you authored and signed
> off on the 1.3 ebuild. Does it need to be discussed among the project
> members?

Oh, right, you mean as for the labour of creating it on every single bump. Yes, it's a pain, and I'd rather fix it properly upstream.
Comment 7 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-11-02 14:40:38 UTC
(The general issue is that it tends to mean nobody else wants to touch the package because it requires a manual procedure/using someone else's scripts/etc.)
Comment 8 Thomas Arnett 2023-11-15 00:56:52 UTC
I understand that it's a pain and agree it would be better for everybody if it were fixed upstream. Unfortunately, it seems like that isn't straightforward. In the meantime, it creates a burden for any user who installs packages like Git, tcptraceroute, or many Perl modules, which is at least discouraged by the same policy.

Is there a procedure for policy exceptions? The rationale for the policy says that not installing "basic documentation" harms users, but libnet seems to function only as a dependency, and its documentation appears to be for development and packaging (which Gentoo has, at least in the past, distinguished from general use).
Comment 9 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-11-25 12:11:23 UTC
Let me see what I can do. I can't do the build system work upstream right now but I'll pipe it up with some of my scripts for generating the docs for now.
Comment 10 Larry the Git Cow gentoo-dev 2023-11-25 12:15:09 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3bd92bbf3356a4cba7c86dfbf7e31a6a0c0591a9

commit 3bd92bbf3356a4cba7c86dfbf7e31a6a0c0591a9
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2023-11-25 12:13:26 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-11-25 12:14:00 +0000

    net-libs/libnet: include pre-generated man pages
    
    Avoid a fairly heavy dep on doxygen given some common sysadmin etc tools
    depend on this.
    
    Ultimately need to fix the upstream build logic but not got time to do it
    right now.
    
    Bug: https://github.com/libnet/libnet/issues/169
    Closes: https://bugs.gentoo.org/916025
    Signed-off-by: Sam James <sam@gentoo.org>

 net-libs/libnet/Manifest             |  1 +
 net-libs/libnet/libnet-1.3-r1.ebuild | 61 ++++++++++++++++++++++++++++++++++++
 2 files changed, 62 insertions(+)