Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 915969 - dev-util/hip-5.7.0-r1 crashes randomly due to unalignes writes if AVX-512 instructions are enabled
Summary: dev-util/hip-5.7.0-r1 crashes randomly due to unalignes writes if AVX-512 ins...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: AMD64 Linux
: Normal normal (vote)
Assignee: Gentoo Science Related Packages
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2023-10-18 18:31 UTC by Sv. Lockal
Modified: 2023-12-13 06:28 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sv. Lockal 2023-10-18 18:31:55 UTC
As I have -march=native in my make.conf, it enables a SIMD block of code, which was not tested by original developers.

Due to unaligned allocations, library crashes in nontemporalMemcpy in _mm512_stream_si512 (requires 64-aligned allocations) in github.com/ROCm-Developer-Tools/clr/blob/5914ac3c6e9b3848023a7fa25e19e560b1c38541/rocclr/device/rocm/rocvirtual.cpp#L2793

Patch to upstream and 5.7.0 will follow.
Comment 1 Larry the Git Cow gentoo-dev 2023-11-19 02:18:37 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=74964e47d7cb86d9cbb992f02e9de25a554727ac

commit 74964e47d7cb86d9cbb992f02e9de25a554727ac
Author:     Sv. Lockal <lockalsash@gmail.com>
AuthorDate: 2023-10-18 18:34:10 +0000
Commit:     Benda Xu <heroxbd@gentoo.org>
CommitDate: 2023-11-19 02:18:21 +0000

    dev-util/hip: fix crashes and QA issues.
    
    - add fix-unaligned-memcpy.patch
    - add exec-stack.patch
    - add disable-stack-protector patch
    - drop asan doc from the build system.
    
    Closes: https://bugs.gentoo.org/915969
    Bug: https://github.com/ROCm-Developer-Tools/clr/issues/18
    Bug: https://github.com/gentoo/gentoo/pull/33400
    Bug: https://github.com/ROCm-Developer-Tools/clr/issues/22
    Bug: https://github.com/ROCm-Developer-Tools/clr/issues/21
    Bug: https://github.com/RadeonOpenCompute/ROCm-CompilerSupport/issues/61
    Signed-off-by: Sv. Lockal <lockalsash@gmail.com>
    Signed-off-by: Benda Xu <heroxbd@gentoo.org>

 .../files/hip-5.7.1-disable-stack-protector.patch  | 13 +++++
 dev-util/hip/files/hip-5.7.1-exec-stack.patch      | 31 ++++++++++
 .../hip/files/hip-5.7.1-fix-unaligned-access.patch | 67 ++++++++++++++++++++++
 dev-util/hip/files/hip-5.7.1-no_asan_doc.patch     | 17 ++++++
 dev-util/hip/hip-5.7.1.ebuild                      |  9 ++-
 5 files changed, 134 insertions(+), 3 deletions(-)
Comment 2 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-11-19 09:19:24 UTC
This needed a new revision as it changed installed code?
Comment 3 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-11-19 11:34:42 UTC
(In reply to Sam James from comment #2)
> This needed a new revision as it changed installed code?

commit 6939c8b154a1312c2b6c3ef71ebbe39c2d76b208
Author: Patrick Lauer <patrick@gentoo.org>
Date:   Sun Nov 19 06:24:59 2023 +0000

    dev-util/hip: Force rebuild through revbump

    Changes in last few commits are otherwise invisible

    Signed-off-by: Patrick Lauer <patrick@gentoo.org>

commit d555a7a2046ef59a01ae06c8047a113fff5de936
Author: Patrick Lauer <patrick@gentoo.org>
Date:   Sun Nov 19 06:26:36 2023 +0000

    dev-util/hipcc: Force rebuild with revbump

    Signed-off-by: Patrick Lauer <patrick@gentoo.org>