app-admin/conky-1.19.6[extras] provides configs for nano and vim, and also pulls both of them as dependencies. I think it should not do that. Configs are basically a couple of text files, and pulling in whole vim/gvim when user only needs a config for nano (or other way around) is excessive. Reproducible: Always Steps to Reproduce: 1. USE="extras" emerge -1 app-admin/conky Actual Results: conky pulls nano and vim, if they aren't already installed. Expected Results: conky should not pull nano and vim
Was expecting this bug to pop up at some point. I don't know how other packaged deal with this. Maybe just mentioning them as optional dependencies!?
When package uses other package for some optional feature, "optfeature" is usually used lately. But here situation is other way around. Maybe "optfeature" could still be used. Or "einfo" with message about configs for nano and vim/gvim. Maybe even no message at all? It already says everything in description of "extras" USE-flag.
Just install them unconditionally in this case (https://projects.gentoo.org/qa/policy-guide/installed-files.html#pg0301). I don't even see the need for optfeature here.
The files are already installed if "extras" USE-flag is enabled. Problem is in dependencies on nano and vim/gvim, which this USE-flag also pulls in.
I know, I just meant "solely".
To me this USE-flag still seems useful while it pulls a few additional dependencies (dev-python/pyyaml and dev-python/jinja) to actually generate those config files.
Okay I agree that the use flag still makes sense. So what about just removing the dependencies on nano and vim?
I think that would be best fix.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f9f80adc828e4b93f97597fe99566affad7e0a07 commit f9f80adc828e4b93f97597fe99566affad7e0a07 Author: Daniel Pielmeier <billie@gentoo.org> AuthorDate: 2023-11-15 16:03:21 +0000 Commit: Daniel Pielmeier <billie@gentoo.org> CommitDate: 2023-11-15 16:03:21 +0000 app-admin/conky: Remove vim and nano dependencies Signed-off-by: Daniel Pielmeier <billie@gentoo.org> Closes: https://bugs.gentoo.org/915964 app-admin/conky/{conky-1.19.6.ebuild => conky-1.19.6-r1.ebuild} | 0 1 file changed, 0 insertions(+), 0 deletions(-)
I believe it is still not fixed: https://github.com/gentoo/gentoo/blob/afa9c354085529b2b8f88418645a3b34fe5f4bcc/app-admin/conky/conky-1.19.6-r1.ebuild#L68-L74
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1913fc778338b4a0377ee22ba7fc439b39c0ce66 commit 1913fc778338b4a0377ee22ba7fc439b39c0ce66 Author: Daniel Pielmeier <billie@gentoo.org> AuthorDate: 2023-11-15 19:38:46 +0000 Commit: Daniel Pielmeier <billie@gentoo.org> CommitDate: 2023-11-15 19:41:42 +0000 app-admin/conky: Really fix 915964 Signed-off-by: Daniel Pielmeier <billie@gentoo.org> Bug: https://bugs.gentoo.org/915964 .../conky/{conky-1.19.6-r1.ebuild => conky-1.19.6-r2.ebuild} | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-)
Thanks!
