Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 915906 - net-p2p/amule-2.3.3-r1[X] - migrate from wxGTK:3.0 to wxGTK:3.2
Summary: net-p2p/amule-2.3.3-r1[X] - migrate from wxGTK:3.0 to wxGTK:3.2
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Alexander Tsoy
URL: https://github.com/amule-project/amul...
Whiteboard:
Keywords: PATCH, PullRequest
Depends on:
Blocks:
 
Reported: 2023-10-17 21:57 UTC by ernsteiswuerfel
Modified: 2023-12-22 10:54 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Debian wxGTK-3.2 patch (amule-2.3.3-wx3.2.patch,17.10 KB, patch)
2023-10-17 21:57 UTC, ernsteiswuerfel
Details | Diff
amule-2.3.3-r2.ebuild (amule-2.3.3-r2.ebuild,3.24 KB, text/plain)
2023-10-17 21:58 UTC, ernsteiswuerfel
Details
build.log (amule-2.3.3-r2:20231017-005127.log,295.09 KB, text/plain)
2023-10-17 21:59 UTC, ernsteiswuerfel
Details
emerge --info (file_915906.txt,7.77 KB, text/plain)
2023-10-17 21:59 UTC, ernsteiswuerfel
Details

Note You need to log in before you can comment on or make changes to this bug.
Description ernsteiswuerfel archtester 2023-10-17 21:57:42 UTC
Created attachment 873061 [details, diff]
Debian wxGTK-3.2 patch

Currently amule-2.3.3-r1 depends on wxGTK:3.0 when built with USE=X.

Unfortunately throws up a lot of problems on recent toolchains, see bug #910441, #898592, #889652, #876613, #693134, #910441.

I did some research yesterday and found out there is already an upstream issue about wxGTK-3.2.x support (https://github.com/amule-project/amule/issues/340) and luckily also an already working Debian patch (https://salsa.debian.org/debian/amule/-/blob/master/debian/patches/wx3.2.patch).

Even more luckily the Debian patch cleanly applies on Gentoos' amule-2.3.3.

So I hacked down a new -r2 ebuild to incorporate the Debian patch and use wxGTK:3.2 includes instead of the wxGTK:3.0.

Surprisingly this instantly worked and amule 2.3.3-r2 is running fine on my box since yesterday on wxGTK:3.2. Looks about the same as the wxGTK:3.0 version but the blurry fonts are gone - fonts under wxGTK:3.2 look crisp. :)
Comment 1 ernsteiswuerfel archtester 2023-10-17 21:58:27 UTC
Created attachment 873062 [details]
amule-2.3.3-r2.ebuild
Comment 2 ernsteiswuerfel archtester 2023-10-17 21:59:02 UTC
Created attachment 873063 [details]
build.log
Comment 3 ernsteiswuerfel archtester 2023-10-17 21:59:51 UTC
Created attachment 873064 [details]
emerge --info
Comment 4 Joonas Niilola gentoo-dev 2023-10-22 14:55:34 UTC
It would be great if you provided a git am'able patch to incorporate these changes that we can just merge!
Comment 5 ernsteiswuerfel archtester 2023-10-23 15:25:06 UTC
A patch for current stable 2.3.3 or 2.3.3-r1? So no new -r2 for the wxGTK:3.0 to wxGTK:3.2 bump?
Comment 6 Alexander Tsoy 2023-11-03 07:31:18 UTC
(In reply to ernsteiswuerfel from comment #5)
> A patch for current stable 2.3.3 or 2.3.3-r1? So no new -r2 for the
> wxGTK:3.0 to wxGTK:3.2 bump?
It's better to do a revbump. This shouldn't be a problem with git-format-patch.
Comment 7 Larry the Git Cow gentoo-dev 2023-12-22 06:46:35 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a4a6f67841aa6aedf6cc17509c208783591f3731

commit a4a6f67841aa6aedf6cc17509c208783591f3731
Author:     Alexander Tsoy <alexander@tsoy.me>
AuthorDate: 2023-12-18 02:36:00 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-12-22 06:43:44 +0000

    net-p2p/amule: port to wxGTK 3.2
    
    Apply Debian patch with fixes for wxWidgets 3.2 compatibility
    
    Thanks-to: ernsteiswuerfel <erhard_f@mailbox.org>
    Closes: https://bugs.gentoo.org/915906
    Signed-off-by: Alexander Tsoy <alexander@tsoy.me>
    Signed-off-by: Sam James <sam@gentoo.org>

 net-p2p/amule/amule-2.3.3-r3.ebuild         | 160 ++++++++++
 net-p2p/amule/amule-9999.ebuild             |  11 +-
 net-p2p/amule/files/amule-2.3.3-wx3.2.patch | 461 ++++++++++++++++++++++++++++
 3 files changed, 627 insertions(+), 5 deletions(-)
Comment 8 ernsteiswuerfel archtester 2023-12-22 10:28:19 UTC
(In reply to Alexander Tsoy from comment #6)
> (In reply to ernsteiswuerfel from comment #5)
> > A patch for current stable 2.3.3 or 2.3.3-r1? So no new -r2 for the
> > wxGTK:3.0 to wxGTK:3.2 bump?
> It's better to do a revbump. This shouldn't be a problem with
> git-format-patch.
Thanks for pushing this! I had only little time the last few weeks, sorry.