Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 915380 - [app-editors/vscode] should not hard requreies ibus
Summary: [app-editors/vscode] should not hard requreies ibus
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Adel KARA SLIMANE
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2023-10-08 13:44 UTC by microcai
Modified: 2023-10-21 16:10 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description microcai 2023-10-08 13:44:29 UTC
ibus is listed in RDEPEND, but vscode really can run with fcitx. ibus is not a hard requirement.
Comment 2 Naohiro Aota gentoo-dev 2023-10-16 01:56:25 UTC
From point of cjk team, I suggest removing this ibus dependency.

For additional evidence, the ibus dependency for the snap package is added by this commit:

https://github.com/microsoft/vscode/commit/b2a1932329332814312f9f1623fa34ceb53da48d

The line below in the modified file, suggests vscode at least supports both ibus and fcitx.

https://github.com/microsoft/vscode/blob/main/resources/linux/snap/electron-launch#L248

Also, that dependency is imposed by arbitalily setting GTK_IM_MODULE_FILE in "resources/linux/snap/electron-launch", which should be a file for executing vscode within a snap environment. So, that is a dependency for the snap package, but, I believe, is not a dependency for vscode itself.
Comment 3 Adel KARA SLIMANE 2023-10-16 02:26:51 UTC
Thanks @naota for chiming in. So you suggest removing the explicit on `ibus` and `fcitx5` altogether ?
Comment 4 Larry the Git Cow gentoo-dev 2023-10-21 16:10:24 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6ec9baca784bfe1978dc249feeac4fe0e43a055c

commit 6ec9baca784bfe1978dc249feeac4fe0e43a055c
Author:     Adel KARA SLIMANE <adel.ks@zegrapher.com>
AuthorDate: 2023-10-12 20:17:50 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2023-10-21 16:03:55 +0000

    app-editors/vscode: drop 1.83.0 & update dependencies
    
    Closes: https://bugs.gentoo.org/915380
    
    Signed-off-by: Adel KARA SLIMANE <adel.ks@zegrapher.com>
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 app-editors/vscode/Manifest                        |   3 -
 ...de-1.83.0-r1.ebuild => vscode-1.82.3-r1.ebuild} |   2 +-
 app-editors/vscode/vscode-1.82.3.ebuild            | 112 ---------------------
 ...scode-1.83.1.ebuild => vscode-1.83.1-r1.ebuild} |   2 +-
 4 files changed, 2 insertions(+), 117 deletions(-)