Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 915347 - media-video/obs-studio: please allow enabling RIST/SRT support
Summary: media-video/obs-studio: please allow enabling RIST/SRT support
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Chiitoo
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-10-07 21:46 UTC by Mart Raudsepp
Modified: 2023-10-21 21:59 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mart Raudsepp gentoo-dev 2023-10-07 21:46:26 UTC
Currently our OBS build doesn't support streaming over SRT or RIST protocol due to -DENABLE_NEW_MPEGTS_OUTPUT=OFF.

Please allow enabling that in some way.
Personally I would add IUSE="rist srt" and in either case pull in the srt and rist libraries - or work upstream to make them separately linkable.

As I needed SRT/RIST streaming from OBS myself and I'm slightly involved with librist at a professional level, I've packaged net-libs/librist to allow this to happen easier. net-libs/srt is already there.
Streaming over SRT works for me after a hacky ENABLE_NEW_MPEGTS_OUTPUT toggling to ON.
Comment 1 Chiitoo gentoo-dev 2023-10-09 19:45:05 UTC
Will do.

Thank you for the report!
Comment 2 Larry the Git Cow gentoo-dev 2023-10-21 19:18:36 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8e2f1b97ced74c2d2fae3e5421336dcded041301

commit 8e2f1b97ced74c2d2fae3e5421336dcded041301
Author:     Jimi Huotari <chiitoo@gentoo.org>
AuthorDate: 2023-10-21 17:14:46 +0000
Commit:     Jimi Huotari <chiitoo@gentoo.org>
CommitDate: 2023-10-21 19:17:20 +0000

    media-video/obs-studio: add mpegts and rnnoise features
    
    This allows for toggling the NEW_MPEGTS/native SRT/RIST
    mpegts output feature, and adds 'media-libs/rnnoise'
    as a dependency.
    
    This also cleans up some submodule references that are
    no longer being used, and updates the existing ones in
    9999.
    
    Closes: https://bugs.gentoo.org/915179
    Closes: https://bugs.gentoo.org/915347
    Signed-off-by: Jimi Huotari <chiitoo@gentoo.org>

 media-video/obs-studio/metadata.xml                |   1 +
 media-video/obs-studio/obs-studio-29.1.3-r2.ebuild | 273 +++++++++++++++++++++
 media-video/obs-studio/obs-studio-9999.ebuild      |  24 +-
 3 files changed, 285 insertions(+), 13 deletions(-)
Comment 3 Mart Raudsepp gentoo-dev 2023-10-21 20:51:23 UTC
Your unmasking on arm64 doesn't work, it just masks it for all arches in base/package.use.mask and then for arm64 too.
I think you need
media-video/obs-studio -mpegts
instead in profiles/arch/arm64/package.use.mask

I also think it'd make sense to request keywording on at least amd64 and then maybe convert it from a base mask to only masking on where we don't want this (x86 and/or ppc64)
Comment 4 Chiitoo gentoo-dev 2023-10-21 21:55:09 UTC
(In reply to Mart Raudsepp from comment #3)
> Your unmasking on arm64 doesn't work, it just masks it for all arches in
> base/package.use.mask and then for arm64 too.
> I think you need
> media-video/obs-studio -mpegts
> instead in profiles/arch/arm64/package.use.mask

Whooops, not sure how that happened.  Pretty sure I put the '-' there at least at some point...

Will fix, thank you!

> I also think it'd make sense to request keywording on at least amd64 and
> then maybe convert it from a base mask to only masking on where we don't
> want this (x86 and/or ppc64)

Yeah, agreed.  I felt I would not get into the keywording request tonight, especially since I couldn't get to really testing outside of building it right now, so I figured I'd get it out there like this for now.

That is definitely the way to go though.

Thanks again!
Comment 5 Larry the Git Cow gentoo-dev 2023-10-21 21:59:55 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7a5181598a6ad0a03add0f20a8a8d6372af05ca0

commit 7a5181598a6ad0a03add0f20a8a8d6372af05ca0
Author:     Jimi Huotari <chiitoo@gentoo.org>
AuthorDate: 2023-10-21 21:52:52 +0000
Commit:     Jimi Huotari <chiitoo@gentoo.org>
CommitDate: 2023-10-21 21:59:49 +0000

    profiles/arch/arm64: fix unmasking USE="mpegts"
    
    Bug: https://bugs.gentoo.org/915347
    Signed-off-by: Jimi Huotari <chiitoo@gentoo.org>

 profiles/arch/arm64/package.use.mask | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)