Created attachment 872251 [details] error part of the build log When emerging www-client/seamonkey-2.53.17 in pentium-M chroot envioronment on amd64, the build fails with a error message below. 2:58.60 In file included from /var/tmp/portage/www-client/seamonkey-2.53.17/work/seamonkey-2.53.17/modules/fdlibm/src/e_acos.cpp:44: 2:58.60 /var/tmp/portage/www-client/seamonkey-2.53.17/work/seamonkey-2.53.17/modules/fdlibm/src/math_private.h:34:21: error: conflicting declaration typedef __double_t double_t 2:58.60 34 | typedef __double_t double_t; ... 2:58.61 /usr/include/math.h:170:21: note: previous declaration as typedef long double double_t 2:58.61 170 | typedef long double double_t; I guess this is a revival of #816975 at www-client/firefox. https://bugs.gentoo.org/show_bug.cgi?id=816975 So I made a patch attached here as "math_private.patch" suggested in #816975. Then I built seamonkey-2.53.17 and 2.53.17.1 to be completed. (Now, I'm writing this report in seamonkey-2.53.17.1 on pentium-M PC.) I guess there is a same hurdle in the 2.53.17.1 version.
Created attachment 872252 [details] emerge --info in pentium-M chroot envioronment on amd64
Created attachment 872253 [details, diff] math_private.patch
Thanks for catching this. Seems like FF upstream never implemented this patch (even in current version). I'll see if I can get SM upstream to include it, than we'll have it in the next version.
Created attachment 872355 [details, diff] Alternative patch based on Mozilla upstream bug @abo junghichi, I've made a patch based on the Mozilla upstream bug, could you give this a try to build and see if that works as well. As far as I can judge your patch would work fine for Gentoo/Linux, but might not work on Freebsd. If I send things upstream I'd rather have something that works in more cases.
(In reply to Myckel Habets from comment #4) > Created attachment 872355 [details, diff] [details, diff] > Alternative patch based on Mozilla upstream bug Now, I have successfully rebuilt seamonkey-2.53.17.1 with your patch in the chroot enviornment, and this comment is written with this seamonkey binary on the x86 PC.
(In reply to abo junghichi from comment #5) > (In reply to Myckel Habets from comment #4) > > Created attachment 872355 [details, diff] [details, diff] [details, diff] > > Alternative patch based on Mozilla upstream bug > Now, I have successfully rebuilt seamonkey-2.53.17.1 with your patch in the > chroot enviornment, and this comment is written with this seamonkey binary > on the x86 PC. Thank you, will send it upstream.
It seems upstream doesn't plan to include this, because firefox didn't include it as well (I guess they updated the 3rd party library, which hasn't this problem any more). My plan is to include this patch in the 2.53.17.1-r1 ebuild that I will work on this week and make it only applied on the x86 arch. That way x86 can have the 2.53.17.1 release as well.
Created attachment 875261 [details] New ebuild Could you test this ebuild, please? It should include the patch on the x86 architecture (check for it when the patches are applied, should be the last patch that is applied).
Sorry to reply late, my internet connection is thin for updating the system including the x86 PC. With "eapply -pDEPTH" tailered for the patch, the ebuild file you mentioned at comment 8 has built seamonkey to write this comment. Thank you. --- seamonkey-2.53.17.1-r1.ebuild 2023-11-26 23:31:25.403094556 +0900 +++ /var/db/pkg/www-client/seamonkey-2.53.17.1-r1/seamonkey-2.53.17.1-r1.ebuild 2023-11-26 22:08:24.000000000 +0900 @@ -227,7 +227,7 @@ # Fix for building on x86 https://bugs.gentoo.org/915336 (x86-only) if use x86 ; then - eapply -p2 "${PATCH_S}/USE_flag/2021_seamonkey_2.53.17-floating-point_normalization_on_x86_build_fix.patch" + eapply -p1 "${PATCH_S}/USE_flag/2021_seamonkey_2.53.17-floating-point_normalization_on_x86_build_fix.patch" fi # Allow user to apply any additional patches without modifing ebuild
I had covid last week, so was unable to do much. I just send the PR and the new ebuild to the Gentoo github.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e3feee742dcf7dce5693f13bf42cdcd7c21c7ef1 commit e3feee742dcf7dce5693f13bf42cdcd7c21c7ef1 Author: Myckel Habets <gentoo-bugs@habets-dobben.nl> AuthorDate: 2023-11-28 08:20:53 +0000 Commit: Joonas Niilola <juippis@gentoo.org> CommitDate: 2023-11-29 06:40:21 +0000 www-client/seamonkey: 2.53.17.1-r1: x86 build fix and ffmpeg-6 support This fixes the build on x86 for 2.53.17.1 with an x86 specific patch. Support for >=media-video/ffmpeg-6 is included. Closes: https://bugs.gentoo.org/915336 Closes: https://bugs.gentoo.org/917593 Signed-off-by: Myckel Habets <gentoo-bugs@habets-dobben.nl> Signed-off-by: Joonas Niilola <juippis@gentoo.org> www-client/seamonkey/Manifest | 1 + www-client/seamonkey/seamonkey-2.53.17.1-r1.ebuild | 575 +++++++++++++++++++++ 2 files changed, 576 insertions(+)
