Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 915306 - www-client/firefox: fails to build with Rust 1.73
Summary: www-client/firefox: fails to build with Rust 1.73
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Mozilla Gentoo Team
URL:
Whiteboard:
Keywords: PATCH
: 915593 (view as bug list)
Depends on:
Blocks:
 
Reported: 2023-10-06 14:03 UTC by Sam James
Modified: 2023-11-18 07:00 UTC (History)
6 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log.xz (build.log.xz,56.60 KB, application/x-xz)
2023-10-06 14:04 UTC, Sam James
Details
0001-Bug-1849874-Update-from-packed_simd_2-to-packed_simd.patch (0001-Bug-1849874-Update-from-packed_simd_2-to-packed_simd.patch,196.66 KB, patch)
2023-10-06 14:05 UTC, Sam James
Details | Diff
0002-Bug-1851530-Use-plain-packed_simd.-r-hsivonen-supply.patch (0002-Bug-1851530-Use-plain-packed_simd.-r-hsivonen-supply.patch,75.33 KB, text/plain)
2023-10-06 14:05 UTC, Sam James
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-10-06 14:03:48 UTC
There's a Rust 1.73.0 PR pending at https://github.com/gentoo/gentoo/pull/33211, so testing with that + modifying the ebuild's LLVM_MAX_SLOT + deps to use LLVM 17, I get:

 0:49.50 error: unrecognized platform-specific intrinsic function: `simd_shuffle2`
 0:49.50   --> /var/tmp/portage/www-client/firefox-118.0.1/work/firefox-118.0.1/third_party/rust/packed_simd_2/src/codegen/llvm.rs:10:5
 0:49.50    |
 0:49.50 10 |     pub fn simd_shuffle2<T, U>(x: T, y: T, idx: [u32; 2]) -> U;
 0:49.50    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 0:49.50 error: unrecognized platform-specific intrinsic function: `simd_shuffle4`
 0:49.50   --> /var/tmp/portage/www-client/firefox-118.0.1/work/firefox-118.0.1/third_party/rust/packed_simd_2/src/codegen/llvm.rs:11:5
 0:49.50    |
 0:49.50 11 |     pub fn simd_shuffle4<T, U>(x: T, y: T, idx: [u32; 4]) -> U;
 0:49.50    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 0:49.50 error: unrecognized platform-specific intrinsic function: `simd_shuffle8`
 0:49.50   --> /var/tmp/portage/www-client/firefox-118.0.1/work/firefox-118.0.1/third_party/rust/packed_simd_2/src/codegen/llvm.rs:12:5
 0:49.50    |
[...]

---

# emerge --info
Portage 3.0.52_p14 (python 3.12.0-final-0, default/linux/amd64/17.1/hardened, gcc-13, glibc-2.38-r5, 6.5.5 x86_64)
=================================================================
System uname: Linux-6.5.5-x86_64-AMD_Ryzen_9_3950X_16-Core_Processor-with-glibc2.38
KiB Mem:    65756080 total,  46685548 free
KiB Swap:   16662520 total,  16662520 free
Timestamp of repository gentoo: Fri, 06 Oct 2023 11:04:05 +0000
Head commit of repository gentoo: 74d0ed83be1632ed718304d0b21d32d5341abb0c

Timestamp of repository kde: Thu, 05 Oct 2023 11:22:40 +0000
Head commit of repository kde: f172ef1e6f9da74926c6466c0c2e146598512e9c

Timestamp of repository qt: Thu, 05 Oct 2023 11:22:30 +0000
Head commit of repository qt: aee4b5960816430fbcd5268321fb109728f1b7a3

Timestamp of repository sam_c: Thu, 05 Oct 2023 11:22:45 +0000
Head commit of repository sam_c: 3af6501958b969d1b31ce5b8fbbb30b66414bc56

Timestamp of repository steam-overlay: Thu, 05 Oct 2023 11:22:31 +0000
Head commit of repository steam-overlay: c9dd5fe9c97e964326e8f0d9f5f8f6d4e682d814

sh dash 0.5.12
ld GNU ld (Gentoo 2.41 p2) 2.41.0
ccache version 4.8.3 [disabled]
app-misc/pax-utils:        1.3.7::gentoo
app-shells/bash:           5.2_p15-r6::gentoo
dev-java/java-config:      2.3.1-r1::gentoo
dev-lang/perl:             5.38.0-r1::gentoo
dev-lang/python:           3.10.13::gentoo, 3.11.6::gentoo, 3.12.0::gentoo
dev-lang/rust:             1.73.0::gentoo
dev-util/ccache:           4.8.3::gentoo
dev-util/cmake:            3.27.6-r1::gentoo
dev-util/meson:            1.2.2-r1::gentoo
sys-apps/baselayout:       2.14::gentoo
sys-apps/sandbox:          2.38::gentoo
sys-apps/systemd:          254.5::gentoo
sys-devel/autoconf:        2.13-r8::gentoo, 2.69-r9::gentoo, 2.71-r7::gentoo, 9999::gentoo
sys-devel/automake:        1.16.5-r1::gentoo
sys-devel/binutils:        2.38-r2::gentoo, 2.39-r5::gentoo, 2.41-r2::gentoo
sys-devel/binutils-config: 5.5::gentoo
sys-devel/clang:           15.0.7-r3::gentoo, 16.0.6::gentoo, 17.0.2::gentoo
sys-devel/gcc:             10.5.0::gentoo, 11.4.1_p20231005::gentoo, 12.3.1_p20230929::gentoo, 13.2.1_p20230930::gentoo, 14.0.0_pre20231001::gentoo
sys-devel/gcc-config:      2.11::gentoo
sys-devel/libtool:         2.4.7-r1::gentoo
sys-devel/lld:             16.0.6::gentoo, 17.0.2::gentoo
sys-devel/llvm:            15.0.7-r3::gentoo, 16.0.6::gentoo, 17.0.2-r1::gentoo
sys-devel/make:            4.4.1-r1::gentoo
sys-kernel/linux-headers:  6.5::gentoo (virtual/os-headers)
sys-libs/glibc:            2.38-r5::gentoo
Repositories:

gentoo
    location: /var/db/repos/gentoo
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/gentoo.git
    priority: -1000
    eclass-overrides: sam_c
    volatile: False
    sync-git-verify-commit-signature: yes
    sync-git-clone-extra-opts: -b stable -c gc.reflogExpire=0 -c gc.reflogExpireUnreachable=0 -c gc.rerereresolved=0 -c gc.rerereunresolved=0 -c gc.pruneExpire=now

crossdev
    location: /var/db/repos/crossdev
    masters: gentoo
    eclass-overrides: sam_c
    volatile: True

kde
    location: /var/db/repos/kde
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/kde.git
    masters: gentoo
    eclass-overrides: sam_c
    volatile: False

local
    location: /var/db/repos/local
    masters: gentoo
    eclass-overrides: sam_c
    volatile: False

qt
    location: /var/db/repos/qt
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/qt.git
    masters: gentoo
    eclass-overrides: sam_c
    volatile: False

sam_c
    location: /var/db/repos/sam_c
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/sam_c.git
    masters: gentoo
    eclass-overrides: sam_c
    volatile: False

steam-overlay
    location: /var/db/repos/steam-overlay
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/steam-overlay.git
    masters: gentoo
    eclass-overrides: sam_c
    volatile: False

Installed sets: @sam-emacs, @sam-fonts, @sam-fortune
ACCEPT_KEYWORDS="amd64 ~amd64"
ACCEPT_LICENSE="@FREE"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-O2 -pipe -march=native -fdiagnostics-color=always -frecord-gcc-switches -Wreturn-type"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/config /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/php/apache2-php8.2/ext-active/ /etc/php/cgi-php8.2/ext-active/ /etc/php/cli-php8.2/ext-active/ /etc/php/fpm-php8.2/ext-active/ /etc/php/phpdbg-php8.2/ext-active/ /etc/revdep-rebuild /etc/sandbox.d /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXXFLAGS="-O2 -pipe -march=native -fdiagnostics-color=always -frecord-gcc-switches -Wreturn-type"
DISTDIR="/var/cache/distfiles"
EMERGE_DEFAULT_OPTS="--keep-going --with-bdeps=y --complete-graph --deep --dynamic-deps=n --changed-deps=n --usepkg-exclude sys-fs/zfs --usepkg-exclude sys-fs/zfs-kmod --usepkg=y --implicit-system-deps=n --jobs=4 --load-average 32"
ENV_UNSET="CARGO_HOME DBUS_SESSION_BUS_ADDRESS DISPLAY GDK_PIXBUF_MODULE_FILE GOBIN GOPATH PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR XDG_STATE_HOME"
FCFLAGS="-O2 -pipe -march=native -fdiagnostics-color=always -frecord-gcc-switches -Wreturn-type"
FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs binpkg-multi-instance buildpkg clean-logs config-protect-if-modified distlocks fixlafiles ipc-sandbox mount-sandbox multilib-strict network-sandbox news parallel-fetch parallel-install pid-sandbox pkgdir-index-trusted preserve-libs protect-owned qa-unresolved-soname-deps sandbox sfperms split-log strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-O2 -pipe -march=native -fdiagnostics-color=always -frecord-gcc-switches -Wreturn-type"
GENTOO_MIRRORS="https://mirrors.gethosted.online/gentoo/ https://www.mirrorservice.org/sites/distfiles.gentoo.org/ https://mirror.bytemark.co.uk/gentoo/ https://mirrors.soeasyto.com/distfiles.gentoo.org/"
LANG="en_GB.UTF-8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed -Wl,--defsym=__gentoo_check_ldflags__=0 -Wl,-z,pack-relative-relocs"
LEX="reflex"
LINGUAS="en en_GB"
MAKEOPTS="-j32 -l32"
PKGDIR="/var/cache/binpkgs"
PORTAGE_BUNZIP2_COMMAND="lbunzip2"
PORTAGE_COMPRESS="xz"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
RUSTFLAGS="-C target-cpu=native -C link-arg=-Wl,-z,pack-relative-relocs"
SHELL="/bin/bash"
USE="PIC X a52 aac acl acpi activities aes alsa amd64 avx avx2 bash-completion bluetooth branding bzip2 cairo caps cdda cdr cet clang cli crypt dbus declarative dist-kernel dri dts dvd dvdr editorconfig emacs encode exif f16c filecaps firewalld flac fma3 fortran freetype gdbm gif gmp gpm graphite gtk gui hardened harfbuzz hunspell iconv icu ipv6 jit jpeg kde kdesu kwallet lcms libnotify libtirpc lto mad mmx mmxext mng mp3 mp4 mpeg multilib ncurses nftables nls nptl ogg opengl openmp pam pango pclmul pcre pdf pgo pie pipewire plasma png policykit popcnt ppds pulseaudio qml qt5 rdrand readline screencast sdl seccomp semantic-desktop sha sound spell sse sse2 sse3 sse4_1 sse4_2 sse4a ssl ssp ssse3 startup-notification svg system-av1 system-binutils system-boost system-bootstrap system-cairo system-clang system-digest system-ffmpeg system-harfbuzz system-heimdal system-icu system-jpeg system-leveldb system-libevent system-libs system-libvpx system-libyaml system-llvm system-lz4 system-mitkrb5 system-sqlite system-ssl system-tbb system-uulib system-webp system-zlib systemd test-rust tiff truetype udev udisks unicode upower usb valgrind verify-sig vorbis vulkan wayland widgets x264 xattr xcb xft xml xtpax xv xvid zlib zsh-completion" ABI_X86="32 64" ADA_TARGET="gnat_2021" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon sheets words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="aes avx avx2 f16c fma3 mmx mmxext pclmul popcnt rdrand sha sse sse2 sse3 sse4_1 sse4_2 sse4a ssse3" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock greis isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="libinput" KERNEL="linux" L10N="en en-GB" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LLVM_TARGETS="AArch64 AMDGPU ARM AVR BPF Hexagon Lanai MSP430 Mips NVPTX PowerPC RISCV Sparc SystemZ WebAssembly X86 XCore" LUA_SINGLE_TARGET="lua5-1" LUA_TARGETS="lua5-1" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php8-1" POSTGRES_TARGETS="postgres15" PYTHON_SINGLE_TARGET="python3_11" PYTHON_TARGETS="python3_11 pypy3 python3_10 python3_12" QEMU_SOFTMMU_TARGETS="i386 x86_64" QEMU_USER_TARGETS="aarch64 aarch64_be alpha armeb hppa m68k ppc ppc64 ppc64le sparc sparc64" RUBY_TARGETS="ruby31 ruby32" VIDEO_CARDS="amdgpu radeonsi radeon" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq proto steal rawnat logmark ipmark dhcpmac delude chaos account"
YACC="byacc"
Unset:  ADDR2LINE, AR, ARFLAGS, AS, ASFLAGS, CC, CCLD, CONFIG_SHELL, CPP, CPPFLAGS, CTARGET, CXX, CXXFILT, ELFEDIT, EXTRA_ECONF, F77FLAGS, FC, GCOV, GPROF, INSTALL_MASK, LC_ALL, LD, LFLAGS, LIBTOOL, MAKE, MAKEFLAGS, NM, OBJCOPY, OBJDUMP, PORTAGE_BINHOST, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, RANLIB, READELF, SIZE, STRINGS, STRIP, YFLAGS
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-10-06 14:04:31 UTC
Created attachment 872224 [details]
build.log.xz
Comment 2 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-10-06 14:05:14 UTC
Created attachment 872225 [details, diff]
0001-Bug-1849874-Update-from-packed_simd_2-to-packed_simd.patch

These patches from upstream wfm.
Comment 3 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-10-06 14:05:30 UTC
Created attachment 872226 [details]
0002-Bug-1851530-Use-plain-packed_simd.-r-hsivonen-supply.patch

(Links are at the top of the patches.)
Comment 4 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-10-06 14:07:38 UTC
(In reply to Sam James from comment #2)
> Created attachment 872225 [details, diff] [details, diff]
> 0001-Bug-1849874-Update-from-packed_simd_2-to-packed_simd.patch
> 
> These patches from upstream wfm.

exherbo seems to have just done this one: https://gitlab.exherbo.org/exherbo/desktop/-/commit/09ca9db3248618ebeba0956a864f9ff88110cdb9#df83cff919759eb53e829e0f138e46a54f9c8232
Comment 5 asdfg 2023-10-08 13:54:45 UTC
Firefox (www-client/firefox-118.0.1) builds fine with dev-lang/rust-1.72.0-r1 from FireBurn overlay, compiled with LLVM/Clang 17 as of October 4th, 2023, with no additional patches applied.

It fails with dev-lang/rust1.73.0::gentoo, with the following error message:

ERROR: Don't know how to translate x86_64-gentoo-linux-musl for rustc
Comment 6 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-10-08 13:59:12 UTC
(In reply to asdfg from comment #5)
> Firefox (www-client/firefox-118.0.1) builds fine with
> dev-lang/rust-1.72.0-r1 from FireBurn overlay, compiled with LLVM/Clang 17
> as of October 4th, 2023, with no additional patches applied.
> 

I've no idea what changes that overlay makes, but we have a long-standing reason for using a matching LLVM with the version in the Rust used to build.

> It fails with dev-lang/rust1.73.0::gentoo, with the following error message:
> 
> ERROR: Don't know how to translate x86_64-gentoo-linux-musl for rustc

That sounds separate.
Comment 7 cyrillic 2023-10-08 14:18:42 UTC
An easy workaround for this is to comment out the --enable-rust-simd part from the firefox (and spidermonkey) ebuilds.
Comment 8 Morton Pellung 2023-10-09 17:02:13 UTC
>0001-Bug-1849874-Update-from-packed_simd_2-to-packed_simd.patch
>These patches from upstream wfm.

This is not only a LLVM problem, rust 1.73 upgrade on the weekend causes firefox build failure with GCC. I downgraded to rust 1.72 to get a working browser...

https://github.com/rust-lang/packed_simd/issues/356#issuecomment-1667769025
Comment 9 Attila Tóth 2023-10-11 10:36:22 UTC
It also hits www-client/seamonkey.
If I unpack current rust-1.73.0 it has packed_simd_2 0.3.8, not packed_simd 0.3.9. And where to look for rust-brotli's enc directory? What would be the best solution here?
Comment 10 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-10-11 11:47:41 UTC
*** Bug 915593 has been marked as a duplicate of this bug. ***
Comment 11 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-10-11 11:48:32 UTC
I think there's still another bug here because nobody should be hitting this. I think it's the fact that rust isn't slotted but the rust/rust-bin situation allows the wrong one to be picked. But w/e.
Comment 12 Attila Tóth 2023-10-11 12:29:32 UTC
(In reply to Sam James from comment #11)
> I think there's still another bug here because nobody should be hitting
> this. I think it's the fact that rust isn't slotted but the rust/rust-bin
> situation allows the wrong one to be picked. But w/e.

virtual/rust-1.72.0-r1 pulls in dev-lang/rust-1.72.0-r1. Upgrading world somehow doesn't upgrade virtual/rust to the latest 1.73.0, therefore there is a discrepancy between rust-bin and rust versions. Explicitly upgrading virtual/rust makes rust-bin bumped to 1.73.0.
Comment 13 Attila Tóth 2023-10-11 13:08:32 UTC
(In reply to Attila Tóth from comment #12)
> (In reply to Sam James from comment #11)
> > I think there's still another bug here because nobody should be hitting
> > this. I think it's the fact that rust isn't slotted but the rust/rust-bin
> > situation allows the wrong one to be picked. But w/e.
> 
> virtual/rust-1.72.0-r1 pulls in dev-lang/rust-1.72.0-r1. Upgrading world
> somehow doesn't upgrade virtual/rust to the latest 1.73.0, therefore there
> is a discrepancy between rust-bin and rust versions. Explicitly upgrading
> virtual/rust makes rust-bin bumped to 1.73.0.

Thunderbird and seamonkey pulls in virtual/rust-1.72.0...
Comment 14 cyrillic 2023-10-11 18:27:33 UTC
(In reply to Sam James from comment #11)
> I think it's the fact that rust isn't slotted but the rust/rust-bin
> situation allows the wrong one to be picked.

Maybe rust and rust-bin should block each other so that you don't end up with 2 different subslots of (effectively) the same package.
Comment 15 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-10-12 07:47:58 UTC
(In reply to Sam James from comment #11)
> I think there's still another bug here because nobody should be hitting
> this. I think it's the fact that rust isn't slotted but the rust/rust-bin
> situation allows the wrong one to be picked. But w/e.

Sorry, while this is an issue, I was completely wrong here.

This is indeed simply "fails to build with Rust 1.73". I forgot that we only require matching LLVM for Mozilla stuff with USE=clang.
Comment 16 Attila Tóth 2023-10-12 08:51:49 UTC
(In reply to cyrillic from comment #14)
> (In reply to Sam James from comment #11)
> > I think it's the fact that rust isn't slotted but the rust/rust-bin
> > situation allows the wrong one to be picked.
> 
> Maybe rust and rust-bin should block each other so that you don't end up
> with 2 different subslots of (effectively) the same package.

That would create and unresolvable conflict in case multiple packages are installed wanting to pull in different slots. It would be better to synchronize firefox, thunderbird and seamonkey regarding the required clang/llvm version if it may even be possible...
Comment 17 Attila Tóth 2023-10-12 08:52:20 UTC
Temporary downgrading to rust-1.72 solved the problem.
Comment 18 Attila Tóth 2023-10-12 08:53:22 UTC
(In reply to Attila Tóth from comment #16)
> (In reply to cyrillic from comment #14)
> > (In reply to Sam James from comment #11)
> > > I think it's the fact that rust isn't slotted but the rust/rust-bin
> > > situation allows the wrong one to be picked.
> > 
> > Maybe rust and rust-bin should block each other so that you don't end up
> > with 2 different subslots of (effectively) the same package.
> 
> That would create and unresolvable conflict in case multiple packages are
> installed wanting to pull in different slots. It would be better to
> synchronize firefox, thunderbird and seamonkey regarding the required
> clang/llvm version if it may even be possible...

Thank you for the patches, that will probably do it. I'll try to give it a spin.
Comment 19 Joonas Niilola gentoo-dev 2023-10-12 09:00:33 UTC
(In reply to Attila Tóth from comment #18)
> 
> Thank you for the patches, that will probably do it. I'll try to give it a
> spin.

Wait for 118.0.2, it's looking fine so far so most likely will push it in an hour or two. It as llvm-17 and therefore rust-1.73 support.
Comment 20 Larry the Git Cow gentoo-dev 2023-10-12 10:40:01 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=673ff5ed9ae5da6c5fd58bf9c0b2fe2c138742a8

commit 673ff5ed9ae5da6c5fd58bf9c0b2fe2c138742a8
Author:     Joonas Niilola <juippis@gentoo.org>
AuthorDate: 2023-10-12 10:38:36 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2023-10-12 10:39:58 +0000

    www-client/firefox: add 118.0.2
    
     - llvm-17 and rust-1.73 compatibility,
     - make 'hardened' use _FORTIFY_SOURCE=3.
    
    Closes: https://bugs.gentoo.org/910071
    Closes: https://bugs.gentoo.org/915306
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 www-client/firefox/Manifest               |  101 ++
 www-client/firefox/firefox-118.0.2.ebuild | 1440 +++++++++++++++++++++++++++++
 2 files changed, 1541 insertions(+)
Comment 21 asdfg 2023-10-12 19:15:53 UTC
=www-client/firefox-118.0.2 seems to still have the same problem, and those two patches attached fail.
Comment 22 Morton Pellung 2023-10-12 21:28:07 UTC
(In reply to Morton Pellung from comment #8)
> This is not only a LLVM problem, rust 1.73 upgrade on the weekend causes
> firefox build failure with GCC. I downgraded to rust 1.72 to get a working
> browser...

Firefox 118.0.2 builds now fine with "-clang" and rust 1.73.0,
tried it on two different machines.
Thank you for the fix!
Comment 23 cyrillic 2023-10-12 22:08:21 UTC
(In reply to Morton Pellung from comment #22)
> Firefox 118.0.2 builds now fine with "-clang" and rust 1.73.0 ...

firefox-118.0.2 also builds fine with USE="clang" when 1.73 is the only rust version installed.