Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 915213 - media-gfx/exiv2: add brotli USE flag for JPEG XL metadata
Summary: media-gfx/exiv2: add brotli USE flag for JPEG XL metadata
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo KDE team
URL: https://github.com/Exiv2/exiv2/pull/2381
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-10-05 14:27 UTC by David Korth
Modified: 2024-04-20 12:57 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
exiv2-0.28.0: Add brotli USE flag (exiv2-0.28.0-add-brotli-use-flag.patch,1021 bytes, patch)
2023-10-05 14:28 UTC, David Korth
Details | Diff
exiv2-0.28.0: Add jpegxl USE flag (exiv2-0.28.0-add-jpegxl-use-flag.patch,1021 bytes, patch)
2023-10-06 11:07 UTC, David Korth
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Korth 2023-10-05 14:27:34 UTC
libjxl 0.8.1's 'cjxl' can losslessly convert a regular JPEG image to JPEG XL format. The resulting .jxl file has Exif metadata compressed using the Brotli algorithm.

Exiv2 0.28.0 adds support for Brotli, but the ebuild currently has Brotli hard disabled. This patch adds a brotli USE flag and enables Brotli support, which allows for metadata decoding. (Among other things, since KDE's KFileMetaData uses Exiv2, this allows JPEG XL metadata to be displayed in Dolphin, exactly the same as JPEG metadata is currently displayed.)

Reproducible: Always

Steps to Reproduce:
1. Convert a JPEG image to JPEG XL using `cjxl`.
2. Attempt to view metadata using `exiv2 file.jxl`.
Actual Results:  
`exiv2` says: "No Exif data found in the file"

Expected Results:  
`exiv2` prints the same Exif metadata it would have displayed for the original JPEG file.
Comment 1 David Korth 2023-10-05 14:28:05 UTC
Created attachment 872188 [details, diff]
exiv2-0.28.0: Add brotli USE flag
Comment 2 Andreas Sturmlechner gentoo-dev 2023-10-06 07:12:25 UTC
It would seem very non-obvious by USE=brotli enabling JPEG XL features in packages.

USE=jpegxl is an established flag for that purpose.
Comment 3 David Korth 2023-10-06 11:07:36 UTC
Created attachment 872218 [details, diff]
exiv2-0.28.0: Add jpegxl USE flag

I used brotli as the USE flag because Exiv2's CMake option is specifically for enabling Brotli support, since it does support some JPEG XL functionality without it. Though, since it's mainly used for JPEG XL, it does make sense to rename it.

Attached is the same patch as before but with USE=jpegxl instead of USE=brotli.
Comment 4 Redeeman 2024-03-02 00:32:03 UTC
can confirm brotli support works fine with exiv2-0.28.1-r2.ebuild aswell
Comment 5 Larry the Git Cow gentoo-dev 2024-04-20 12:57:44 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=fd5f96251585aea0a96136b348925bdc04273273

commit fd5f96251585aea0a96136b348925bdc04273273
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2024-04-20 12:42:05 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2024-04-20 12:57:20 +0000

    media-gfx/exiv2: Add IUSE jpegxl
    
    Also fix DEPENDs, amends commit 796df1b8e5b17ac16f93676c64acd055eb337cc7
    
    Thanks-to: David Korth
    Closes: https://bugs.gentoo.org/915213
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 media-gfx/exiv2/exiv2-0.28.2-r1.ebuild | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)