Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 915176 - dev-util/maturin-1.2.3: Runs bundled binary blob
Summary: dev-util/maturin-1.2.3: Runs bundled binary blob
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Ionen Wolkens
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-10-04 15:48 UTC by Luke-Jr
Modified: 2024-01-06 22:27 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Luke-Jr 2023-10-04 15:48:35 UTC
dev-util/maturin-1.2.3 includes and executes a binary blob at ${WORKDIR}/cargo_home/gentoo/serde_derive-1.0.183/serde_derive-x86_64-unknown-linux-gnu

This should be built from source rather than blindly executed.
Comment 1 Ionen Wolkens gentoo-dev 2023-10-04 16:23:15 UTC
fwiw deleting the file just results in a build failure and would require extra work, aka
   = help: message: file missing from serde_derive manifest directory during macro expansion: /tmp/portage/dev-util/maturin-1.3.0/work/cargo_home/gentoo/serde_derive-1.0.183/serde_derive-x86_64-unknown-linux-gnu
error: proc-macro derive panicked

Not that it'd be impossible to work around but would rather wait for upstream. This should be fixed once it starts using serde >=1.0.184[1]

[1] https://github.com/serde-rs/serde/releases/tag/v1.0.184
Comment 2 Ionen Wolkens gentoo-dev 2023-10-04 16:25:56 UTC
On a side-note, if concerned, you can keep using maturin-1.1.0 which uses an older serde_derive version which did not do this.

Odds are it'll stay in the tree for a while due to stalled stabilizations.
Comment 3 Luke-Jr 2023-10-04 17:02:07 UTC
With setuptools-rust, mv ${WORKDIR}/cargo_home/gentoo/serde_derive-1.0.183/src/lib{_from_source,}.rs seems to get part of the way there, but the build fails:

error: cannot determine resolution for the macro `Token`
   --> /var/tmp/portage/dev-util/maturin-1.2.3/work/cargo_home/gentoo/serde_derive-1.0.183/src/bound.rs:292:31
    |
292 |                 colon_token: <Token![:]>::default(),
    |                               ^^^^^
    |
    = note: import resolution is stuck, try simplifying macro imports
...
Comment 4 Larry the Git Cow gentoo-dev 2023-12-02 16:26:51 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ea897bcc1f142a3769d42212be884335a153ce1f

commit ea897bcc1f142a3769d42212be884335a153ce1f
Author:     Ionen Wolkens <ionen@gentoo.org>
AuthorDate: 2023-12-02 16:12:18 +0000
Commit:     Ionen Wolkens <ionen@gentoo.org>
CommitDate: 2023-12-02 16:26:17 +0000

    dev-util/maturin: add 1.4.0
    
    Closes: https://bugs.gentoo.org/915176
    Signed-off-by: Ionen Wolkens <ionen@gentoo.org>

 dev-util/maturin/Manifest             | 122 ++++++++
 dev-util/maturin/maturin-1.4.0.ebuild | 549 ++++++++++++++++++++++++++++++++++
 2 files changed, 671 insertions(+)