Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 915032 - app-emacs/flim-1.14.9_p20231214: stablereq
Summary: app-emacs/flim-1.14.9_p20231214: stablereq
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Stabilization (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: GNU Emacs project
URL:
Whiteboard:
Keywords: ALLARCHES, CC-ARCHES, STABLEREQ
Depends on: 911295
Blocks:
  Show dependency tree
 
Reported: 2023-10-01 15:36 UTC by Maciej Barć
Modified: 2023-12-16 02:49 UTC (History)
1 user (show)

See Also:
Package list:
=app-emacs/flim-1.14.9_p20231214
Runtime testing required: ---
nattka: sanity-check+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Maciej Barć gentoo-dev 2023-10-01 15:36:18 UTC
Please stabilize
Comment 1 Ulrich Müller gentoo-dev 2023-11-24 20:09:34 UTC
Ping!
Comment 2 matoro archtester 2023-12-11 03:54:44 UTC
?

>>> Test phase: app-emacs/flim-1.14.9_p20230809
make -j30   check
emacs -batch -q -no-site-file -l FLIM-MK -f check-flim NONE NONE \
        NONE package-user-dir
PACKAGE_LISPDIR=~/.emacs.d/elpa

Loading /var/tmp/portage/app-emacs/flim-1.14.9_p20230809/work/flim-80b8121f05a5a0d7fcfe3e54085467a646dd2028/FLIM-CFG...

Error: file-missing ("Opening directory" "No such file or directory" "/var/tmp/portage/app-emacs/flim-1.14.9_p20230809/homedir/.emacs.d/elpa")
  mapbacktrace(#f(compiled-function (evald func args flags) #<bytecode 0x1940e438fbf53acd>))
  debug-early-backtrace()
  debug-early(error (file-missing "Opening directory" "No such file or directory" "/var/tmp/portage/app-emacs/flim-1.14.9_p20230809/homedir/.emacs.d/elpa"))
  directory-files("~/.emacs.d/elpa")
  normal-top-level-add-subdirs-to-load-path()
  (let ((default-directory PACKAGE_LISPDIR)) (normal-top-level-add-subdirs-to-load-path))
  (if (boundp 'PACKAGE_LISPDIR) (let ((default-directory PACKAGE_LISPDIR)) (normal-top-level-add-subdirs-to-load-path)))
  eval-buffer(#<buffer  *load*> nil "/var/tmp/portage/app-emacs/flim-1.14.9_p20230809/work/flim-80b8121f05a5a0d7fcfe3e54085467a646dd2028/FLIM-CFG" nil t)
  load-with-code-conversion("/var/tmp/portage/app-emacs/flim-1.14.9_p20230809/work/flim-80b8121f05a5a0d7fcfe3e54085467a646dd2028/FLIM-CFG" "/var/tmp/portage/app-emacs/flim-1.14.
9_p20230809/work/flim-80b8121f05a5a0d7fcfe3e54085467a646dd2028/FLIM-CFG" nil nil)
  load("/var/tmp/portage/app-emacs/flim-1.14.9_p20230809/work/flim-80b8121f05a5a0d7fcfe3e54085467a646dd2028/FLIM-CFG" nil nil t)
  load-file("FLIM-CFG")
  (let (prefix lisp-dir version-specific-lisp-dir) (and (setq prefix (car command-line-args-left)) (or (string-equal "NONE" prefix) (defvar PREFIX prefix))) (setq command-line-a
rgs-left (cdr command-line-args-left)) (and (setq lisp-dir (car command-line-args-left)) (or (string-equal "NONE" lisp-dir) (defvar LISPDIR lisp-dir))) (setq command-line-args-l
eft (cdr command-line-args-left)) (and (setq version-specific-lisp-dir (car command-line-args-left)) (or (string-equal "NONE" version-specific-lisp-dir) (progn (defvar VERSION_S
PECIFIC_LISPDIR version-specific-lisp-dir) (princ (format "VERSION_SPECIFIC_LISPDIR=%s\n" VERSION_SPECIFIC_LISPDIR))))) (setq command-line-args-left (cdr command-line-args-left)
) (and (setq package-lisp-dir (car command-line-args-left)) (or (string-equal "NONE" package-lisp-dir) (progn (defvar PACKAGE_LISPDIR (if (boundp (intern package-lisp-dir)) (sym
bol-value (intern package-lisp-dir)) package-lisp-dir)) (princ (format "PACKAGE_LISPDIR=%s\n" PACKAGE_LISPDIR))))) (setq command-line-args-left (cdr command-line-args-left)) (lo
ad-file "FLIM-CFG") (load-file "FLIM-ELS") (princ (format "PREFIX=%s\nLISPDIR=%s\n" PREFIX LISPDIR)))
  config-flim()
  check-flim()
  command-line-1(("-l" "FLIM-MK" "-f" "check-flim" "NONE" "NONE" "NONE" "package-user-dir"))
  command-line()
  normal-top-level()
Opening directory: No such file or directory, /var/tmp/portage/app-emacs/flim-1.14.9_p20230809/homedir/.emacs.d/elpa
make: *** [Makefile:38: check] Error 255
Comment 3 Larry the Git Cow gentoo-dev 2023-12-11 08:35:59 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=fbe1748ed18c8cb650eec86a9c57c880417cd7c5

commit fbe1748ed18c8cb650eec86a9c57c880417cd7c5
Author:     Ulrich Müller <ulm@gentoo.org>
AuthorDate: 2023-12-11 08:31:29 +0000
Commit:     Ulrich Müller <ulm@gentoo.org>
CommitDate: 2023-12-11 08:33:09 +0000

    app-emacs/flim: Unset PACKAGE_LISPDIR also for tests
    
    Bug: https://bugs.gentoo.org/915032
    Signed-off-by: Ulrich Müller <ulm@gentoo.org>

 app-emacs/flim/flim-1.14.9_p20230809.ebuild | 4 ++++
 1 file changed, 4 insertions(+)
Comment 4 Ulrich Müller gentoo-dev 2023-12-11 09:05:03 UTC
I've added PACKAGE_LISPDIR="NONE" in src_test which should fix the failure from comment #2.

However, I see more problems in test-hmac-md5.el. The following won't work in any modern Emacs version:

   (require 'hmac-md5)
   (hmac-md5 (make-string 50 ?\xdd) "key")

In fact, the md5 test in https://github.com/wanderlust/flim/tree/flim-1_14-wl/tests was last updated 23 years ago.

@Emacs team: Should we try to fix the tests or simply disable them?
Comment 5 Maciej Barć gentoo-dev 2023-12-11 12:38:44 UTC
(In reply to Ulrich Müller from comment #4)23 years ago.
> @Emacs team: Should we try to fix the tests or simply disable them?

From my research I think all the tests are broken but, but the pkg still could be useful, so I think we should put a RESTRICT=test.
Comment 6 Larry the Git Cow gentoo-dev 2023-12-11 14:17:31 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=cd514c1fc730e86dd9d72339c70b3bb5d43a1889

commit cd514c1fc730e86dd9d72339c70b3bb5d43a1889
Author:     Ulrich Müller <ulm@gentoo.org>
AuthorDate: 2023-12-11 14:15:50 +0000
Commit:     Ulrich Müller <ulm@gentoo.org>
CommitDate: 2023-12-11 14:17:26 +0000

    app-emacs/flim: Add test restriction
    
    Bug: https://bugs.gentoo.org/915032
    Signed-off-by: Ulrich Müller <ulm@gentoo.org>

 app-emacs/flim/flim-1.14.9_p20230809.ebuild | 1 +
 1 file changed, 1 insertion(+)
Comment 7 Ulrich Müller gentoo-dev 2023-12-11 14:20:18 UTC
(In reply to Maciej Barć from comment #5)
> ... the pkg still could be useful ...

It is a reverse dependency of semi and wanderlust, so it is definitely needed.

@arch teams: If you want to test this further, I suggest to emerge wanderlust with it.
Comment 8 Larry the Git Cow gentoo-dev 2023-12-15 08:16:47 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b4dbaad1daa4859c58c8cf94b3f27d54e0e1f27f

commit b4dbaad1daa4859c58c8cf94b3f27d54e0e1f27f
Author:     Ulrich Müller <ulm@gentoo.org>
AuthorDate: 2023-12-15 08:13:53 +0000
Commit:     Ulrich Müller <ulm@gentoo.org>
CommitDate: 2023-12-15 08:16:34 +0000

    app-emacs/flim: add 1.14.9_p20231214, drop 1.14.9_p20230809
    
    Test are fixed, so remove the "test" restriction.
    
    Bug: https://bugs.gentoo.org/915032
    Signed-off-by: Ulrich Müller <ulm@gentoo.org>

 app-emacs/flim/Manifest                                            | 2 +-
 .../{flim-1.14.9_p20230809.ebuild => flim-1.14.9_p20231214.ebuild} | 7 +++++--
 2 files changed, 6 insertions(+), 3 deletions(-)
Comment 9 Ulrich Müller gentoo-dev 2023-12-15 08:18:17 UTC
Tests are fixed in flim-1.14.9_p20231214, please stabilise this version instead.
Comment 10 matoro archtester 2023-12-16 02:49:52 UTC
amd64 ppc sparc x86 (ALLARCHES) done

all arches done