Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 914749 - dev-libs/libpeas-2.0.0 version bump
Summary: dev-libs/libpeas-2.0.0 version bump
Status: UNCONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords: EBUILD
Depends on:
Blocks: 914751
  Show dependency tree
 
Reported: 2023-09-26 17:29 UTC by Blake Batson
Modified: 2023-09-26 19:08 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
updated libpeas ebuild (libpeas-2.0.0.ebuild,2.10 KB, text/plain)
2023-09-26 17:29 UTC, Blake Batson
Details
Rebased gentoo-lua patch for 2.0.0 (2.0.0-lua.patch,2.62 KB, patch)
2023-09-26 17:30 UTC, Blake Batson
Details | Diff
libpeas 2.0.0 version bump and patch rebase (0001-dev-libs-libpeas-2.0.0-version-bump.patch,5.86 KB, patch)
2023-09-26 17:51 UTC, Blake Batson
Details | Diff
libpeas reverse dependencies (libpeas-reverse-dependencies.txt,693 bytes, text/plain)
2023-09-26 18:33 UTC, Blake Batson
Details
dev-libs/libpeas-2.0.0 version bump, patch rebase, and reverse dependency bump from slot addition (0001-deb-libs-libpeas-2.0.0-version-bump-patch-rebase-and.patch,24.63 KB, patch)
2023-09-26 19:08 UTC, Blake Batson
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Blake Batson 2023-09-26 17:29:06 UTC
Created attachment 871485 [details]
updated libpeas ebuild

Needed to bump this for dev-util/gnome-builder-45. I'm pretty sure it should go into a new slot which is what I did in the attached ebuild. I had to update the lua patch too.
Comment 1 Blake Batson 2023-09-26 17:30:11 UTC
Created attachment 871486 [details, diff]
Rebased gentoo-lua patch for 2.0.0
Comment 2 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-09-26 17:43:32 UTC
Could you attach patches in the form of 'git format-patch' output with a Signed-off-by instead? It's a lot easier to review and apply then.

Thanks!
Comment 3 Blake Batson 2023-09-26 17:51:27 UTC
Created attachment 871495 [details, diff]
libpeas 2.0.0 version bump and patch rebase

Sure, I think this is right
Comment 4 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-09-26 17:59:39 UTC
Thanks! I've also noticed there's https://github.com/gentoo/gentoo/pull/32202 (which appears stalled) for libpeas/gnome-builder. Maybe double check if any of the comments there apply to yours?
Comment 5 Blake Batson 2023-09-26 18:33:38 UTC
Created attachment 871497 [details]
libpeas reverse dependencies

Looking at that PR the only thing that jumps out at me in regards to libpeas specifically is that I missed a dependency on spidermonkey-115. It got pulled in anyways because the only packaged gjs version that met the version requirements depended on it as well. Should I add that to the dependencies just to be safe?

Also it was mentioned that the reverse dependencies of libpeas should be updated to specify a slot. I got a list of them from equery (attached), should I specify the libpeas slot those ebuilds depend on and include them in this patch?
Comment 6 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-09-26 18:37:42 UTC
Yeah, if libpeas is gaining a new slot, all existing reverse dependencies must specify which they need (with a revbump, but can git mv for this).
Comment 7 Blake Batson 2023-09-26 19:08:13 UTC
Created attachment 871498 [details, diff]
dev-libs/libpeas-2.0.0 version bump, patch rebase, and  reverse dependency bump from slot addition

Alright I updated the dependencies with new revisions that specify the slot