It looks like firefox-118.0[-dbus] is not working. Would be great to get a confirmation from someone actually running -dbus. Looks like there's a lot going on upstream regarding dbus support: https://bugzilla.mozilla.org/show_bug.cgi?id=1532281 I'll go through this tracker later time, trying to find patches to fix this issue locally for myself. Anyone facing this issue and willing to help, let me know which patch fixes the compilation when placed into /etc/portage/patches.
Weirdly I can build this with -dbus now, so reproducing seems to require a specific set of use flags. Closing in case this is a tinderbox-only bug, waiting for a real life case.
I encountered this particular compile error when building firefox-118.0 without dbus support. Attaching the build log.
Created attachment 871527 [details] build.log
Created attachment 871528 [details, diff] proposed patch to fix the problem
The problem is caused by WakeLockListener being unconditionally used [1] while the corresponding header inclusion is covered by MOZ_ENABLE_DBUS check [2]. [1] https://hg.mozilla.org/mozilla-central/file/tip/widget/gtk/nsAppShell.cpp#l300 [2] https://hg.mozilla.org/mozilla-central/file/tip/widget/gtk/nsAppShell.cpp#l27
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e0d88b2f004d1945611e1c1114b81b3d1741cfa6 commit e0d88b2f004d1945611e1c1114b81b3d1741cfa6 Author: Joonas Niilola <juippis@gentoo.org> AuthorDate: 2023-09-27 13:39:44 +0000 Commit: Joonas Niilola <juippis@gentoo.org> CommitDate: 2023-09-27 13:40:17 +0000 www-client/firefox: add -dbus patch fix for 118.0 Closes: https://bugs.gentoo.org/914738 Signed-off-by: Joonas Niilola <juippis@gentoo.org> www-client/firefox/Manifest | 2 +- www-client/firefox/firefox-118.0.ebuild | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
Thanks! Would be great if you upstreamed the patch with that knowledge. Unless it's fixed by upstream already of course.
I haven't hit this bug on my setup with patchset-01: emerge -pv =firefox-118.0 [ebuild R *] www-client/firefox-118.0:rapid::gentoo to /usr/armv7a-unknown-linux-gnueabihf/ USE="X jumbo-build system-harfbuzz system-icu system-jpeg system-libevent system-libvpx system-png system-webp -clang -dbus -debug (-eme-free) -geckodriver -gmp-autoupdate -hardened -hwaccel -jack -libproxy -lto -openh264 (-pgo) -pulseaudio -screencast (-selinux) -sndio -system-av1 (-system-python-libs) -telemetry -valgrind -wayland -wifi" CPU_FLAGS_ARM="neon" L10N="de -ach -af -an -ar -ast -az -be -bg -bn -br -bs -ca -ca-valencia -cak -cs -cy -da -dsb -el -en-CA -en-GB -eo -es-AR -es-CL -es-ES -es-MX -et -eu -fa -ff -fi -fr -fur -fy -ga -gd -gl -gn -gu -he -hi -hr -hsb -hu -hy -ia -id -is -it -ja -ka -kab -kk -km -kn -ko -lij -lt -lv -mk -mr -ms -my -nb -ne -nl -nn -oc -pa -pl -pt-BR -pt-PT -rm -ro -ru -sc -sco -si -sk -sl -son -sq -sr -sv -szl -ta -te -th -tl -tr -trs -uk -ur -uz -vi -xh -zh-CN -zh-TW" 0 KiB with gcc-11.4.0
Wonder if it's somehow -jumbo-build related again :)
(In reply to Joonas Niilola from comment #7) > Would be great if you upstreamed the patch with that knowledge. Sure. I've reported the issue upstream [1]. [1] https://bugzilla.mozilla.org/show_bug.cgi?id=1855731
