Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 914729 - [kde overlay] kde-apps/filelight-9999 deps on dev-libs/kirigami-addons as of upstream 85f8e416a
Summary: [kde overlay] kde-apps/filelight-9999 deps on dev-libs/kirigami-addons as of ...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Overlays (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo KDE team
URL: https://github.com/gentoo/kde/pull/941
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-09-26 03:27 UTC by Duncan
Modified: 2023-12-12 14:30 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Duncan 2023-09-26 03:27:47 UTC
Here's another dep change to go with all the others I saw on my last update (thanks):

Upstream filelight master (aka -9999 in gentoo) doesn't appear to require qt6 yet, and I'm still running it.  However (emails despammed for bugfiling):

commit 85f8e416a (HEAD, master)
Author:     Carl Schwan <carl@despammed>
AuthorDate: Wed Sep 13 23:13:46 2023 +0200
Commit:     Carl Schwan <carl@despammed>
CommitDate: Sat Sep 23 20:36:44 2023 +0000

Port AboutPage to FormCard

... adds the kirigami-addons requirement (CMakeLists.txt)

+find_package(KF${QT_MAJOR_VERSION}KirigamiAddons REQUIRED)
+set_package_properties(KF${QT_MAJOR_VERSION}KirigamiAddons PROPERTIES
+    TYPE REQUIRED
+    PURPOSE "Provides additional visual components"
+)

... because that's where it pulls formcard from (src/qml/AboutPage.qml):

+import org.kde.kirigamiaddons.formcard 1.0 as FormCard

Of course without kirigami-addons the filelight update dies with this:

CMake Error at CMakeLists.txt:64 (find_package):
By not providing "FindKF5KirigamiAddons.cmake" in CMAKE_MODULE_PATH this
project has asked CMake to find a package configuration file provided by
"KF5KirigamiAddons", but CMake did not find one.

After merging kirigami-addons (-9999 to match the rest of my live-kde system) filelight builds/merges and runs (including about page) just fine.
Comment 1 Duncan 2023-10-05 12:00:36 UTC
So filelight-9999 just switched to qt6 and I downgraded to -23.08.9999, which doesn't need kirigami-addons (tested by removing kirigami-addons and rebuilding filelight again after the downgrade).

But I'll leave this open since -9999 (and q6-based release versions) will presumably still need kirigami-addons after gentoo does the qt6 port on our side.  Feel free to close if you believe it's premature for that.
Comment 2 jospezial 2023-10-10 23:59:22 UTC
(In reply to Duncan from comment #1)
> So filelight-9999 just switched to qt6 and I downgraded to -23.08.9999,
> which doesn't need kirigami-addons (tested by removing kirigami-addons and
> rebuilding filelight again after the downgrade).
> 
> But I'll leave this open since -9999 (and q6-based release versions) will
> presumably still need kirigami-addons after gentoo does the qt6 port on our
> side.  Feel free to close if you believe it's premature for that.

See also bug 914830
Comment 3 Larry the Git Cow gentoo-dev 2023-12-02 19:25:01 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/proj/kde.git/commit/?id=4cd3037d21ce4c0431d6853e932a5763d3e57323

commit 4cd3037d21ce4c0431d6853e932a5763d3e57323
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2023-12-02 17:15:11 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2023-12-02 17:15:11 +0000

    dev-libs/kirigami-addons: Switch to KF6
    
    Closes: https://bugs.gentoo.org/914729
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 .../kirigami-addons/kirigami-addons-9999.ebuild    | 28 +++++++++++-----------
 1 file changed, 14 insertions(+), 14 deletions(-)
Comment 4 Larry the Git Cow gentoo-dev 2023-12-07 23:34:46 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/kde.git/commit/?id=a5f94a6c6e42f748e8b5ba9980e3f996f52fa39a

commit a5f94a6c6e42f748e8b5ba9980e3f996f52fa39a
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2023-12-07 20:07:44 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2023-12-07 23:33:04 +0000

    dev-libs/kirigami-addons: Co-installability fixed upstream
    
    Upstream commit 264f6355c0cad6220dae8de4f158f66cf956b050
    
    Bug: https://bugs.gentoo.org/914729
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 dev-libs/kirigami-addons/kirigami-addons-9999.ebuild | 1 -
 1 file changed, 1 deletion(-)
Comment 5 jospezial 2023-12-12 14:26:29 UTC
https://gitweb.gentoo.org/proj/kde.git/commit/?id=59cc2977a5e617d4218eecbb7031454fb470e102
"kde-apps/filelight: Add missing kirigami-addons dependency
Was recently added in the Qt6 port, is normally a runtime dependency but
in this case is also added to the CMakeLists."

Now this bug is fixed.