Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 914649 - gui-libs/libadwaita-1.4.0 Fix build with newer libappstream
Summary: gui-libs/libadwaita-1.4.0 Fix build with newer libappstream
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-09-25 09:46 UTC by jospezial
Modified: 2023-12-18 10:19 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description jospezial 2023-09-25 09:46:18 UTC
https://github.com/ximion/appstream/commit/bc76ecb70ced55a29b6490f85d5ab1ba19bd2efc
"Rename component get_releases to indicate that releases my not be loaded"


Please add that patch:
https://gitlab.gnome.org/GNOME/libadwaita/-/merge_requests/992/diffs?commit_id=ae9fa2b6ea29b398eed39e787189baef2dda7da6
"about-window: Fix build with newer libappstream"
Comment 1 jospezial 2023-09-25 10:12:02 UTC
https://github.com/ximion/appstream/commit/51f14eb06495146fb8271c481fb816fdbbd2a1e4
"Make AsMetadata handle AsReleases objects"

https://github.com/ximion/appstream/commit/dd23718eb014966f4cfc3b48e533dad5c0f4ab0e
"Wrap release entries in AsReleases container class
Since release metadata is now a thing, this is a much more futureproof
way of containing release entries, that we can also easily extend in
future without breaking API, in case that is needed."

It looks as some changes in appstream need some more patching in libadwaita:

FAILED: src/libadwaita-1.so.0.p/adw-about-window.c.o 
x86_64-pc-linux-gnu-gcc -Isrc/libadwaita-1.so.0.p -Isrc -I../libadwaita-1.4.0/src -I. -I../libadwaita-1.4.0 -Isrc/stylesheet -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/fribidi -I/usr/lib64/libffi/include -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/gtk-4.0 -I/usr/include/pango-1.0 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/cairo -I/usr/include/graphene-1.0 -I/usr/lib64/graphene-1.0/include -I/usr/include/freetype2 -I/usr/include/harfbuzz -I/usr/include/webp -I/usr/include/libpng16 -I/usr/include/pixman-1 -I/usr/include/appstream -fvisibility=hidden -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -std=gnu11 -DHAVE_CONFIG_H -DADWAITA_COMPILATION -Wcast-align -Wdate-time -Werror=format-security -Werror=format=2 -Wendif-labels -Werror=incompatible-pointer-types -Werror=missing-declarations -Werror=overflow -Werror=return-type -Werror=shift-count-overflow -Werror=shift-overflow=2 -Werror=implicit-fallthrough=3 -Wformat-nonliteral -Wformat-security -Winit-self -Wmaybe-uninitialized -Wmissing-field-initializers -Wmissing-include-dirs -Wmissing-noreturn -Wnested-externs -Wno-missing-field-initializers -Wno-sign-compare -Wno-strict-aliasing -Wno-unused-parameter -Wold-style-definition -Wpointer-arith -Wredundant-decls -Wshadow -Wstrict-prototypes -Wswitch-default -Wswitch-enum -Wtype-limits -Wundef -Wunused-function -Wfloat-equal -march=native -mtune=native -O2 -pipe -Wno-incompatible-function-pointer-types -fPIC -pthread -mfpmath=sse -msse -msse2 '-DG_LOG_DOMAIN="Adwaita"' -MD -MQ src/libadwaita-1.so.0.p/adw-about-window.c.o -MF src/libadwaita-1.so.0.p/adw-about-window.c.o.d -o src/libadwaita-1.so.0.p/adw-about-window.c.o -c ../libadwaita-1.4.0/src/adw-about-window.c
../libadwaita-1.4.0/src/adw-about-window.c: In function ‘adw_about_window_new_from_appdata’:
../libadwaita-1.4.0/src/adw-about-window.c:2007:12: error: assignment to ‘GPtrArray *’ {aka ‘struct _GPtrArray *’} from incompatible pointer type ‘AsReleases *’ {aka ‘struct _AsReleases *’} [-Werror=incompatible-pointer-types]
 2007 |   releases = as_component_get_releases_plain (component);
      |            ^
At top level:
cc1: note: unrecognized command-line option ‘-Wno-incompatible-function-pointer-types’ may have been intended to silence earlier diagnostics
cc1: some warnings being treated as errors
ninja: build stopped: subcommand failed.
Comment 2 jospezial 2023-11-15 03:02:49 UTC
appstream-0.16.4 and 1.0.0 have been released and libadwaita developers are busy now to adjust to the new appstream releases.
Comment 3 jospezial 2023-12-02 02:11:41 UTC
libadwaita Version 1.4.2 was just released.
A look at the commits of that branch shows that it should build now against appstream-1.0.0.

A selfmade live ebuild for libadwaita main branch works with dev-libs/appstream-9999.
Comment 4 Larry the Git Cow gentoo-dev 2023-12-18 10:19:45 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=36f762ab0cce15d1b7a24ee9ba19a45aa4d9f79e

commit 36f762ab0cce15d1b7a24ee9ba19a45aa4d9f79e
Author:     Guillermo Joandet <gjoandet@gmail.com>
AuthorDate: 2023-12-03 21:22:45 +0000
Commit:     Pacho Ramos <pacho@gentoo.org>
CommitDate: 2023-12-18 10:19:09 +0000

    gui-libs/libadwaita: Version bump to 1.4.2
    
    Signed-off-by: Guillermo Joandet <gjoandet@gmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/34114
    Closes: https://bugs.gentoo.org/914649
    Signed-off-by: Pacho Ramos <pacho@gentoo.org>

 gui-libs/libadwaita/Manifest                |  1 +
 gui-libs/libadwaita/libadwaita-1.4.2.ebuild | 66 +++++++++++++++++++++++++++++
 2 files changed, 67 insertions(+)