Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 914196 - games-emulation/melonds-jg - teakra/src/test.h:37:32: error: static assertion failed
Summary: games-emulation/melonds-jg - teakra/src/test.h:37:32: error: static assertion...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Linux bug wranglers
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks: 891201
  Show dependency tree
 
Reported: 2023-09-14 19:06 UTC by orbea
Modified: 2023-09-15 06:00 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Build log (build.log,15.22 KB, text/x-log)
2023-09-14 19:07 UTC, orbea
Details
Env (environment,53.07 KB, text/x-mpsub)
2023-09-14 19:08 UTC, orbea
Details

Note You need to log in before you can comment on or make changes to this bug.
Description orbea 2023-09-14 19:06:23 UTC
When building melonds-jg with crossdev using a i686-pc-linux-musl host system and x86_64-pc-linux-musl build system a static assert fails in the vendored teakra code.

Unfortunately melonds upstream modified teakra enough that a system version can't be used.

Reproducible: Always
Comment 1 orbea 2023-09-14 19:07:42 UTC
Created attachment 870585 [details]
Build log

In file included from /usr/i686-pc-linux-musl/tmp/portage/games-emulation/melonds-jg-0.9.5/work/melonds-0.9.5/jollygood/../src/teakra/src/test_generator.cpp:10:
/usr/i686-pc-linux-musl/tmp/portage/games-emulation/melonds-jg-0.9.5/work/melonds-0.9.5/jollygood/../src/teakra/src/test.h:37:32: error: static assertion failed
   37 | static_assert(sizeof(TestCase) == 4312);
      |               ~~~~~~~~~~~~~~~~~^~~~~~~
/usr/i686-pc-linux-musl/tmp/portage/games-emulation/melonds-jg-0.9.5/work/melonds-0.9.5/jollygood/../src/teakra/src/test.h:37:32: note: the comparison reduces to ‘(4308 == 4312)’
make: *** [Makefile:169: objs/src/teakra/src/test_generator.o] Error 1
Comment 2 orbea 2023-09-14 19:08:46 UTC
Created attachment 870586 [details]
Env
Comment 3 Larry the Git Cow gentoo-dev 2023-09-15 06:00:35 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=cf57ed6790be934bfc32398f3d10865da24b1ab0

commit cf57ed6790be934bfc32398f3d10865da24b1ab0
Author:     orbea <orbea@riseup.net>
AuthorDate: 2023-09-14 19:12:46 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-09-15 05:57:11 +0000

    games-emulation/melonds-jg: fix i686 build issue
    
    On a crossdev environment with x86_64-pc-linux-musl host and
    i686-pc-linux-musl build a static assert fails in the vendored teakra
    test_generator.cpp, but teakra was modified by the melonds upstream
    enough that a system version is not possible.
    
    However the jollygood port doesn't actually use any of the code in
    test_generator.cpp so it can be simply removed from the build. As this
    is unused code a revdump is not required.
    
    Closes: https://bugs.gentoo.org/914196
    Upstream-PR: https://gitlab.com/jgemu/melonds/-/merge_requests/9
    Upstream-Commit: https://gitlab.com/jgemu/melonds/-/commit/0953b8874187bfdd35a0bf787c3bdbb6cc65dc9d
    Signed-off-by: orbea <orbea@riseup.net>
    Closes: https://github.com/gentoo/gentoo/pull/32784
    Signed-off-by: Sam James <sam@gentoo.org>

 ...melonds-jg-0.9.5-teakra-no-test_generator.patch | 38 ++++++++++++++++++++++
 games-emulation/melonds-jg/melonds-jg-0.9.5.ebuild |  1 +
 2 files changed, 39 insertions(+)