Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 914177 - sys-apps/eza: incorrect usage of cargo.eclass
Summary: sys-apps/eza: incorrect usage of cargo.eclass
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High major (vote)
Assignee: Leonardo Hernández Hernández
URL:
Whiteboard:
Keywords: EBUILD, PATCH, PullRequest
Depends on:
Blocks:
 
Reported: 2023-09-14 08:56 UTC by dm9pZCAq
Modified: 2023-09-15 06:15 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
correct usage of myfeatures from cargo.eclass (eza.patch,663 bytes, patch)
2023-09-14 08:56 UTC, dm9pZCAq
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description dm9pZCAq 2023-09-14 08:56:15 UTC
Created attachment 870559 [details, diff]
correct usage of myfeatures from cargo.eclass

myfeatures not handled via cargo_src_compile, it is handled in cargo_src_configure

because of this, git use flag is ignored when doing it this way:
local myfeatures=(
    $(usev git)
)
cargo_src_compile --no-default-features

and doing cargo_src_install without ignoring default features causing rebuilding with default features during src_install

also when using sccache this causes another problems due to src_install phase done as root user

i attached patch to fix that
Comment 1 Larry the Git Cow gentoo-dev 2023-09-15 06:15:11 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=990c3ad38cf9a7ab2e45c2818915e3b19691caf6

commit 990c3ad38cf9a7ab2e45c2818915e3b19691caf6
Author:     Leonardo Hernández Hernández <leohdz172@proton.me>
AuthorDate: 2023-09-15 01:45:48 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-09-15 06:10:38 +0000

    sys-apps/eza: add 0.12.0
    
    Closes: https://bugs.gentoo.org/914177
    Signed-off-by: Leonardo Hernández Hernández <leohdz172@proton.me>
    Closes: https://github.com/gentoo/gentoo/pull/32786
    Signed-off-by: Sam James <sam@gentoo.org>

 sys-apps/eza/Manifest          |  50 ++++++++++
 sys-apps/eza/eza-0.12.0.ebuild | 209 +++++++++++++++++++++++++++++++++++++++++
 2 files changed, 259 insertions(+)