Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 914147 - kde-plasma/plasma-pa: missing dependency on dev-qt/qtwidgets, kde-frameworks/kconfig, kde-frameworks/knotifications
Summary: kde-plasma/plasma-pa: missing dependency on dev-qt/qtwidgets, kde-frameworks/...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo KDE team
URL: https://invent.kde.org/plasma/plasma-...
Whiteboard:
Keywords: UPSTREAM
Depends on:
Blocks:
 
Reported: 2023-09-13 19:02 UTC by Sam James
Modified: 2023-09-19 15:27 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-09-13 19:02:29 UTC
```
VDB: detected possibly incorrect RDEPEND (kde-plasma/plasma-pa-5.27.7)
dev-qt/qtquickcontrols2:5 <
                          > dev-qt/qtwidgets:5
                          > kde-frameworks/kconfig:5
kde-frameworks/kirigami:5 <
kde-frameworks/plasma:5   <
                          > kde-frameworks/knotifications:5
```

I couldn't see what qtwidgets was about.

```
$ rg -i kconfig /var/tmp/portage/kde-plasma/plasma-pa-5.27.7/work/plasma-pa-5.27.7
/var/tmp/portage/kde-plasma/plasma-pa-5.27.7/work/plasma-pa-5.27.7/src/CMakeLists.txt:46:kconfig_add_kcfg_files(plasma-volume-declarative GENERATE_MOC qml/globalconfig.kcfgc)
/var/tmp/portage/kde-plasma/plasma-pa-5.27.7/work/plasma-pa-5.27.7/src/qml/globalconfigskeleton.h:7:#include <KConfigSkeleton>
/var/tmp/portage/kde-plasma/plasma-pa-5.27.7/work/plasma-pa-5.27.7/src/qml/globalconfigskeleton.h:8:#include <KConfigWatcher>
/var/tmp/portage/kde-plasma/plasma-pa-5.27.7/work/plasma-pa-5.27.7/src/qml/globalconfigskeleton.h:12:class GlobalConfigSkeleton : public KConfigSkeleton
/var/tmp/portage/kde-plasma/plasma-pa-5.27.7/work/plasma-pa-5.27.7/src/qml/globalconfigskeleton.h:16:        : KConfigSkeleton(configName, parent)
/var/tmp/portage/kde-plasma/plasma-pa-5.27.7/work/plasma-pa-5.27.7/src/qml/globalconfigskeleton.h:21:        : KConfigSkeleton(config, parent)
/var/tmp/portage/kde-plasma/plasma-pa-5.27.7/work/plasma-pa-5.27.7/src/qml/globalconfigskeleton.h:28:    KConfigWatcher::Ptr m_configWatcher;
/var/tmp/portage/kde-plasma/plasma-pa-5.27.7/work/plasma-pa-5.27.7/src/qml/globalconfigskeleton.h:31:        m_configWatcher = KConfigWatcher::create(sharedConfig());
/var/tmp/portage/kde-plasma/plasma-pa-5.27.7/work/plasma-pa-5.27.7/src/qml/globalconfigskeleton.h:32:        connect(m_configWatcher.data(), &KConfigWatcher::configChanged, [this]() {
```

```
$ rg -i notifi /var/tmp/portage/kde-plasma/plasma-pa-5.27.7/work/plasma-pa-5.27.7
[...]

/var/tmp/portage/kde-plasma/plasma-pa-5.27.7/work/plasma-pa-5.27.7/src/CMakeLists.txt:54:    KF5::Notifications
/var/tmp/portage/kde-plasma/plasma-pa-5.27.7/work/plasma-pa-5.27.7/CMakeLists.txt:45:    Notifications
[...]
```
Comment 1 Andreas Sturmlechner gentoo-dev 2023-09-16 14:28:44 UTC
(In reply to Sam James from comment #0)
> ```
> VDB: detected possibly incorrect RDEPEND (kde-plasma/plasma-pa-5.27.7)
> dev-qt/qtquickcontrols2:5 <
src/kcm/package/contents/ui/CardListItem.qml:import QtQuick.Controls 2.0
src/kcm/package/contents/ui/DeviceComboBox.qml:import QtQuick.Controls 2.14
src/kcm/package/contents/ui/DeviceListItem.qml:import QtQuick.Controls 2.0
src/kcm/package/contents/ui/main.qml:import QtQuick.Controls 2.0
src/kcm/package/contents/ui/MuteButton.qml:import QtQuick.Controls 2.5 as QQC2
src/kcm/package/contents/ui/StreamListItem.qml:import QtQuick.Controls 2.0
src/kcm/package/contents/ui/VolumeControlsConfig.qml:import QtQuick.Controls 2.15 as QQC2
src/kcm/package/contents/ui/VolumeSlider.qml:import QtQuick.Controls 2.5 as QQC2

> kde-frameworks/kirigami:5 <
src/kcm/package/contents/ui/CardListItem.qml:import org.kde.kirigami 2.12 as Kirigami
src/kcm/package/contents/ui/DeviceListItem.qml:import org.kde.kirigami 2.5 as Kirigami
src/kcm/package/contents/ui/main.qml:import org.kde.kirigami 2.13 as Kirigami
src/kcm/package/contents/ui/StreamListItem.qml:import org.kde.kirigami 2.12 as Kirigami
src/kcm/package/contents/ui/VolumeControlsConfig.qml:import org.kde.kirigami 2.15 as Kirigami
src/kcm/package/contents/ui/VolumeSlider.qml:import org.kde.kirigami 2.5 as Kirigami

> kde-frameworks/plasma:5   <
applet/contents/ui/HorizontalStackView.qml:import org.kde.plasma.core 2.0 as PlasmaCore
applet/contents/ui/ListItemBase.qml:import org.kde.plasma.core 2.1 as PlasmaCore
applet/contents/ui/ListItemBase.qml:import org.kde.plasma.extras 2.0 as PlasmaExtras
applet/contents/ui/main.qml:import org.kde.plasma.core 2.1 as PlasmaCore
applet/contents/ui/main.qml:import org.kde.plasma.extras 2.0 as PlasmaExtras
applet/contents/ui/SmallToolButton.qml:import org.kde.plasma.components 3.0 as PlasmaComponents3
applet/contents/ui/SmallToolButton.qml:import org.kde.plasma.core 2.0 as PlasmaCore
applet/contents/ui/VolumeSlider.qml:import org.kde.plasma.core 2.1 as PlasmaCore
src/kcm/package/contents/ui/main.qml:import org.kde.plasma.core 2.1 as PlasmaCore
src/qml/PulseObjectFilterModel.qml:import org.kde.plasma.core 2.1 as PlasmaCore

>                           > kde-frameworks/knotifications:5
>                           > kde-frameworks/kconfig:5
Clearly, yes.

>                           > dev-qt/qtwidgets:5
> I couldn't see what qtwidgets was about.
Me neither, not sure where this is supposed to be coming from. Certainly not linking?
Comment 2 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-09-16 14:34:04 UTC
> 
> >                           > dev-qt/qtwidgets:5
> > I couldn't see what qtwidgets was about.
> Me neither, not sure where this is supposed to be coming from. Certainly not
> linking?

I see it on the final link line:
```
[51/51] : && /usr/lib/ccache/bin/x86_64-pc-linux-gnu-g++ -fPIC -O2 -pipe -march=native -fdiagnostics-color=always -frecord-gcc-switches -Wreturn-type  -ggdb3 -fno-operator-names -fno-exceptions -Wall -Wextra -Wcast-align -Wchar-subscripts -Wformat-security -Wno-long-long -Wpointer-arith -Wundef -Wnon-virtual-dtor -Woverloaded-virtual -Werror=return-type -Werror=init-self -Wvla -Wdate-time -Wsuggest-override -Wlogical-op -fdiagnostics-color=always  -Wl,--no-undefined -Wl,--enable-new-dtags -Wl,-O1 -Wl,--as-needed -Wl,--defsym=__gentoo_check_ldflags__=0 -Wl,-z,pack-relative-relocs    -ggdb3   -pthread -shared -Wl,-soname,libplasma-volume-declarative.so -o bin/libplasma-volume-declarative.so src/CMakeFiles/plasma-volume-declarative.dir/plasma-volume-declarative_autogen/mocs_compilation.cpp.o src/CMakeFiles/plasma-volume-declarative.dir/osdservice.cpp.o src/CMakeFiles/plasma-volume-declarative.dir/card.cpp.o src/CMakeFiles/plasma-volume-declarative.dir/client.cpp.o src/CMakeFiles/plasma-volume-declarative.dir/context.cpp.o src/CMakeFiles/plasma-volume-declarative.dir/device.cpp.o src/CMakeFiles/plasma-volume-declarative.dir/maps.cpp.o src/CMakeFiles/plasma-volume-declarative.dir/operation.cpp.o src/CMakeFiles/plasma-volume-declarative.dir/port.cpp.o src/CMakeFiles/plasma-volume-declarative.dir/profile.cpp.o src/CMakeFiles/plasma-volume-declarative.dir/pulseaudio.cpp.o src/CMakeFiles/plasma-volume-declarative.dir/pulseobject.cpp.o src/CMakeFiles/plasma-volume-declarative.dir/sink.cpp.o src/CMakeFiles/plasma-volume-declarative.dir/sinkinput.cpp.o src/CMakeFiles/plasma-volume-declarative.dir/modulemanager.cpp.o src/CMakeFiles/plasma-volume-declarative.dir/source.cpp.o src/CMakeFiles/plasma-volume-declarative.dir/sourceoutput.cpp.o src/CMakeFiles/plasma-volume-declarative.dir/stream.cpp.o src/CMakeFiles/plasma-volume-declarative.dir/volumemonitor.cpp.o src/CMakeFiles/plasma-volume-declarative.dir/volumeobject.cpp.o src/CMakeFiles/plasma-volume-declarative.dir/debug.cpp.o src/CMakeFiles/plasma-volume-declarative.dir/server.cpp.o src/CMakeFiles/plasma-volume-declarative.dir/streamrestore.cpp.o src/CMakeFiles/plasma-volume-declarative.dir/module.cpp.o src/CMakeFiles/plasma-volume-declarative.dir/canberracontext.cpp.o src/CMakeFiles/plasma-volume-declarative.dir/speakertest.cpp.o src/CMakeFiles/plasma-volume-declarative.dir/gsettingsitem.cpp.o src/CMakeFiles/plasma-volume-declarative.dir/qml/globalactioncollection.cpp.o src/CMakeFiles/plasma-volume-declarative.dir/qml/listitemmenu.cpp.o src/CMakeFiles/plasma-volume-declarative.dir/qml/plugin.cpp.o src/CMakeFiles/plasma-volume-declarative.dir/qml/microphoneindicator.cpp.o src/CMakeFiles/plasma-volume-declarative.dir/qml/volumeosd.cpp.o src/CMakeFiles/plasma-volume-declarative.dir/qml/volumefeedback.cpp.o src/CMakeFiles/plasma-volume-declarative.dir/globalconfig.cpp.o  /usr/lib64/libKF5GlobalAccel.so.5.110.0  /usr/lib64/libKF5I18n.so.5.110.0  /usr/lib64/libKF5Notifications.so.5.110.0  /usr/lib64/libKF5ConfigGui.so.5.110.0  /usr/lib64/libKF5CoreAddons.so.5.110.0  /usr/lib64/libcanberra.so  /usr/lib64/libQt5Quick.so.5.15.10  /usr/lib64/libQt5QmlModels.so.5.15.10  /usr/lib64/libQt5Qml.so.5.15.10  /usr/lib64/libQt5Network.so.5.15.10  /usr/lib64/libQt5Widgets.so.5.15.10  /usr/lib64/libKF5ConfigCore.so.5.110.0  /usr/lib64/libQt5DBus.so.5.15.10  /usr/lib64/libQt5Gui.so.5.15.10  /usr/lib64/libQt5Xml.so.5.15.10  /usr/lib64/libQt5Core.so.5.15.10  /usr/lib64/libpulse-mainloop-glib.so  /usr/lib64/libpulse.so  /usr/lib64/libgio-2.0.so  /usr/lib64/libgobject-2.0.so  /usr/lib64/libglib-2.0.so && :
```

and if I grep the build dir instead, I see some bits like:
```
/var/tmp/portage/kde-plasma/plasma-pa-5.27.8/work/plasma-pa-5.27.8_build/src/plasma-volume-declarative_autogen/moc_predefs.h:159:#define QT_WIDGETS_LIB 1
/var/tmp/portage/kde-plasma/plasma-pa-5.27.8/work/plasma-pa-5.27.8_build/src/plasma-volume-declarative_autogen/deps:559:        /usr/include/qt5/QtWidgets/QAction \
```

in the build dir, bin/libplasma-volume-declarative.so seems to be the only binary linked against qtwidgets:
```
# scanelf -vvvn  */*
Format: %o %n %F
[...]
bin/libplasma-volume-declarative.so: scanning file {ELFCLASS64,ELFDATA2LSB}
 TYPE   NEEDED FILE
ET_DYN libKF5GlobalAccel.so.5,libKF5I18n.so.5,libKF5Notifications.so.5,libKF5ConfigGui.so.5,libcanberra.so.0,libQt5Quick.so.5,libQt5Qml.so.5,libQt5Widgets.so.5,libKF5ConfigCore.so.5,libQt5DBus.so.5,libQt5Gui.
so.5,libQt5Core.so.5,libpulse-mainloop-glib.so.0,libpulse.so.0,libgio-2.0.so.0,libgobject-2.0.so.0,libglib-2.0.so.0,libstdc++.so.6,libc.so.6 bin/libplasma-volume-declarative.so
[...]
```

I've never been comfortable with moc/qtdeclarative so I might be missing something though
Comment 3 Andreas Sturmlechner gentoo-dev 2023-09-16 14:36:09 UTC
(In reply to Andreas Sturmlechner from comment #1)
> >                           > dev-qt/qtwidgets:5
> > I couldn't see what qtwidgets was about.
> Me neither, not sure where this is supposed to be coming from. Certainly not
> linking?
Oh, actually by /usr/lib64/qt5/qml/org/kde/plasma/private/volume/libplasma-volume-declarative.so:

src/qml/* using QAction QActionGroup QMenu headers but CMake is not defining the dependency.
Comment 4 Larry the Git Cow gentoo-dev 2023-09-16 16:53:31 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/kde.git/commit/?id=6d1071ecf45bdf64b083ac335b3d0fef023d98d5

commit 6d1071ecf45bdf64b083ac335b3d0fef023d98d5
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2023-09-16 14:25:01 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2023-09-16 15:11:41 +0000

    kde-plasma/plasma-pa: Add missing dependencies
    
    Bug: https://bugs.gentoo.org/914147
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 kde-plasma/plasma-pa/plasma-pa-5.27.49.9999.ebuild | 3 +++
 kde-plasma/plasma-pa/plasma-pa-9999.ebuild         | 3 +++
 2 files changed, 6 insertions(+)
Comment 5 Larry the Git Cow gentoo-dev 2023-09-19 15:27:01 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ac2a5306e3f0b2e6bac6dcae441ca0e5204edc0a

commit ac2a5306e3f0b2e6bac6dcae441ca0e5204edc0a
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2023-09-19 14:50:11 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2023-09-19 15:23:20 +0000

    kde-plasma/plasma-pa: Add missing dependencies
    
    Closes: https://bugs.gentoo.org/914147
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 kde-plasma/plasma-pa/plasma-pa-5.27.8-r1.ebuild | 39 +++++++++++++++++++++++++
 1 file changed, 39 insertions(+)