Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 914143 - kde-plasma/kwin: missing dependency on dev-qt/qtnetwork
Summary: kde-plasma/kwin: missing dependency on dev-qt/qtnetwork
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo KDE team
URL: https://invent.kde.org/plasma/kwin/-/...
Whiteboard:
Keywords: UPSTREAM
Depends on:
Blocks:
 
Reported: 2023-09-13 18:47 UTC by Sam James
Modified: 2023-09-19 15:26 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-09-13 18:47:17 UTC
```
VDB: detected possibly incorrect RDEPEND (kde-plasma/kwin-5.27.7-r2)
dev-libs/libinput            | dev-libs/libinput:=
dev-qt/qtconcurrent:5        <
dev-qt/qtquickcontrols2:5    <
dev-qt/qtvirtualkeyboard:5   <
dev-qt/qtwayland:5           <
                             > dev-qt/qtnetwork:5
kde-frameworks/kirigami:5    <
kde-frameworks/kitemmodels:5 <
kde-frameworks/kitemviews:5  <
kde-frameworks/krunner:5     <
kde-plasma/breeze:5          <
sys-libs/libcap              <
x11-libs/libxcb              | x11-libs/libxcb:=
x11-libs/xcb-util-image      <
```

```
$ rg -i network /var/tmp/portage/kde-plasma/kwin-5.27.7-r2/work
/var/tmp/portage/kde-plasma/kwin-5.27.7-r2/work/kwin-5.27.7/src/xwayland/lib/CMakeLists.txt:20:target_link_libraries(KWinXwaylandCommon Qt::Core Qt::Network)
```
Comment 1 Larry the Git Cow gentoo-dev 2023-09-16 18:35:55 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/kde.git/commit/?id=4c23df82ea0e2b3789ad1e88b35eaa7e9c2f7fa4

commit 4c23df82ea0e2b3789ad1e88b35eaa7e9c2f7fa4
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2023-09-16 18:19:43 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2023-09-16 18:33:14 +0000

    kde-plasma/kwin: Update dependencies
    
    Bug: https://bugs.gentoo.org/914143
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 kde-plasma/kwin/kwin-5.27.49.9999.ebuild | 4 ++--
 kde-plasma/kwin/kwin-9999.ebuild         | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)
Comment 2 Larry the Git Cow gentoo-dev 2023-09-18 08:39:54 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/kde.git/commit/?id=1c0b4fe5f9f85a969e37155a15fccfda1e813993

commit 1c0b4fe5f9f85a969e37155a15fccfda1e813993
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2023-09-18 07:50:33 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2023-09-18 07:50:33 +0000

    kde-plasma/kwin: Drop unused dependency
    
    Dropped in git master in commit 254e1645e62e7f72e92f9d91254d4cd9fc55200b
    
    Bug: https://bugs.gentoo.org/914143
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 kde-plasma/kwin/kwin-9999.ebuild | 1 -
 1 file changed, 1 deletion(-)
Comment 3 Andreas Sturmlechner gentoo-dev 2023-09-18 11:04:15 UTC
That leaves:
(In reply to Sam James from comment #0)
> dev-qt/qtquickcontrols2:5    <
./src/effects/overview/qml/DesktopBar.qml:import QtQuick.Controls 2.15
./src/effects/showfps/qml/main.qml:import org.kde.quickcharts.controls 1.0 as ChartControls
./src/effects/showfps/qml/main.qml:import QtQuick.Controls 2.15
./src/kcms/decoration/package/contents/ui/Buttons.qml:import QtQuick.Controls 2.15 as QQC2
./src/kcms/decoration/package/contents/ui/main.qml:import QtQuick.Controls 2.15 as QQC2
./src/kcms/desktop/package/contents/ui/main.qml:import QtQuick.Controls 2.15 as QQC2
./src/kcms/effects/package/contents/ui/Effect.qml:import QtQuick.Controls 2.5 as QQC2
./src/kcms/effects/package/contents/ui/main.qml:                'import QtQuick.Controls 2.5;' +
./src/kcms/effects/package/contents/ui/main.qml:import QtQuick.Controls 2.5 as QQC2
./src/kcms/effects/package/contents/ui/Video.qml:import QtQuick.Controls 2.5 as QQC2
./src/kcms/rules/package/contents/ui/main.qml:import QtQuick.Controls 2.14 as QQC2
./src/kcms/rules/package/contents/ui/OptionsComboBox.qml:import QtQuick.Controls 2.14 as QQC2
./src/kcms/rules/package/contents/ui/RuleItemDelegate.qml:import QtQuick.Controls 2.14 as QQC2
./src/kcms/rules/package/contents/ui/RulesEditor.qml:import QtQuick.Controls 2.15 as QQC2
./src/kcms/rules/package/contents/ui/ValueEditor.qml:import QtQuick.Controls 2.14 as QQC2
./src/kcms/scripts/package/contents/ui/main.qml:import QtQuick.Controls 2.15 as QQC2
./src/kcms/virtualkeyboard/package/contents/ui/main.qml:import QtQuick.Controls 2.3 as QQC2
./src/kcms/xwayland/package/contents/ui/main.qml:import QtQuick.Controls 2.3 as QQC2
./src/qml/frames/plasma/frame_none.qml:import QtQuick.Controls 2.15 as QQC2
./src/qml/frames/plasma/frame_unstyled.qml:import QtQuick.Controls 2.15 as QQC2
./tests/inputmethodstest.qml:import QtQuick.Controls 2.15
./tests/pointerconstraintstest.qml:import QtQuick.Controls 2.0
./tests/unmapdestroytest.qml:import QtQuick.Controls 2.15

> dev-qt/qtvirtualkeyboard:5   <
https://mail.kde.org/pipermail/distributions/2017-March/000633.html
https://bugs.gentoo.org/602742

Removed in upstream commit 3733e3e77f924d1733e2a2a092fb5fb2ddaa0e5 "Remove embedded implementation of the Virtual Keyboard"

> dev-qt/qtwayland:5           <
Already suspected a DEPEND-only in https://github.com/gentoo/kde/commit/9093ab70410b26af1a57c3ae703625e67b6bfc1c, let's move to DEPEND then.

> kde-frameworks/kirigami:5    <
./src/effects/overview/qml/DesktopBar.qml:import org.kde.kirigami 2.20 as Kirigami
./src/effects/overview/qml/ScreenView.qml:import org.kde.kirigami 2.20 as Kirigami
./src/effects/private/qml/WindowHeapDelegate.qml:import org.kde.kirigami 2.20 as Kirigami
./src/effects/private/qml/WindowHeap.qml:import org.kde.kirigami 2.20 as Kirigami
./src/effects/showfps/qml/main.qml:import org.kde.kirigami 2.18 as Kirigami
./src/kcms/decoration/package/contents/ui/ButtonGroup.qml:import org.kde.kirigami 2.20 as Kirigami
./src/kcms/decoration/package/contents/ui/Buttons.qml:import org.kde.kirigami 2.20 as Kirigami
./src/kcms/decoration/package/contents/ui/main.qml:import org.kde.kirigami 2.20 as Kirigami
./src/kcms/decoration/package/contents/ui/Themes.qml:import org.kde.kirigami 2.20 as Kirigami
./src/kcms/desktop/package/contents/ui/main.qml:import org.kde.kirigami 2.20 as Kirigami
./src/kcms/effects/package/contents/ui/Effect.qml:import org.kde.kirigami 2.5 as Kirigami
./src/kcms/effects/package/contents/ui/main.qml:import org.kde.kirigami 2.10 as Kirigami
./src/kcms/rules/package/contents/ui/main.qml:import org.kde.kirigami 2.12 as Kirigami
./src/kcms/rules/package/contents/ui/OptionsComboBox.qml:import org.kde.kirigami 2.10 as Kirigami
./src/kcms/rules/package/contents/ui/RuleItemDelegate.qml:import org.kde.kirigami 2.10 as Kirigami
./src/kcms/rules/package/contents/ui/RulesEditor.qml:import org.kde.kirigami 2.19 as Kirigami
./src/kcms/rules/package/contents/ui/ValueEditor.qml:import org.kde.kirigami 2.10 as Kirigami
./src/kcms/scripts/package/contents/ui/main.qml:import org.kde.kirigami 2.10 as Kirigami
./src/kcms/virtualkeyboard/package/contents/ui/main.qml:import org.kde.kirigami 2.6 as Kirigami
./src/kcms/xwayland/package/contents/ui/main.qml:import org.kde.kirigami 2.6 as Kirigami
./src/qml/frames/plasma/frame_none.qml:import org.kde.kirigami 2.12 as Kirigami
./src/qml/frames/plasma/frame_unstyled.qml:import org.kde.kirigami 2.12 as Kirigami

> kde-frameworks/kitemmodels:5 <
src/kcms/rules/package/contents/ui/RulesEditor.qml:import org.kde.kitemmodels 1.0
src/effects/tileseditor/qml/main.qml:import org.kde.kitemmodels 1.0 as KitemModels

> kde-frameworks/kitemviews:5  <
https://invent.kde.org/plasma/kwin/-/merge_requests/4419

> kde-frameworks/krunner:5     <
Seems there is no linking indeed.

> kde-plasma/breeze:5          <
I'd be careful with dropping it from RDEPEND, not doing it just now:
https://invent.kde.org/plasma/kwin/-/commit/5646313c2c98bf9d064c1be62b5d4166876400e0

> find_package(Breeze 5.9.0 CONFIG)
> set_package_properties(Breeze PROPERTIES
>     TYPE OPTIONAL
>     PURPOSE "For setting the default window decoration plugin"
> )
> if (${Breeze_FOUND})
>     if (${BREEZE_WITH_KDECORATION})
>         set(HAVE_BREEZE_DECO true)
>     else()
>         set(HAVE_BREEZE_DECO FALSE)
>     endif()
> else()
>     set(HAVE_BREEZE_DECO FALSE)
> endif()
> add_feature_info("Breeze-Decoration" HAVE_BREEZE_DECO "Default decoration plugin Breeze")
Comment 4 Larry the Git Cow gentoo-dev 2023-09-18 11:06:23 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/kde.git/commit/?id=9c8630ffebbd7afc5fd2f1a22df2bdad70b21530

commit 9c8630ffebbd7afc5fd2f1a22df2bdad70b21530
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2023-09-18 10:57:11 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2023-09-18 11:05:43 +0000

    kde-plasma/kwin: Drop obsolete dependencies
    
    Move dev-qt/qtwayland to DEPEND-only.
    
    Upstream commit 3733e3e77f924d1733e2a2a092fb5fb2ddaa0e5a
    
    Bug: https://bugs.gentoo.org/914143
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 kde-plasma/kwin/kwin-5.27.49.9999.ebuild | 4 +---
 kde-plasma/kwin/kwin-9999.ebuild         | 4 +---
 2 files changed, 2 insertions(+), 6 deletions(-)
Comment 5 Larry the Git Cow gentoo-dev 2023-09-19 15:26:59 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=111747fc7433350927fb49749b86c978e2e0a427

commit 111747fc7433350927fb49749b86c978e2e0a427
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2023-09-19 14:50:01 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2023-09-19 15:23:18 +0000

    kde-plasma/kwin: Fix dependencies
    
    Closes: https://bugs.gentoo.org/914143
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 kde-plasma/kwin/kwin-5.27.8-r1.ebuild | 136 ++++++++++++++++++++++++++++++++++
 1 file changed, 136 insertions(+)