Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 914087 - kde-plasma/xdg-desktop-portal-kde: missing dep on kde-frameworks/kservice
Summary: kde-plasma/xdg-desktop-portal-kde: missing dep on kde-frameworks/kservice
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo KDE team
URL: https://invent.kde.org/plasma/xdg-des...
Whiteboard:
Keywords: UPSTREAM
Depends on:
Blocks:
 
Reported: 2023-09-13 05:07 UTC by Sam James
Modified: 2023-09-16 10:49 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-09-13 05:07:53 UTC 
ELF says missing a dep on kitemviews and kservice, but I've only checked kservice:

```
$ rg -i kserv /var/tmp/portage/kde-plasma/xdg-desktop-portal-kde-5.27.7-r1/
/var/tmp/portage/kde-plasma/xdg-desktop-portal-kde-5.27.7-r1/work/xdg-desktop-portal-kde-5.27.7/src/appchooserdialog.cpp:28:#include <KService>
/var/tmp/portage/kde-plasma/xdg-desktop-portal-kde-5.27.7-r1/work/xdg-desktop-portal-kde-5.27.7/src/appchooserdialog.cpp:57:        KService::Ptr defaultService = KApplicationTrader::preferredService(m_appChooserData->mimeName());
/var/tmp/portage/kde-plasma/xdg-desktop-portal-kde-5.27.7-r1/work/xdg-desktop-portal-kde-5.27.7/src/appchooserdialog.cpp:71:        const KService::List appServices = KApplicationTrader::queryByMimeType(m_appChooserData->mimeName(), [](const KService::Ptr &service) -> bool {
/var/tmp/portage/kde-plasma/xdg-desktop-portal-kde-5.27.7-r1/work/xdg-desktop-portal-kde-5.27.7/src/appchooserdialog.cpp:74:        std::transform(appServices.begin(), appServices.end(), std::back_inserter(choices), [](const KService::Ptr &service) {
/var/tmp/portage/kde-plasma/xdg-desktop-portal-kde-5.27.7-r1/work/xdg-desktop-portal-kde-5.27.7/src/appchooserdialog.cpp:118:        KService::Ptr serv = KService::serviceByDesktopName(desktopFile);
/var/tmp/portage/kde-plasma/xdg-desktop-portal-kde-5.27.7-r1/work/xdg-desktop-portal-kde-5.27.7/src/appchooserdialog.cpp:411:    const KService::List appServices = KApplicationTrader::query([](const KService::Ptr &service) -> bool {
/var/tmp/portage/kde-plasma/xdg-desktop-portal-kde-5.27.7-r1/work/xdg-desktop-portal-kde-5.27.7/src/appchooserdialog.cpp:414:    for (const KService::Ptr &service : appServices) {
/var/tmp/portage/kde-plasma/xdg-desktop-portal-kde-5.27.7-r1/work/xdg-desktop-portal-kde-5.27.7/src/background.cpp:29:#include <KService>
/var/tmp/portage/kde-plasma/xdg-desktop-portal-kde-5.27.7-r1/work/xdg-desktop-portal-kde-5.27.7/src/background.cpp:79:    const KService::Ptr app = KService::serviceByDesktopName(app_id);
```
Comment 1 Andreas Sturmlechner gentoo-dev 2023-09-13 11:14:24 UTC 
(In reply to Sam James from comment #0)
> ELF says missing a dep on kitemviews
I can see that, but can not find any header use. Must be leaking from some other dependency down the line unfortunately.
Comment 2 Larry the Git Cow gentoo-dev 2023-09-13 12:39:24 UTC 
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/proj/kde.git/commit/?id=595e2904b919fdd68e44ec74d540a58a2338d88b

commit 595e2904b919fdd68e44ec74d540a58a2338d88b
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2023-09-13 11:21:19 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2023-09-13 11:21:19 +0000

    kde-plasma/xdg-desktop-portal-kde: Add missing dependency
    
    Closes: https://bugs.gentoo.org/914087
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 .../xdg-desktop-portal-kde/xdg-desktop-portal-kde-5.27.49.9999.ebuild    | 1 +
 kde-plasma/xdg-desktop-portal-kde/xdg-desktop-portal-kde-9999.ebuild     | 1 +
 2 files changed, 2 insertions(+)