Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 913755 - dev-go/golicense: Abandoned upstream?
Summary: dev-go/golicense: Abandoned upstream?
Status: RESOLVED OBSOLETE
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: William Hubbs
URL:
Whiteboard:
Keywords: PMASKED
Depends on:
Blocks:
 
Reported: 2023-09-07 13:22 UTC by Jesús P Rey (Chuso)
Modified: 2024-02-27 23:54 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jesús P Rey (Chuso) 2023-09-07 13:22:26 UTC
go-module.eclass documentation recommends using dev-go/golicense for analyzing a Go binary for statically-linked dependencies and their licenses, however, upstream seems to have abandoned dev-go/golicense.

The latest commit was in 2019 and there are known issues that make it fail with some Go binaries:

https://github.com/mitchellh/golicense/issues/4

This issue was acknowledged by the author, but was never fixed and the issue was just closed.

There is also one issue opened since 2020 asking if the project is abandoned, but it got no response from any maintainer so far:

https://github.com/mitchellh/golicense/issues/28

dev-go/lichen::guru seems to do the same work and it works where dev-go/golicense fails.
Comment 1 Alfred Wingate 2023-12-13 16:25:36 UTC
> This repository has been archived by the owner on Oct 31, 2023. It is now read-only. 

And now the repository appears to be archived.
Comment 2 Alfred Wingate 2023-12-13 16:32:07 UTC
ask@bigglane /home/ask/sources/lichen (master|u=)
 $ ./main /usr/bin/geoipupdate 
github.com/cenkalti/backoff/v4@v4.2.1: MIT (allowed)
github.com/gofrs/flock@v0.8.1: BSD-3-Clause (allowed)
github.com/spf13/pflag@v1.0.5: BSD-3-Clause (allowed)
golang.org/x/sync@v0.3.0: BSD-3-Clause (allowed)
ask@bigglane /home/ask/sources/lichen (master|u=)
 $ golicense /usr/bin/geoipupdate 
⚠  "/usr/bin/geoipupdate" ⚠

This executable was compiled without using Go modules or has 
zero dependencies. golicense considers this an error (exit code 1).


I ended up here over the shortcomings of golicense. So I'd advocate lichen being included in ::gentoo and being promoted in the go-module eclass documentation as well instead of golicense.
Comment 3 Larry the Git Cow gentoo-dev 2023-12-22 17:14:35 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=010d0c28f1255deace039353586531b4a062dbea

commit 010d0c28f1255deace039353586531b4a062dbea
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2023-12-22 17:06:09 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2023-12-22 17:06:09 +0000

    package.mask: Last rite dev-go/golicense
    
    Bug: https://bugs.gentoo.org/913755
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 profiles/package.mask | 6 ++++++
 1 file changed, 6 insertions(+)
Comment 4 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-01-05 07:15:06 UTC
commit 7fdfcfcb095ea6c0318b3b0708caedcbae8368b2 (HEAD -> master, origin/master, origin/HEAD)
Author: Sam James <sam@gentoo.org>
Date:   Fri Jan 5 07:10:31 2024 +0000

    dev-go/lichen: fix PkgMissingMetadataXml

    Signed-off-by: Sam James <sam@gentoo.org>

commit 01f04a4f2f2745abf15f7ae8e99ad23f929931ec
Author: William Hubbs <williamh@gentoo.org>
Date:   Thu Jan 4 11:17:41 2024 -0600

    dev-go/lichen: new package, add 0.1.7

    Imported from ::guru, this is a go binary license checker.

    Signed-off-by: William Hubbs <williamh@gentoo.org>
Comment 5 Larry the Git Cow gentoo-dev 2024-02-02 16:31:28 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=cecd419c91ade6b5c0619023dc1dc2525c08f0a9

commit cecd419c91ade6b5c0619023dc1dc2525c08f0a9
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2024-02-02 16:27:39 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2024-02-02 16:31:21 +0000

    dev-go/golicense: Remove last-rited pkg
    
    Closes: https://bugs.gentoo.org/913755
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 dev-go/golicense/Manifest               |  2 --
 dev-go/golicense/golicense-0.2.0.ebuild | 23 -----------------------
 dev-go/golicense/metadata.xml           |  8 --------
 profiles/package.mask                   |  6 ------
 4 files changed, 39 deletions(-)
Comment 6 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2024-02-02 16:31:51 UTC
Package removed.
Comment 7 Jesús P Rey (Chuso) 2024-02-08 17:04:58 UTC
Note that as mentioned in the first comment, the go-module.eclass documentation still recommends using dev-go/golicense:

https://devmanual.gentoo.org/eclass-reference/go-module.eclass/
https://gitweb.gentoo.org/repo/gentoo.git/tree/eclass/go-module.eclass#n48
Comment 8 Larry the Git Cow gentoo-dev 2024-02-27 23:54:33 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0e651d4b8db7082279b5e110c41abb2bc5293eba

commit 0e651d4b8db7082279b5e110c41abb2bc5293eba
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-02-27 23:53:31 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-02-27 23:53:31 +0000

    go-module.eclass: update dev-go/golicense -> dev-go/lichen
    
    As mentioned in the bug, the eclassdoc was stale and mentioned the old
    and now-removed dev-go/golicense. Suggest dev-go/lichen instead.
    
    Bug: https://bugs.gentoo.org/913755
    Signed-off-by: Sam James <sam@gentoo.org>

 eclass/go-module.eclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)