Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 913346 - acct-user/cron should set ACCT_USER_HOME_OWNER and ACCT_USER_HOME_PERMS
Summary: acct-user/cron should set ACCT_USER_HOME_OWNER and ACCT_USER_HOME_PERMS
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo's Team for Core System packages
URL: https://forums.gentoo.org/viewtopic-t...
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2023-08-30 17:48 UTC by Brian Evans (RETIRED)
Modified: 2023-09-05 16:00 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Evans (RETIRED) gentoo-dev 2023-08-30 17:48:54 UTC
In keeping with history and what sys-process/cronbase tries to accomplish, acct-user/cron should be setting ACCT_USER_HOME_OWNER="root:cron" and  ACCT_USER_HOME_PERMS="0750".

Because acct-user/cron is often merged before sys-process/cronbase (as it is in RDEPEND) and its keepdir with owner/group, the end result is that incorrect permissions can be set on directory creation.

This is as discussed in $URL.
Comment 1 Mike Gilbert gentoo-dev 2023-08-30 18:22:23 UTC
acct-user/cron has no maintainer since blueness was dropped from metadata.xml.
Comment 2 Mike Gilbert gentoo-dev 2023-08-30 18:31:58 UTC
I think I agree with the changes you are proposing for acct-user/cron.

In addition, we should drop the keepdir /var/spool/cron from sys-process/cronbase since it is entirely redundant.
Comment 3 Larry the Git Cow gentoo-dev 2023-09-05 15:08:20 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6fd345466e6afddbc2e4231dd7eb45b1685586a1

commit 6fd345466e6afddbc2e4231dd7eb45b1685586a1
Author:     Brian Evans <grknight@gentoo.org>
AuthorDate: 2023-09-05 13:52:06 +0000
Commit:     Mike Gilbert <floppym@gentoo.org>
CommitDate: 2023-09-05 15:05:25 +0000

    acct-user/cron: set home owner and perms
    
    In keeping with history and what sys-process/cronbase tries to accomplish,
    acct-user/cron should be setting ACCT_USER_HOME_OWNER="root:cron" and
    ACCT_USER_HOME_PERMS="0750".
    
    Because acct-user/cron is often merged before sys-process/cronbase(as it is
    in RDEPEND) and its keepdir with owner/group, the end result is that
    incorrect permissions can be set on directory creation.
    
    Closes: https://bugs.gentoo.org/913346
    Closes: https://github.com/gentoo/gentoo/pull/32630
    Signed-off-by: Tomas Fabrizio Orsi <torsi@fi.uba.ar>
    Signed-off-by: Mike Gilbert <floppym@gentoo.org>

 acct-user/cron/{cron-0-r1.ebuild => cron-0-r2.ebuild} | 2 ++
 1 file changed, 2 insertions(+)
Comment 4 Larry the Git Cow gentoo-dev 2023-09-05 15:24:20 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=9bf0e696f79b5e2b04487bb2c2d7ee0f1c83b4da

commit 9bf0e696f79b5e2b04487bb2c2d7ee0f1c83b4da
Author:     Mike Gilbert <floppym@gentoo.org>
AuthorDate: 2023-09-05 15:23:29 +0000
Commit:     Mike Gilbert <floppym@gentoo.org>
CommitDate: 2023-09-05 15:23:29 +0000

    sys-process/cronbase: do not keepdir /var/spool/cron
    
    This is handled via acct-user/cron.
    
    Bug: https://bugs.gentoo.org/913346
    Signed-off-by: Mike Gilbert <floppym@gentoo.org>

 .../cronbase/{cronbase-0.3.7-r8.ebuild => cronbase-0.3.7-r9.ebuild}   | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)