Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 913212 - app-emulation/libvirt-9.9.0: does not pull in app-emulation/virtiofsd as a dep
Summary: app-emulation/libvirt-9.9.0: does not pull in app-emulation/virtiofsd as a dep
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Virtualization Team
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2023-08-29 11:25 UTC by Kai-Chun Ning
Modified: 2024-01-26 09:10 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kai-Chun Ning 2023-08-29 11:25:36 UTC
virt-manager requires virtiofsd for virtiofs. Since Qemu 8, virtiofsd is no longer bundled and users would need to install app-emulation/virtiofsd. If not,
VM launch fails with error messages like here (https://forums.gentoo.org/viewtopic-p-8796136.html?sid=3e57e5dc18f893d9aa0b1e2dca47c7bf)

To avoid missing deps, it'd be better to add a USE flag to pull in app-emulation/virtiofsd.
Comment 1 Michal Prívozník 2023-12-17 21:07:27 UTC
The pull request I've just posted puts the virtiofsd dependency into app-emulation/libvirt. Having it there covers more use cases.

Can somebody update the bug summary (if necessary)? I don't have the permissions.
Comment 2 Kai-Chun Ning 2023-12-18 20:29:15 UTC
(In reply to Michal Prívozník from comment #1)
> The pull request I've just posted puts the virtiofsd dependency into
> app-emulation/libvirt. Having it there covers more use cases.
> 
> Can somebody update the bug summary (if necessary)? I don't have the
> permissions.

Thank you. I edited the summary.
Comment 3 Larry the Git Cow gentoo-dev 2024-01-26 07:50:49 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=577d19397bc20460c0aaa049e8cd8b0758e9db63

commit 577d19397bc20460c0aaa049e8cd8b0758e9db63
Author:     Michal Privoznik <michal.privoznik@gmail.com>
AuthorDate: 2023-12-17 20:41:43 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-01-26 07:49:34 +0000

    app-emulation/libvirt: Add virtiofsd USE flag
    
    While technically app-emulation/virtiofsd is not a libvirt
    dependency (app-emulation/qemu and app-emulation/virtiofsd can
    function on their own, happily), it's handy (in some scenarios)
    to drag it automatically in as a dependency. Invent "virtiofsd"
    USE flag that controls this.
    
    Bug: https://bugs.gentoo.org/913212
    Signed-off-by: Michal Privoznik <michal.privoznik@gmail.com>
    Signed-off-by: Sam James <sam@gentoo.org>

 app-emulation/libvirt/libvirt-10.0.0.ebuild  | 3 ++-
 app-emulation/libvirt/libvirt-9.9.0.ebuild   | 3 ++-
 app-emulation/libvirt/libvirt-9999.ebuild    | 3 ++-
 app-emulation/libvirt/metadata.xml           | 3 +++
 profiles/arch/amd64/package.use.mask         | 4 ++++
 profiles/arch/base/package.use.mask          | 4 ++++
 profiles/arch/powerpc/ppc64/package.use.mask | 4 ++++
 7 files changed, 21 insertions(+), 3 deletions(-)
Comment 4 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-01-26 09:10:24 UTC
In future, it might make sense to change this to an optfeature, but given it's quite important and it used to be bundled in qemu, I think a transitional USE at least makes sense for now.