Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 913177 - sci-astronomy/stellarium-23.2 - /.../INDIConnection.hpp: error: void INDIConnection::newDevice(INDI::BaseDevice ) marked override,
Summary: sci-astronomy/stellarium-23.2 - /.../INDIConnection.hpp: error: void INDIConn...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Alexey
URL: https://github.com/Stellarium/stellar...
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2023-08-29 00:14 UTC by Toralf Förster
Modified: 2023-09-28 20:00 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge-info.txt (emerge-info.txt,18.01 KB, text/plain)
2023-08-29 00:14 UTC, Toralf Förster
Details
emerge-history.txt (emerge-history.txt,255.63 KB, text/plain)
2023-08-29 00:14 UTC, Toralf Förster
Details
environment (environment,152.36 KB, text/plain)
2023-08-29 00:14 UTC, Toralf Förster
Details
etc.clang.tar.xz (etc.clang.tar.xz,976 bytes, application/x-xz)
2023-08-29 00:14 UTC, Toralf Förster
Details
etc.portage.tar.xz (etc.portage.tar.xz,26.46 KB, application/x-xz)
2023-08-29 00:14 UTC, Toralf Förster
Details
sci-astronomy:stellarium-23.2:20230828-235353.log.xz (sci-astronomy:stellarium-23.2:20230828-235353.log.xz,20.36 KB, application/x-xz)
2023-08-29 00:14 UTC, Toralf Förster
Details
temp.tar.xz (temp.tar.xz,52.65 KB, application/x-xz)
2023-08-29 00:14 UTC, Toralf Förster
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Toralf Förster gentoo-dev 2023-08-29 00:14:28 UTC
too long lines were shrinked:

      |       ^~~~~~~~~~~~~~
[375/972] : && /usr/bin/cmake -E rm -f plugins/TelescopeControl/src/Rts2/libTelescopeControl_Rts2.a && /usr/bin/x86_64-pc-linux-gnu-ar qc plugins/TelescopeControl/src/Rts2/libTelescopeControl_Rts2.a  plugins/TelescopeControl/src/Rts2/CMakeFiles/TelescopeControl_Rts2.dir/TelescopeControl_Rts2_autogen
[376/972] /usr/bin/x86_64-pc-linux-gnu-g++ -DCOPYRIGHT_YEARS=\"2000-2023\" -DDEBUG3 -DDEBUG4 -DDEBUG5 -DENABLE_MEDIA -DENABLE_NLS -DENABLE_SCRIPTING -DENABLE_SCRIPT_CONSOLE -DENABLE_SHOWMYSKY -DINSTALL_DATADIR=\"/usr/share/stellarium\" -DNDEBUG -DPACKAGE_VERSION=\"23.2.0\" -DQT_CORE_LIB -DQT_DLL -DQ
FAILED: plugins/TelescopeControl/src/INDI/CMakeFiles/TelescopeControl_INDI.dir/INDIConnection.cpp.o 
/usr/bin/x86_64-pc-linux-gnu-g++ -DCOPYRIGHT_YEARS=\"2000-2023\" -DDEBUG3 -DDEBUG4 -DDEBUG5 -DENABLE_MEDIA -DENABLE_NLS -DENABLE_SCRIPTING -DENABLE_SCRIPT_CONSOLE -DENABLE_SHOWMYSKY -DINSTALL_DATADIR=\"/usr/share/stellarium\" -DNDEBUG -DPACKAGE_VERSION=\"23.2.0\" -DQT_CORE_LIB -DQT_DLL -DQT_GUI_LIB 
In file included from /var/tmp/portage/sci-astronomy/stellarium-23.2/work/stellarium-23.2/plugins/TelescopeControl/src/INDI/INDIConnection.cpp:19:
/var/tmp/portage/sci-astronomy/stellarium-23.2/work/stellarium-23.2/plugins/TelescopeControl/src/INDI/INDIConnection.hpp:72:14: error: void INDIConnection::newDevice(INDI::BaseDevice*) marked override, but does not override
   72 |         void newDevice(INDI::BaseDevice *dp) override;
      |              ^~~~~~~~~

  -------------------------------------------------------------------

  This is an unstable amd64 chroot image at a tinderbox (==build bot)
  name: 23.0_desktop_plasma_systemd-20230825-105048

  -------------------------------------------------------------------

gcc-config -l:
 [1] x86_64-pc-linux-gnu-10
 [2] x86_64-pc-linux-gnu-13 *
clang/llvm (if any):
clang version 16.0.6
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/lib/llvm/16/bin
Configuration file: /etc/clang/clang.cfg
/usr/lib/llvm/16
16.0.6
Python 3.11.5
Available Ruby profiles:
  [1]   ruby31 (with Rubygems) *
Available Rust versions:
  [1]   rust-bin-1.72.0
  [2]   rust-1.72.0 *
The following VMs are available for generation-2:
1)	Eclipse Temurin JDK 11.0.19_p7 [openjdk-bin-11]
*)	Eclipse Temurin JDK 17.0.7_p7 [openjdk-bin-17]
3)	Eclipse Temurin JDK 8.372_p07 [openjdk-bin-8]
Available Java Virtual Machines:
  [1]   openjdk-bin-8 
  [2]   openjdk-bin-11 
  [3]   openjdk-bin-17  system-vm

php cli (if any):
go version go1.21.0 linux/amd64

  HEAD of ::gentoo
commit 7e0642ac83c80efc1819e5f1802fe74f1a92fe44
Author: Repository mirror & CI <repomirrorci@gentoo.org>
Date:   Mon Aug 28 23:16:41 2023 +0000

    2023-08-28 23:16:40 UTC

emerge -qpvO sci-astronomy/stellarium
[ebuild  N    ] sci-astronomy/stellarium-23.2  USE="deep-sky media nls scripting show-my-sky stars telescope verify-sig -debug -doc -gps -qt6 -test -webengine -xlsx"
Comment 1 Toralf Förster gentoo-dev 2023-08-29 00:14:29 UTC
Created attachment 868928 [details]
emerge-info.txt
Comment 2 Toralf Förster gentoo-dev 2023-08-29 00:14:31 UTC
Created attachment 868929 [details]
emerge-history.txt
Comment 3 Toralf Förster gentoo-dev 2023-08-29 00:14:32 UTC
Created attachment 868930 [details]
environment
Comment 4 Toralf Förster gentoo-dev 2023-08-29 00:14:33 UTC
Created attachment 868931 [details]
etc.clang.tar.xz
Comment 5 Toralf Förster gentoo-dev 2023-08-29 00:14:34 UTC
Created attachment 868932 [details]
etc.portage.tar.xz
Comment 6 Toralf Förster gentoo-dev 2023-08-29 00:14:35 UTC
Created attachment 868933 [details]
sci-astronomy:stellarium-23.2:20230828-235353.log.xz
Comment 7 Toralf Förster gentoo-dev 2023-08-29 00:14:36 UTC
Created attachment 868934 [details]
temp.tar.xz
Comment 8 David Duchesne 2023-09-01 20:27:47 UTC
I have the exact same issue reported by Toralf Förster. (stable amd64 hardened system)
Maybe downgrade 23.2 to unstable until it is resolved ? Otherwise user need to manually set a package.mask (I'm not sure what to do when two stable packages are available, portage always want to update the latest stable one)
Comment 9 Alexey 2023-09-05 08:14:10 UTC
This was a breaking change in sci-libs/indilib, so 23.1 cannot be built atm either without downgrading indilib
Comment 10 Andreas Sturmlechner gentoo-dev 2023-09-06 07:44:14 UTC
Upstream have no fix for git master yet? Do they have an issue to track progress?
Comment 11 Alexey 2023-09-06 07:50:38 UTC
Not yet, it's tracked at https://github.com/Stellarium/stellarium/issues/3038 and the current draft fix is at https://github.com/Stellarium/stellarium/pull/3269
Comment 12 Larry the Git Cow gentoo-dev 2023-09-06 08:29:58 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a0f8d0cf907d73eb5d35dde1025b3562386c20f2

commit a0f8d0cf907d73eb5d35dde1025b3562386c20f2
Author:     Alexey Sokolov <alexey+gentoo@asokolov.org>
AuthorDate: 2023-09-06 00:31:47 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2023-09-06 08:29:55 +0000

    sci-astronomy/stellarium: use indilib 1.8.5
    
    I'm not restoring older sci-libs/indilib because depending on it would
    prevent installing latest indilib at the same time, and actually 1.9.8
    doesn't build anymore without patching
    
    While Stellarium supports using external indilib, it also has support
    for downloading version 1.8.5 inside cmake using CPM, and using the
    needed parts of it statically - that's how official packages are built;
    here I'm telling CPM to not download it automatically, but use the
    source downloaded by portage
    
    Signed-off-by: Alexey Sokolov <alexey+gentoo@asokolov.org>
    Bug: https://bugs.gentoo.org/913177
    Closes: https://github.com/gentoo/gentoo/pull/32641
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 sci-astronomy/stellarium/Manifest                             |  1 +
 .../{stellarium-23.2.ebuild => stellarium-23.2-r1.ebuild}     | 11 +++++++++--
 2 files changed, 10 insertions(+), 2 deletions(-)
Comment 13 msdobrescu 2023-09-23 05:35:30 UTC
Tried the solution.
It works if you don't have indilib already installed from portage.
But if it is installed, building will fail the same.
I'd try to avoid using indilib from the system during building, if possible.
Comment 14 Alexey 2023-09-23 08:25:40 UTC
You're right, thanks, fixed in new PR
Comment 15 Larry the Git Cow gentoo-dev 2023-09-26 19:09:25 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=9e455800ddc8927d3b879edd7b83a9d041b5965f

commit 9e455800ddc8927d3b879edd7b83a9d041b5965f
Author:     Alexey Sokolov <alexey+gentoo@asokolov.org>
AuthorDate: 2023-09-23 08:19:08 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2023-09-26 19:06:26 +0000

    sci-astronomy/stellarium: fix build even when sci-libs/indilib is installed
    
    Bug: https://bugs.gentoo.org/913177
    Signed-off-by: Alexey Sokolov <alexey+gentoo@asokolov.org>
    Closes: https://github.com/gentoo/gentoo/pull/33002
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 sci-astronomy/stellarium/stellarium-23.2-r1.ebuild | 2 ++
 1 file changed, 2 insertions(+)