913018 – media-sound/volumeicon-0.5.1-r2 configure script includes bashism

Bug 913018 - media-sound/volumeicon-0.5.1-r2 configure script includes bashism

Summary: media-sound/volumeicon-0.5.1-r2 configure script includes bashism

Status:	UNCONFIRMED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	Normal normal
Assignee:	Gentoo Sound Team

URL:
Whiteboard:
Keywords:	PATCH

Depends on:
Blocks:	nonbash
	Show dependency tree

Reported:	2023-08-25 20:55 UTC by Esteve Varela Colominas
Modified:	2024-01-07 17:00 UTC (History)
CC List:	2 users (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Esteve Varela Colominas 2023-08-25 20:55:02 UTC

I'm getting the following error, as dash is my system shell:

    ./configure: 7082: NOTIFY_CFLAGS+= -DCOMPILEWITH_NOTIFY: not found

I'd like to add the following patch to the package: https://github.com/Maato/volumeicon/commit/b034dd1fefe38ef41a5e70f212f2aabf68010f93

Comment 1 Sam James archtester

2024-01-07 15:33:04 UTC

(In reply to Esteve Varela Colominas from comment #0)
> I'm getting the following error, as dash is my system shell:
> 
>     ./configure: 7082: NOTIFY_CFLAGS+= -DCOMPILEWITH_NOTIFY: not found
> 
> I'd like to add the following patch to the package:
> https://github.com/Maato/volumeicon/commit/
> b034dd1fefe38ef41a5e70f212f2aabf68010f93

Please do a PR to pull it in. Thanks!

Comment 2 Esteve Varela Colominas 2024-01-07 17:00:10 UTC

I'd much rather submit a PR to bump the ebuild to the current git revision, as there's a good 8 years difference. Is that an idea?