https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/ Issue: media-sound/g4music-3.2 fails to compile. Discovered on: amd64 (internal ref: guru_ci)
Created attachment 868673 [details] build.log build log and emerge --info
Error(s) that match a know pattern in addition to what has been reported in the summary: FAILED: src/g4music.p/action-handles.c src/g4music.p/application.c src/g4music.p/main.c src/g4music.p/gst/gst-player.c src/g4music.p/gst/peak-calculator.c src/g4music.p/gst/tag-parser.c src/g4music.p/ui/mini-bar.c src/g4music.p/ui/music-list.c src/g4music.p/ui/music-widgets.c src/g4music.p/ui/paintables.c src/g4music.p/ui/peak-bar.c src/g4music.p/ui/play-bar.c src/g4music.p/ui/play-panel.c src/g4music.p/ui/preferences.c src/g4music.p/ui/store-panel.c src/g4music.p/ui/switch-bar.c src/g4music.p/ui/volume-button.c src/g4music.p/ui/window.c src/g4music.p/utils/async-task.c src/g4music.p/utils/cover-cache.c src/g4music.p/utils/data-io.c src/g4music.p/utils/dir-cache.c src/g4music.p/utils/dir-monitor.c src/g4music.p/utils/mpris.c src/g4music.p/utils/music.c src/g4music.p/utils/music-library.c src/g4music.p/utils/music-loader.c src/g4music.p/utils/playlist-file.c src/g4music.p/utils/portal.c src/g4music.p/utils/tag-cache.c src/g4music.p/utils/thumbnailer.c Program appstream-util found: NO Program gtk4-update-icon-cache found: NO ../g4music-v3.2/src/ui/music-list.vala:121.36-121.49: error: Argument 1: Cannot convert from `void G4.MusicList.on_create_item (Gtk.ListItem)' to `delegate void Gtk.SignalListItemFactory.setup (Gtk.SignalListItemFactory, GLib.Object)'
This issue can only be partially fixed: https://gitweb.gentoo.org/repo/proj/guru.git/commit/media-sound/g4music/g4music-3.2.ebuild?h=dev&id=99927103a73478f41fca9b53bf324be6d5d8a34e dev-util/gtk-update-icon-cache (https://packages.gentoo.org/packages/dev-util/gtk-update-icon-cache) is still on version 3.x, but this package needs 4.x.
(In reply to Konstantin Tutsch from comment #3) > This issue can only be partially fixed: > > https://gitweb.gentoo.org/repo/proj/guru.git/commit/media-sound/g4music/ > g4music-3.2.ebuild?h=dev&id=99927103a73478f41fca9b53bf324be6d5d8a34e > > dev-util/gtk-update-icon-cache > (https://packages.gentoo.org/packages/dev-util/gtk-update-icon-cache) is > still on version 3.x, but this package needs 4.x. No, that isn't right. _If_ it were right, you should file a bug and have this bug depend on it. But it's not. That package was created by Gentoo (look at the upstream URL/repo) See https://gitweb.gentoo.org/repo/gentoo.git/tree/gui-libs/gtk/gtk-4.10.5.ebuild#n111.
Ah okay. I didn't know and I'm still learning. I've added a sed command to src_prepare to remove a whole function from the meson.build where the icon cache & desktop database are updated. If I'm not mistaken, the xdg eclass already does that and there's no need to do it twice. sed -i \ -e '/^gnome.post_install(/,/)/d' \ meson.build \ || die https://gitweb.gentoo.org/repo/proj/guru.git/commit/media-sound/g4music/g4music-3.2.ebuild?h=dev&id=a79c2f29f634134343f1054d3592cf2e82114523
(In reply to Konstantin Tutsch from comment #5) > Ah okay. I didn't know and I'm still learnig. > That's ok - I just mean if you think something needs doing, file a bug, it can't get done otherwise. > I've added a sed command to src_prepare to remove a whole function from the > meson.build where the icon cache & desktop database are updated. > If I'm not mistaken, the xdg eclass already does that and there's no need to > do it twice. > > sed -i \ > -e '/^gnome.post_install(/,/)/d' \ > meson.build \ > || die > lgtm, thanks! Indeed xdg.eclass does it for us.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/proj/guru.git/commit/?id=a79c2f29f634134343f1054d3592cf2e82114523 commit a79c2f29f634134343f1054d3592cf2e82114523 Author: Konstantin Tutsch <mail@konstantintutsch.de> AuthorDate: 2023-08-25 17:33:21 +0000 Commit: Konstantin Tutsch <mail@konstantintutsch.de> CommitDate: 2023-08-25 17:33:21 +0000 media-sound/g4music: remove gnome.post_install() from meson.build Closes: https://bugs.gentoo.org/912991 Signed-off-by: Konstantin Tutsch <mail@konstantintutsch.de> media-sound/g4music/g4music-3.2.ebuild | 5 +++++ 1 file changed, 5 insertions(+)
