Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 912844 - net-misc/nextcloud-client should depend on dev-libs/qtkeychain[keyring]
Summary: net-misc/nextcloud-client should depend on dev-libs/qtkeychain[keyring]
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal minor
Assignee: Bernard Cafarelli
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2023-08-22 17:36 UTC by Niklaus 'vimja' Hofer
Modified: 2023-09-15 08:01 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Niklaus 'vimja' Hofer 2023-08-22 17:36:24 UTC
Hi

For a couple of weeks now, the nextcloud client has asked me to authenticate every time I started it. It didn't use to do that before.

Investigating this, I found that the issue is resolved if I compile dev-libs/qtkeychain with USE="keyring".

I use the Gnome Keyring, but the USE flag description for qtkeychain says this is an implementation "for freedesktop.org Secret Service API password store", so I guess the same issue would apply to the KDE wallet, too?

Anyhow, nextcloud-client should probably depend on that flag beein set, otherwise, things can get a bit annoying. Or maybe it should have it's own USE flag to control dependency on the qtkeychain USE flag?
Comment 1 Andrei Slavoiu 2023-08-22 17:56:40 UTC
No, it's only needed for Gnome desktops. See https://bugs.gentoo.org/907201#c4
Comment 2 Niklaus 'vimja' Hofer 2023-08-22 19:11:29 UTC
So maybe adding a gnome-keyring USE flag to the nextcloud-client ebuild, that then has a dependency on qtkeychain[keyring]?
Comment 3 Florian Schmaus gentoo-dev 2023-08-23 17:56:28 UTC
Right now, I consider adding IUSE=keyring and changing

dev-libs/qtkeychain:=[qt5(+)]

to

dev-libs/qtkeychain:=[keyring?,qt5(+)]
Comment 4 Larry the Git Cow gentoo-dev 2023-09-15 08:01:56 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8fc807b994980f4c85d31710f3eff010dbc5b31c

commit 8fc807b994980f4c85d31710f3eff010dbc5b31c
Author:     Florian Schmaus <flow@gentoo.org>
AuthorDate: 2023-09-15 07:58:09 +0000
Commit:     Florian Schmaus <flow@gentoo.org>
CommitDate: 2023-09-15 07:59:35 +0000

    net-misc/nextcloud-client: info if qtkeychain is not installed with USE=keyring
    
    Also drop the USE=doc info message.
    
    Closes: https://bugs.gentoo.org/912844
    Signed-off-by: Florian Schmaus <flow@gentoo.org>

 net-misc/nextcloud-client/nextcloud-client-3.8.2-r1.ebuild | 8 +++++---
 net-misc/nextcloud-client/nextcloud-client-3.9.1.ebuild    | 8 +++++---
 net-misc/nextcloud-client/nextcloud-client-3.9.4.ebuild    | 8 +++++---
 3 files changed, 15 insertions(+), 9 deletions(-)