Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 912779 - app-misc/ola-0.10.9 with >=dev-libs/protobuf-23.0: configure parses protobuf version incorrectly
Summary: app-misc/ola-0.10.9 with >=dev-libs/protobuf-23.0: configure parses protobuf ...
Status: RESOLVED UPSTREAM
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Marek Szuba
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks: 912819
  Show dependency tree
 
Reported: 2023-08-21 20:01 UTC by Agostino Sarubbo
Modified: 2023-08-22 11:08 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,55.52 KB, text/plain)
2023-08-21 20:01 UTC, Agostino Sarubbo
Details
1-config.log (1-config.log,252.49 KB, text/plain)
2023-08-21 20:01 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2023-08-21 20:01:10 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: app-misc/ola-0.10.9 fails to compile.
Discovered on: amd64 (internal ref: ci)
Comment 1 Agostino Sarubbo gentoo-dev 2023-08-21 20:01:12 UTC
Created attachment 868391 [details]
build.log

build log and emerge --info
Comment 2 Agostino Sarubbo gentoo-dev 2023-08-21 20:01:14 UTC
Created attachment 868392 [details]
1-config.log

1-config.log
Comment 3 Marek Szuba archtester gentoo-dev 2023-08-21 21:58:15 UTC
Figured it out - turns out that newer versions of dev-libs/protobuf have libprotobuf version as returned by 'protoc --version' equal to the version number of the package itself, i.e. a two-part one. In the past protoc --version returned a three-part version number and that's what ola Autoconf scripts expect.
Comment 4 Larry the Git Cow gentoo-dev 2023-08-21 22:03:02 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=bcd9d776bcabb38130c4fe00d4e06913321ab6b4

commit bcd9d776bcabb38130c4fe00d4e06913321ab6b4
Author:     Marek Szuba <marecki@gentoo.org>
AuthorDate: 2023-08-21 22:00:37 +0000
Commit:     Marek Szuba <marecki@gentoo.org>
CommitDate: 2023-08-21 22:02:51 +0000

    app-misc/ola: require <dev-libs/protobuf-23
    
    Upstream build scripts expect three-part libprotobuf version numbers and
    fail on the recently introduced two-part ones.
    
    Closes: https://bugs.gentoo.org/912779
    Signed-off-by: Marek Szuba <marecki@gentoo.org>

 app-misc/ola/{ola-0.10.9.ebuild => ola-0.10.9-r1.ebuild} | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 5 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-08-22 09:15:43 UTC
< deps aren't sustainable if unaccompanied by an upstream report or similar.

Anyway: https://github.com/OpenLightingProject/ola/pull/1875
Comment 6 Marek Szuba archtester gentoo-dev 2023-08-22 10:59:02 UTC
I really haven't got time to immediately research or report issues upstream every time the Bleeding Edge breaks something. The fact the issue has been closed means the reported problem has been taken care of, not that I intend to do no more work on it.

Thank you for locating the patch, that saves me some time.
Comment 7 Larry the Git Cow gentoo-dev 2023-08-22 11:05:57 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8ec0c08491c69b89eeed62918be5a4badea1f6d2

commit 8ec0c08491c69b89eeed62918be5a4badea1f6d2
Author:     Marek Szuba <marecki@gentoo.org>
AuthorDate: 2023-08-22 11:03:47 +0000
Commit:     Marek Szuba <marecki@gentoo.org>
CommitDate: 2023-08-22 11:03:47 +0000

    app-misc/ola: let configure handle >=dev-libs/protobuf-23 version scheme
    
    From an as-of-yet-unmerged upstream PR, with thanks to sam for having
    located it.
    
    Bug: https://bugs.gentoo.org/912779
    Signed-off-by: Marek Szuba <marecki@gentoo.org>

 .../ola/files/ola-0.10.9-protobuf_versioning.patch | 42 ++++++++++++++++++++++
 .../{ola-0.10.9-r1.ebuild => ola-0.10.9-r2.ebuild} |  3 +-
 2 files changed, 44 insertions(+), 1 deletion(-)