Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 912402 - dev-util/vulkan-tools-1.3.250: allow "X" and "wayland" for cube
Summary: dev-util/vulkan-tools-1.3.250: allow "X" and "wayland" for cube
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo X packagers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-08-17 10:24 UTC by xbt573
Modified: 2023-09-19 01:16 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Simple patch which resolves this bug (vulkan-tools.diff,718 bytes, patch)
2023-08-17 10:25 UTC, xbt573
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description xbt573 2023-08-17 10:24:38 UTC
vulkan-tools ebuild disallows combination of X and wayland flags for cube flag, but there is both vkcube and vkcube-wayland executables in result of compilation if X and Wayland or only Wayland support enabled in compilation options.

Reproducible: Sometimes

Steps to Reproduce:
1. Emerge dev-util/vulkan-tools with USE="X wayland cube".
Actual Results:  
Emerge requires exactly one of X or Wayland.

Expected Results:  
Emerge compiles vulkan-tools and installs vkcube, vkcube-wayland, vkcubepp.

I quickly hacked simple patch for this ebuild, it could be better but it works. It's attached to bug.
Comment 1 xbt573 2023-08-17 10:25:10 UTC
Created attachment 868078 [details, diff]
Simple patch which resolves this bug
Comment 2 Ionen Wolkens gentoo-dev 2023-08-17 10:37:02 UTC
Haven't looked at the CMakeLists but if that works I guess this changed at some point then wrt bug #907071 comment #2 then? This used to not be possible and thought would need multibuild.

Having both at once is certainly something I've been wanting given I use both and had to constantly rebuild to swap.
Comment 3 xbt573 2023-08-17 10:51:31 UTC
Upstream builds vkcube-wayland binary independent of chosen backend if Wayland support if enabled (default).
This happens in both 1.3.246 (which is used in referenced bug) and latest 1.3.250 versions.
Comment 4 Ionen Wolkens gentoo-dev 2023-08-17 11:09:48 UTC
(In reply to xbt573 from comment #3)
> Upstream builds vkcube-wayland binary independent of chosen backend if
> Wayland support if enabled (default).
> This happens in both 1.3.246 (which is used in referenced bug) and latest
> 1.3.250 versions.
Yeah I presume the issues were in a yet older version than the bug and just hadn't be re-looked at, assuming I'm not missing something.
Comment 5 Larry the Git Cow gentoo-dev 2023-09-19 01:16:56 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=53af8fd4069bc353a47285da50132dc84298d547

commit 53af8fd4069bc353a47285da50132dc84298d547
Author:     Nick Sarnie <sarnex@gentoo.org>
AuthorDate: 2023-09-19 01:05:08 +0000
Commit:     Nick Sarnie <sarnex@gentoo.org>
CommitDate: 2023-09-19 01:14:26 +0000

    dev-util/vulkan-tools: Support multiple window systems
    
    Closes: https://bugs.gentoo.org/907071
    Closes: https://bugs.gentoo.org/912402
    
    Signed-off-by: Nick Sarnie <sarnex@gentoo.org>

 .../vulkan-tools/vulkan-tools-1.3.261-r1.ebuild    | 80 ++++++++++++++++++++++
 dev-util/vulkan-tools/vulkan-tools-9999.ebuild     |  6 +-
 2 files changed, 84 insertions(+), 2 deletions(-)