Bug 912164 – dev-util/ROPgadget-7.3 fails tests (PYTHON-3.12-SYSTEM)

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Agostino Sarubbo 2023-08-12 07:34:23 UTC]

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: dev-util/ROPgadget-7.3 fails tests (PYTHON-3.12-SYSTEM).
Discovered on: amd64 (internal ref: python-3.12_tinderbox)

NOTE:
(PYTHON-3.12-SYSTEM) in the summary means that the bug was found on a machine that runs python-3.12 but this bug MAY or MAY NOT BE related to the new python version

[Comment 1 Agostino Sarubbo 2023-08-12 07:34:26 UTC]

Created attachment 867673 [details]
build.log

build log and emerge --info

[Comment 2 mario.haustein 2023-08-30 21:11:48 UTC]

The test suite is not stable against newer capstone releases. I file an upstream issue (https://github.com/JonathanSalwan/ROPgadget/issues/190). In the meantime we should restrict the tests.

[Comment 3 Sam James 2023-08-30 21:27:19 UTC]

(In reply to mario.haustein from comment #2)
> The test suite is not stable against newer capstone releases. I file an
> upstream issue (https://github.com/JonathanSalwan/ROPgadget/issues/190). In
> the meantime we should restrict the tests.

Is the failure because ROPgadget is actually incompatible with new capstone? If so, we should depend on an older version (< ...).

If it's just tests and a problem in the tests themselves instead with new capstone, rather than the tests showing a real incompatibility, then restricting is fine.

[Comment 4 Larry the Git Cow 2023-09-01 16:49:01 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5c8140ec1d89b46bab86e5b0b5aa752c1cf56a46

commit 5c8140ec1d89b46bab86e5b0b5aa752c1cf56a46
Author:     Mario Haustein <[e-mail]>
AuthorDate: 2023-08-30 21:14:55 +0000
Commit:     Arthur Zamarin <[e-mail]>
CommitDate: 2023-09-01 16:48:49 +0000

    dev-util/ROPgadget: disable tests
    
    Closes: https://bugs.gentoo.org/912164
    Signed-off-by: Mario Haustein <[e-mail]>
    Signed-off-by: Arthur Zamarin <[e-mail]>

 dev-util/ROPgadget/ROPgadget-7.2.ebuild  | 4 ++++
 dev-util/ROPgadget/ROPgadget-7.3.ebuild  | 4 ++++
 dev-util/ROPgadget/ROPgadget-9999.ebuild | 4 ++++
 3 files changed, 12 insertions(+)

[Comment 5 mario.haustein 2023-09-01 16:51:44 UTC]

(In reply to Sam James from comment #3)
> (In reply to mario.haustein from comment #2)
> > The test suite is not stable against newer capstone releases. I file an
> > upstream issue (https://github.com/JonathanSalwan/ROPgadget/issues/190). In
> > the meantime we should restrict the tests.
> 
> Is the failure because ROPgadget is actually incompatible with new capstone?
> If so, we should depend on an older version (< ...).

It was indeed an incompatibility. As upstream released an update today, I ammended the PR such that older versions stay with older capstone versions and the new release depends on >=dev-libs/capstone-5.0.1

[Comment 6 mario.haustein 2023-09-01 16:59:11 UTC]

I did my rework just at the time my original PR was accepted. PR#32554 should fix the problem more like request in Comment #3. Sorry for the noise.

[Comment 7 Larry the Git Cow 2023-09-01 17:15:31 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4e0471185dbdf865bd24186004ce4dd27e8c9a0b

commit 4e0471185dbdf865bd24186004ce4dd27e8c9a0b
Author:     Mario Haustein <[e-mail]>
AuthorDate: 2023-09-01 16:45:45 +0000
Commit:     Arthur Zamarin <[e-mail]>
CommitDate: 2023-09-01 17:15:23 +0000

    dev-util/ROPgadget: restrict capstone dependency due to incompatibilities
    
    Closes: https://bugs.gentoo.org/912164
    Signed-off-by: Mario Haustein <[e-mail]>
    Signed-off-by: Arthur Zamarin <[e-mail]>

 .../{ROPgadget-7.2.ebuild => ROPgadget-7.2-r1.ebuild}         | 11 +++++------
 .../{ROPgadget-7.3.ebuild => ROPgadget-7.3-r1.ebuild}         | 11 +++++------
 2 files changed, 10 insertions(+), 12 deletions(-)