Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 912050 - app-editors/helix-23.10-r2 fails to compile on musl/llvm: thread 'main' panicked at 'Failed to compile tree-sitter grammars: 2 grammars failed to build', helix-term/build.rs:7:14
Summary: app-editors/helix-23.10-r2 fails to compile on musl/llvm: thread 'main' panic...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: AMD64 Linux
: Normal normal
Assignee: Patrick McLean
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2023-08-10 23:07 UTC by dysthesis
Modified: 2024-07-23 05:27 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,280.35 KB, text/x-log)
2023-08-10 23:07 UTC, dysthesis
Details
emerge --info '=app-editors/helix-23.05::gentoo' (emerge-info.txt,18.31 KB, text/plain)
2023-08-10 23:08 UTC, dysthesis
Details
emerge -pqv '=app-editors/helix-23.05::gentoo' (emerge-pqv.txt,175 bytes, text/plain)
2023-08-10 23:09 UTC, dysthesis
Details

Note You need to log in before you can comment on or make changes to this bug.
Description dysthesis 2023-08-10 23:07:53 UTC
Created attachment 867594 [details]
build.log

app-editors/helix fails to compile on musl/llvm.
Comment 1 dysthesis 2023-08-10 23:08:45 UTC
Created attachment 867595 [details]
emerge --info '=app-editors/helix-23.05::gentoo'
Comment 2 dysthesis 2023-08-10 23:09:14 UTC
Created attachment 867596 [details]
emerge -pqv '=app-editors/helix-23.05::gentoo'
Comment 3 Olaf Leidinger 2023-08-31 17:15:28 UTC
I've the same problem with clang profile (regular glibc system).
Comment 4 Kostadin Shishmanov 2023-08-31 17:33:01 UTC
https://wiki.gentoo.org/wiki/Modern_C_porting

Add bug 870412 to the "Blocks:" field

  Stderr: /var/tmp/portage/app-editors/helix-23.05/work/runtime/grammars/sources/rescript/src/scanner.c:134:9: error: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int [-Wimplicit-int]
    const in_string = state->in_quotes || state->in_backticks;
    ~~~~~ ^
    int
  1 error generated.

  Failure 2/2: d Parser compilation failed.
  Stdout: 
  Stderr: /var/tmp/portage/app-editors/helix-23.05/work/runtime/grammars/sources/d/src/scanner.c:70:9: error: call to undeclared function 'isascii'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
                          if (!isascii(lexer->lookahead) ||
                               ^
/var/tmp/portage/app-editors/helix-23.05/work/runtime/grammars/sources/d/src/scanner.c:81:9: error: call to undeclared function 'isascii'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
                          if (!isascii(lexer->lookahead) ||
                               ^
  /var/tmp/portage/app-editors/helix-23.05/work/runtime/grammars/sources/d/src/scanner.c:92:9: error: call to undeclared function 'isascii'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
                          if (!isascii(lexer->lookahead) ||
                               ^
  /var/tmp/portage/app-editors/helix-23.05/work/runtime/grammars/sources/d/src/scanner.c:126:9: error: call to undeclared function 'isascii'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
                          if (!isascii(lexer->lookahead) ||
                               ^
  4 errors generated.
Comment 5 Agostino Sarubbo gentoo-dev 2023-12-20 08:20:32 UTC
gcc14_tinderbox has reproduced this issue with version 23.10-r2 - Updating summary.
Comment 6 Larry the Git Cow gentoo-dev 2024-07-23 05:27:04 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=10f4218cb62f02b5ecfcaa97a877dc81f06cd944

commit 10f4218cb62f02b5ecfcaa97a877dc81f06cd944
Author:     Steffen Winter <steffen.winter@proton.me>
AuthorDate: 2024-07-17 13:05:18 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2024-07-23 05:26:49 +0000

    app-editors/helix: re-add grammar USE flag
    
    This also patches two tree-sitter parsers which wouldn't built with
    the newer stricter compilers regarding C11.
    
    Closes: https://bugs.gentoo.org/901107
    Closes: https://bugs.gentoo.org/912050
    Closes: https://bugs.gentoo.org/918941
    Closes: https://bugs.gentoo.org/933727
    Closes: https://bugs.gentoo.org/934041
    
    Signed-off-by: Steffen Winter <steffen.winter@proton.me>
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 .../helix-23.10-tree-sitter-d-gnu-extension.patch  | 65 ++++++++++++++++++++++
 ...x-23.10-tree-sitter-rescript-implicit-int.patch | 38 +++++++++++++
 ...helix-23.10-r2.ebuild => helix-23.10-r3.ebuild} | 28 +++++++---
 .../{helix-24.03.ebuild => helix-24.03-r1.ebuild}  | 26 ++++++---
 app-editors/helix/metadata.xml                     |  3 +
 5 files changed, 142 insertions(+), 18 deletions(-)