Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 911945 - net-proxy/squid-6.11 fails to compile: uses false instead of AR
Summary: net-proxy/squid-6.11 fails to compile: uses false instead of AR
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Hank Leininger
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks: tc-directly
  Show dependency tree
 
Reported: 2023-08-09 06:45 UTC by Agostino Sarubbo
Modified: 2024-10-21 09:16 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,107.76 KB, text/plain)
2023-08-09 06:45 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2023-08-09 06:45:08 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: net-proxy/squid-6.2 fails to compile.
Discovered on: amd64 (internal ref: ci)
Comment 1 Agostino Sarubbo gentoo-dev 2023-08-09 06:45:10 UTC
Created attachment 867447 [details]
build.log

build log and emerge --info
Comment 2 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-08-09 06:48:40 UTC
I'll take a look.
Comment 3 Agostino Sarubbo gentoo-dev 2023-08-09 06:53:21 UTC
The affected line is:

libtool: link: /bin/false cr .libs/libcompatsquid.a .libs/assert.o .libs/compat.o .libs/debug.o .libs/eui64_aton.o .libs/getaddrinfo.o .libs/getnameinfo.o .libs/inet_ntop.o .libs/inet_pton.o .libs/memrchr.o .libs/mswindows.o .libs/shm.o .libs/statvfs.o .libs/strnrchr.o .libs/strnstr.o .libs/xalloc.o .libs/xstrerror.o .libs/xstring.o .libs/xstrto.o 


This is a -native-symlinks build
Comment 4 Agostino Sarubbo gentoo-dev 2024-02-06 10:15:58 UTC
ci has reproduced this issue with version 6.6 - Updating summary.
Comment 5 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-02-06 10:23:10 UTC
I thought I'd fixed this a while ago. I'll see again, I guess.
Comment 6 Hank Leininger 2024-02-07 17:06:40 UTC
This will be fixed when the bump to 6.7 lands.
Comment 7 Larry the Git Cow gentoo-dev 2024-03-04 07:53:51 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=dcf9ec0ee70ae90ecb44fcb367fb5c0ad95aefca

commit dcf9ec0ee70ae90ecb44fcb367fb5c0ad95aefca
Author:     Hank Leininger <hlein@korelogic.com>
AuthorDate: 2024-02-06 22:52:34 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2024-03-04 07:53:48 +0000

    net-proxy/squid: bump to 6.7, fix compilation w/gcc-13
    
    Closes: https://bugs.gentoo.org/911945
    Signed-off-by: Hank Leininger <hlein@korelogic.com>
    Closes: https://github.com/gentoo/gentoo/pull/35206
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 net-proxy/squid/Manifest         |   2 +
 net-proxy/squid/squid-6.7.ebuild | 391 +++++++++++++++++++++++++++++++++++++++
 2 files changed, 393 insertions(+)
Comment 8 Agostino Sarubbo gentoo-dev 2024-03-04 08:55:16 UTC
ci has reproduced this issue with version 6.7 - Updating summary.
Comment 9 Joonas Niilola gentoo-dev 2024-03-04 12:43:29 UTC
Btw while pkgdiff -b'ing 6.6 and 6.7 I noticed it hardcodes _even_ more tools that are being used to /usr/bin/* - I don't think this is easily fixed, as a patch will grow so huge and I'm not sure if sed catches everything. Although it is easy to test.
Comment 10 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-03-04 12:55:25 UTC
I'll look at it. Upstream seem open to build improvements..
Comment 11 Agostino Sarubbo gentoo-dev 2024-07-04 07:15:09 UTC
ci has reproduced this issue with version 6.9 - Updating summary.
Comment 12 Agostino Sarubbo gentoo-dev 2024-09-01 07:28:16 UTC
ci has reproduced this issue with version 6.10 - Updating summary.
Comment 13 Agostino Sarubbo gentoo-dev 2024-10-07 06:57:41 UTC
ci has reproduced this issue with version 6.11 - Updating summary.
Comment 14 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-10-21 08:40:53 UTC
OK, lemme take a look at this again. I think it's just in one place.
Comment 15 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-10-21 08:47:26 UTC
AC_PATH_PROG(AR, ar, $FALSE)
AR_R="$AR r"
AC_SUBST(AR_R)
Comment 16 Larry the Git Cow gentoo-dev 2024-10-21 09:16:32 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0fb3dca4144e8a027305eaecad841c1da353e382

commit 0fb3dca4144e8a027305eaecad841c1da353e382
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-10-21 08:34:36 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-10-21 09:16:01 +0000

    net-proxy/squid: add 6.12
    
    * Fix respecting $AR
    * Add -std=gnu++17 for older GCC which doesn't yet default to gnu++17
    
    Closes: https://bugs.gentoo.org/911945
    Closes: https://bugs.gentoo.org/921688
    Signed-off-by: Sam James <sam@gentoo.org>

 net-proxy/squid/Manifest                  |   2 +
 net-proxy/squid/files/squid-6.12-ar.patch |  29 +++
 net-proxy/squid/squid-6.12.ebuild         | 417 ++++++++++++++++++++++++++++++
 3 files changed, 448 insertions(+)