Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 911722 - app-editors/remarkable-1.9.0_pre20210320-r2: custom css is not loaded on start (patch, upstream bug)
Summary: app-editors/remarkable-1.9.0_pre20210320-r2: custom css is not loaded on star...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Martin Dummer
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2023-08-04 19:15 UTC by Nikita Zlobin
Modified: 2024-02-29 12:45 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch to fix custom css load on application start (0001-Fix-issue-345-apply-custom-css-on-start.patch,937 bytes, patch)
2023-08-04 19:16 UTC, Nikita Zlobin
Details | Diff
Patch to fix custom css load on app start (edited) (0001-Fix-issue-345-apply-custom-css-on-start.patch,949 bytes, patch)
2023-08-04 19:19 UTC, Nikita Zlobin
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nikita Zlobin 2023-08-04 19:15:01 UTC
This bug affects even recent git version. I can't enter github due to problem with email, used there, but it seems that could be useless, since existing bug report never got attention: https://github.com/jamiemcg/Remarkable/issues/345 (perhaps, never will).

Anyway, fix is simple - looks like typo, when default empty css was used instead of configured.

Reproducible: Always
Comment 1 Nikita Zlobin 2023-08-04 19:16:16 UTC
Created attachment 867060 [details, diff]
Patch to fix custom css load on application start
Comment 2 Nikita Zlobin 2023-08-04 19:19:41 UTC
Created attachment 867061 [details, diff]
Patch to fix custom css load on app start (edited)

Forgot about comment for auto-close if that can ever get to upstream.
Comment 3 Martin Dummer 2024-01-31 20:29:13 UTC
Place upstream pull request

https://github.com/jamiemcg/Remarkable/pull/411
Comment 4 Nikita Zlobin 2024-02-01 06:53:40 UTC
(In reply to Martin Dummer from comment #3)
> Place upstream pull request
> 
> https://github.com/jamiemcg/Remarkable/pull/411

Great, thanks.
Comment 5 Larry the Git Cow gentoo-dev 2024-02-29 12:45:23 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=824b749b2b7acd55d422a1bd82a4279b5bf5421e

commit 824b749b2b7acd55d422a1bd82a4279b5bf5421e
Author:     Martin Dummer <martin.dummer@gmx.net>
AuthorDate: 2024-01-31 20:01:30 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2024-02-29 12:44:20 +0000

    app-editors/remarkable: fix custom css is not loaded on start
    
    patch to fix https://github.com/jamiemcg/Remarkable/issues/345
    
    Closes: https://bugs.gentoo.org/911722
    Signed-off-by: Martin Dummer <martin.dummer@gmx.net>
    Closes: https://github.com/gentoo/gentoo/pull/35120
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 .../remarkable/files/fix-custom-css-issue.patch    | 29 +++++++++
 .../remarkable-1.9.0_pre20210320-r3.ebuild         | 70 ++++++++++++++++++++++
 2 files changed, 99 insertions(+)