Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 911369 - sci-libs/scikit-learn-1.1.2 fails to compile (PYTHON-3.12-SYSTEM)
Summary: sci-libs/scikit-learn-1.1.2 fails to compile (PYTHON-3.12-SYSTEM)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Science Related Packages
URL:
Whiteboard: old version only
Keywords:
Depends on: 920680
Blocks: 921826 cython3-tracker
  Show dependency tree
 
Reported: 2023-07-28 07:05 UTC by Agostino Sarubbo
Modified: 2024-03-10 14:49 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,150.07 KB, text/plain)
2023-07-28 07:05 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2023-07-28 07:05:19 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: sci-libs/scikit-learn-1.1.2 fails to compile (PYTHON-3.12-SYSTEM).
Discovered on: amd64 (internal ref: python-3.12_tinderbox)

NOTE:
(PYTHON-3.12-SYSTEM) in the summary means that the bug was found on a machine that runs python-3.12 but this bug MAY or MAY NOT BE related to the new python version
Comment 1 Agostino Sarubbo gentoo-dev 2023-07-28 07:05:21 UTC
Created attachment 866456 [details]
build.log

build log and emerge --info
Comment 2 Agostino Sarubbo gentoo-dev 2023-07-28 07:05:22 UTC
Error(s) that match a know pattern:


Cython.Compiler.Errors.CompileError: sklearn/ensemble/_hist_gradient_boosting/splitting.pyx
Cython.Compiler.Errors.CompileError: sklearn/neighbors/_ball_tree.pyx
Cython.Compiler.Errors.CompileError: sklearn/neighbors/_kd_tree.pyx
Cython.Compiler.Errors.CompileError: sklearn/neighbors/_quad_tree.pyx
Cython.Compiler.Errors.CompileError: sklearn/svm/_liblinear.pyx
Cython.Compiler.Errors.CompileError: sklearn/svm/_libsvm.pyx
Cython.Compiler.Errors.CompileError: sklearn/svm/_libsvm_sparse.pyx
Cython.Compiler.Errors.CompileError: sklearn/tree/_splitter.pyx
Cython.Compiler.Errors.CompileError: sklearn/tree/_tree.pyx
Comment 3 Larry the Git Cow gentoo-dev 2023-08-06 12:30:38 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c60a1f1c9144a65c5bd04296bac73be150873a03

commit c60a1f1c9144a65c5bd04296bac73be150873a03
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2023-08-06 12:26:53 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2023-08-06 12:30:31 +0000

    sci-libs/scikit-learn: Require <dev-python/cython-3
    
    Bug: https://bugs.gentoo.org/911369
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 sci-libs/scikit-learn/scikit-learn-1.1.2.ebuild | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
Comment 4 Erik Quaeghebeur 2023-10-31 14:18:32 UTC
I inquired, and apparently ≥scikit-learn-1.2 supports ≥cython-3. However, it seems that recent versions went back to requiring <cython-3 for performance reasons (see https://github.com/scikit-learn/scikit-learn/issues/26858).
Comment 5 je_fro@yahoo.com 2023-11-04 22:12:02 UTC
jeremiedbb commented on Oct 4
Good news, I ran some benchmarks regarding the estimators for which we identified slowdowns coming from cython 3 (RandomForest*, (Hist)GradientBoosting*, KNeighbors*) against the latest cython master and they're all as fast as they were with cython 0.29.36 (sometimes even a little bit faster) !

https://github.com/scikit-learn/scikit-learn/issues/27086#issuecomment-1747111276

scikit-learn-1.3.2 running fine here - no performance issues with cython-3.0.5
Comment 6 Erik Quaeghebeur 2023-11-05 09:29:54 UTC
(In reply to je_fro@yahoo.com from comment #5)
> scikit-learn-1.3.2 running fine here - no performance issues with
> cython-3.0.5
So this bug should depend on 910258.
Comment 7 Larry the Git Cow gentoo-dev 2023-11-06 10:46:59 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=753fc662cd996655f64043b4a7e37e4c289e7002

commit 753fc662cd996655f64043b4a7e37e4c289e7002
Author:     Andrew Ammerlaan <andrewammerlaan@gentoo.org>
AuthorDate: 2023-11-06 10:43:28 +0000
Commit:     Andrew Ammerlaan <andrewammerlaan@gentoo.org>
CommitDate: 2023-11-06 10:46:40 +0000

    sci-libs/scikit-learn: add 1.3.2
    
    Bug: https://bugs.gentoo.org/911369
    Closes: https://bugs.gentoo.org/910258
    Signed-off-by: Andrew Ammerlaan <andrewammerlaan@gentoo.org>

 sci-libs/scikit-learn/Manifest                  |  1 +
 sci-libs/scikit-learn/scikit-learn-1.3.2.ebuild | 60 +++++++++++++++++++++++++
 2 files changed, 61 insertions(+)
Comment 8 Larry the Git Cow gentoo-dev 2024-03-10 14:49:31 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c0e92ea164933bf207efe2b81f1a53ed14939a1e

commit c0e92ea164933bf207efe2b81f1a53ed14939a1e
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-03-10 14:48:52 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-03-10 14:48:56 +0000

    sci-libs/scikit-learn: drop 1.1.2
    
    Closes: https://bugs.gentoo.org/911369
    Signed-off-by: Sam James <sam@gentoo.org>

 sci-libs/scikit-learn/Manifest                  |  1 -
 sci-libs/scikit-learn/scikit-learn-1.1.2.ebuild | 64 -------------------------
 2 files changed, 65 deletions(-)