Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 910712 - xfce-extra/xfce4-cpugraph-plugin-1.2.8: fails to build with error: 'uint32_t' does not name a type
Summary: xfce-extra/xfce4-cpugraph-plugin-1.2.8: fails to build with error: 'uint32_t'...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: XFCE Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-07-23 08:15 UTC by Holger Hoffstätte
Modified: 2023-07-24 18:41 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Simple patch to add explicitly include <cstdint> (gcc13.patch,211 bytes, patch)
2023-07-23 08:21 UTC, Holger Hoffstätte
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Holger Hoffstätte 2023-07-23 08:15:07 UTC
Trying to biuld 1.2.8:

gtk.cc:38:18: error: 'uint32_t' does not name a type
   38 |     static const uint32_t MAGIC = 0x1A2AB40F;
      |                  ^~~~~~~~
gtk.cc:22:1: note: 'uint32_t' is defined in header '<cstdint>'; did you forget to '#include <cstdint>'?
   21 | #include "gtk.h"
  +++ |+#include <cstdint>
   22 | 

Indeed adding the <cstdint> include makes it compile. I think explicitly requiring this include was a recent change in libstdc++ with gcc-13.


Reproducible: Always




I tried to create a PR on upstream xfce-gitlab but somehow am not allowed todo so - sorry.
Comment 1 Holger Hoffstätte 2023-07-23 08:21:29 UTC
Created attachment 866000 [details, diff]
Simple patch to add explicitly include <cstdint>
Comment 2 Holger Hoffstätte 2023-07-23 11:11:10 UTC
Apparently this also affects 1.2.7 - just didn't notice until now since I last built it with gcc-12.
Comment 3 Holger Hoffstätte 2023-07-24 14:30:54 UTC
The linked PR creates ~revbumps for both 1.2.7 (stable) and 1.2.8.
Hope this helps.
Comment 4 Larry the Git Cow gentoo-dev 2023-07-24 18:41:34 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5d4b482354e12221ed685a99f93c79b3de7735bf

commit 5d4b482354e12221ed685a99f93c79b3de7735bf
Author:     Holger Hoffstätte <holger@applied-asynchrony.com>
AuthorDate: 2023-07-24 14:21:44 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2023-07-24 18:41:11 +0000

    xfce-extra/xfce4-cpugraph-plugin: add fix for gcc-13 (missing cstdint)
    
    Closes: https://bugs.gentoo.org/910712
    Signed-off-by: Holger Hoffstätte <holger@applied-asynchrony.com>
    Closes: https://github.com/gentoo/gentoo/pull/32022
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 xfce-extra/xfce4-cpugraph-plugin/files/gcc13.patch       | 16 ++++++++++++++++
 .../xfce4-cpugraph-plugin-1.2.7.ebuild                   |  2 ++
 .../xfce4-cpugraph-plugin-1.2.8.ebuild                   |  2 ++
 3 files changed, 20 insertions(+)