Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 910576 - gui-wm/hyprland-0.27.2 fails to compile with USE nvidia
Summary: gui-wm/hyprland-0.27.2 fails to compile with USE nvidia
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Julien Roy
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2023-07-20 07:36 UTC by Rahil Bhimjiani
Modified: 2023-08-02 16:08 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Nvidia Patch Hyprland-0.27.2 (nvidia-0.27.2.patch,1.19 KB, patch)
2023-08-02 12:20 UTC, Gonçalo Negrier Duarte
Details | Diff
Nvidia & ebuild Patch Hyprland-0.27.2 (ebuild-hyprland-0.27.2-wlroots-nvidia.patch,4.43 KB, patch)
2023-08-02 16:08 UTC, Gonçalo Negrier Duarte
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rahil Bhimjiani 2023-07-20 07:36:38 UTC
fails to compile cause included patch is too old. 

src_prepare() {
     if use video_cards_nvidia; then
         cd "${S}/subprojects/wlroots" || die
         eapply "${FILESDIR}/nvidia-0.25.0.patch"
         cd "${S}" || die
     fi

     default                                       
 }

ebuild seems to be doing applying wrong patch but upstream suggests applying  https://github.com/hyprwm/Hyprland/blob/main/nix/wlroots-nvidia.patch
Comment 1 Martin 2023-07-20 17:49:10 UTC
Same problem here.

The upstream patch moved to https://github.com/hyprwm/Hyprland/blob/main/nix/patches/wlroots-nvidia.patch
Comment 2 Jim Tupper 2023-07-21 15:47:28 UTC
Can also confirm this is happening. Can also confirm that applying the updated patch works fine.
Comment 3 Larry the Git Cow gentoo-dev 2023-07-23 01:52:25 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=71cc36f285c34660ac8acc5cb96e86470f0bc02b

commit 71cc36f285c34660ac8acc5cb96e86470f0bc02b
Author:     Alfred Wingate <parona@protonmail.com>
AuthorDate: 2023-07-21 00:27:20 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-07-23 01:36:14 +0000

    gui-wm/hyprland: use updated patch for VIDEO_CARDS=nvidia
    
    Closes: https://bugs.gentoo.org/910576
    Signed-off-by: Alfred Wingate <parona@protonmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/31983
    Signed-off-by: Sam James <sam@gentoo.org>

 gui-wm/hyprland/hyprland-0.27.2.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 4 Gonçalo Negrier Duarte 2023-08-02 12:19:33 UTC
I know the probem is mark as fix but the patch use on nix os dosent solve the problem of corrupted output on gaming laptop that use dGPU for the external output.

On gaming laptop the external screen show black lines and black boxes instead of a clean output, for solve this render/gles2/renderer.c also need to be patch.

On the attachments you have the patch i made using the latest version of hyprland

Best Regards
Gonçalo Nergier Duarte
Comment 5 Gonçalo Negrier Duarte 2023-08-02 12:20:16 UTC
Created attachment 866843 [details, diff]
Nvidia Patch Hyprland-0.27.2
Comment 6 Julien Roy 2023-08-02 14:27:02 UTC
Has this problem been reported upstream? Is this a patch you made or is it an official patch provided by Hyprland?
Comment 7 Gonçalo Negrier Duarte 2023-08-02 14:37:27 UTC
Its not official patch it base on hyprland wiki Nvidia section i also open file a new bug report with everything.

https://bugs.gentoo.org/911597

I also open a pull request upstream to see if get added.
Comment 8 Gonçalo Negrier Duarte 2023-08-02 14:40:33 UTC
Sorry @Julien i kinda dont answer or question. Yes the patch was made by me!

Here you it the hyprland wiki to help understart why i create the patch: https://wiki.hyprland.org/Nvidia/
Comment 9 Gonçalo Negrier Duarte 2023-08-02 16:08:44 UTC
Created attachment 866854 [details, diff]
Nvidia & ebuild Patch Hyprland-0.27.2