Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 910434 - media-plugins/gst-plugins-libnice-0.1.21 version bump
Summary: media-plugins/gst-plugins-libnice-0.1.21 version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: GStreamer package maintainers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-07-16 17:29 UTC by Joseph McElroy
Modified: 2023-08-01 00:43 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
ebuild (gst-plugins-libnice-0.1.21.ebuild,1.21 KB, application/vnd.gentoo.ebuild)
2023-07-16 17:30 UTC, Joseph McElroy
Details
patch (gst-plugins-libnice-0.1.21-use-installed-libnice.patch,1.74 KB, patch)
2023-07-16 17:31 UTC, Joseph McElroy
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph McElroy 2023-07-16 17:29:15 UTC
Was hoping this would be an easy version bump for my first ebuild submission, but there's a file collision issue upon install with /usr/include/nice/nice-version.h. It builds fine otherwise, and installs if I remove that file manually, so if I could just get help understanding how to modify the patch or ebuild to tell it to allow net-libs/libnice to provide that file then I'll submit a pull request. I also updated the wiki link and changed EAPI to 8. Thanks!
Comment 1 Joseph McElroy 2023-07-16 17:30:49 UTC
Created attachment 865607 [details]
ebuild
Comment 2 Joseph McElroy 2023-07-16 17:31:19 UTC
Created attachment 865608 [details, diff]
patch
Comment 3 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-07-27 23:12:46 UTC
Thanks.

https://gitlab.freedesktop.org/libnice/libnice/-/merge_requests/259 might sort it.

(It looks like the patch is the same so no need to update it btw, wrt the one you attached.)
Comment 4 Larry the Git Cow gentoo-dev 2023-07-28 01:08:35 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=552c98e4e933c0d0d3c334e22059538eb3594111

commit 552c98e4e933c0d0d3c334e22059538eb3594111
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2023-07-28 01:08:09 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-07-28 01:08:26 +0000

    media-plugins/gst-plugins-libnice: add 0.1.21
    
    Thanks to Joseph McElroy for the assistance.
    
    Closes: https://bugs.gentoo.org/910434
    Signed-off-by: Sam James <sam@gentoo.org>

 media-plugins/gst-plugins-libnice/Manifest         |  1 +
 ...plugins-libnice-0.1.21-no-install-version.patch | 84 ++++++++++++++++++++++
 ...gins-libnice-0.1.21-use-installed-libnice.patch | 46 ++++++++++++
 .../gst-plugins-libnice-0.1.21.ebuild              | 43 +++++++++++
 4 files changed, 174 insertions(+)
Comment 5 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-07-28 01:13:58 UTC
Thanks. I went ahead and pushed this (although I was planning on waiting for a PR to get you contirbuting!) because the conflict is kind of nasty for users and I felt guilty for missing this in the first place.
Comment 6 Joseph McElroy 2023-08-01 00:43:32 UTC
No worries, thank you.