Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 910364 - dev-qt/qtmultimedia-6.5.1 doesn't need X11 dep with USE=ffmpeg, if qtbase is build without xlib
Summary: dev-qt/qtmultimedia-6.5.1 doesn't need X11 dep with USE=ffmpeg, if qtbase is ...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Qt Bug Alias
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-07-14 18:01 UTC by Yaroslav Isakov
Modified: 2023-09-05 13:05 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Yaroslav Isakov 2023-07-14 18:01:39 UTC
Hello! I found that dev-qt/qtmultimedia-6.5.1 is not requiring X11 libraries for ffmpeg - according to CMake, they're only needed if qtbase was built with support for xlib. I checked this, on my X11-less system, with qtbase[-X], by dropping x11-libs/* deps from qtmutlimedia build - and it compiled and worked. Please, guard these deps with X flag, too.
Comment 1 Larry the Git Cow gentoo-dev 2023-09-05 13:05:41 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=027ad31d186fbd6a120cb83b4086e6d5c234debd

commit 027ad31d186fbd6a120cb83b4086e6d5c234debd
Author:     Ionen Wolkens <ionen@gentoo.org>
AuthorDate: 2023-08-26 15:38:45 +0000
Commit:     Ionen Wolkens <ionen@gentoo.org>
CommitDate: 2023-09-05 13:01:08 +0000

    dev-qt/qtmultimedia: tighten deps, make X+qml optional (qt6)
    
    Hopefully right, kind of confusing.
    
    Notes:
    * qtbase[X=]: checks qtbase for wether to use xlib or not,
      we "could" probably force xlib off safely in "this" case
      but that still tend to be messy with Qt's ABI
    * gst[X=]: similarly checks if enabled through defines, may
      possibly break without this if build against gst[X] then
      disable it
    * qtbase[opengl=,vulkan=]: untested but source is literred in
      QT_CONFIG(opengl) and some (vulkan) and would most likely
      break if not matching like others (e.g. qtdeclarative) are
      known to
    * ^ but for gstreamer, we can use gstreamer_gl feature
    * qtshadertools is only used to call qsb that I can see, so
      move to BDEPEND, albeit does come with the caveat that
      (unlike qtdeclarative), it does not look for it separately
      to find it during cross-compilation
    * qtsvg seems only used by examples, dropping may however have
      the downside that very few packages pull qtsvg and it is often
      needed by other applications (but it is wrong here)
    * pulse[glib] dropped, may have been needed in the past but failing
      to see the need for USE=glib right now
    
    X is enabled by default on qtbase, gst-plugins-base, and
    here, so it should hopefully not cause mismatch headaches
    even on non-desktop profiles (assuming users don't try to
    manually enable X/opengl/vulkan per-packages). Pure wayland
    systems should be able to avoid X11 entirely with Qt6.
    
    Note that it "looks" for gstreamer even when it is disabled,
    so it may give xorg-proto warnings (if missing) if gst was built
    with USE=X. Non-issue given in that situation we don't use
    gstreamer. If gst[-X], then xorg-proto is not needed at all.
    
    Closes: https://bugs.gentoo.org/910364
    Signed-off-by: Ionen Wolkens <ionen@gentoo.org>

 ...a-6.5.2.ebuild => qtmultimedia-6.5.2-r1.ebuild} | 44 ++++++++++++----------
 dev-qt/qtmultimedia/qtmultimedia-6.5.9999.ebuild   | 44 ++++++++++++----------
 dev-qt/qtmultimedia/qtmultimedia-6.9999.ebuild     | 44 ++++++++++++----------
 3 files changed, 75 insertions(+), 57 deletions(-)