Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 910340 - sci-electronics/gtkwave forces dependency to wayland
Summary: sci-electronics/gtkwave forces dependency to wayland
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: The Soldering-Iron Brotherhood
URL:
Whiteboard:
Keywords: PATCH, PullRequest
Depends on:
Blocks:
 
Reported: 2023-07-14 14:27 UTC by Sylvain Munaut
Modified: 2024-12-01 12:12 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Proposed fix (gtkwave-wayland-fix.diff,930 bytes, patch)
2023-07-14 14:27 UTC, Sylvain Munaut
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sylvain Munaut 2023-07-14 14:27:58 UTC
Created attachment 865490 [details, diff]
Proposed fix

To fix #866680 there was a forced dependency added to wayland.

Instead I would add the following patch which uses the proper defines to condition the inclusion of the needed header file. All the actual _uses_ of wayland stuff is already conditionned on that define, so it's just that include that's the issue.

Tested that it build fine without wayland with that diff applied.
Comment 1 Sylvain Munaut 2023-07-15 05:29:18 UTC
BTW upstream applied (an equivalent) patch now. It's not yet in 3.3.115 (latest release) but it will be in 3.3.116.
Comment 2 Dominique Michel 2024-09-12 16:13:08 UTC
Same issue here.

On https://gtkwave.sourceforge.net/ they say 3.3.120 is out.
Comment 3 Larry the Git Cow gentoo-dev 2024-12-01 12:12:37 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=74fc3e98fbeebc65dde24cb71b4d304104578ca8

commit 74fc3e98fbeebc65dde24cb71b4d304104578ca8
Author:     Fabio Rossi <rossi.f@inwind.it>
AuthorDate: 2024-10-07 13:27:08 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-12-01 12:10:15 +0000

    sci-electronics/gtkwave: added latest version 3.3.121
    
    Closes: https://bugs.gentoo.org/906602
    Closes: https://bugs.gentoo.org/910340
    Closes: https://bugs.gentoo.org/928738
    Signed-off-by: Fabio Rossi <rossi.f@inwind.it>
    Closes: https://github.com/gentoo/gentoo/pull/38923
    Signed-off-by: Sam James <sam@gentoo.org>

 sci-electronics/gtkwave/Manifest               |  1 +
 sci-electronics/gtkwave/gtkwave-3.3.121.ebuild | 65 ++++++++++++++++++++++++++
 2 files changed, 66 insertions(+)